2019-02-05 11:33:47

by Sameer Pujar

[permalink] [raw]
Subject: [PATCH] ARM: tegra: enforce PM requirement

Drivers need to handle !PM case with work arounds for managing clocks
and power explicitly, which is not really necessary when PM support on
tegra is in good shape. In fact ARM 64-bit tegra platforms enforce PM
support and there is no reason why this cannot be done for 32-bit.

This patch selects PM unconditionally and drivers can rely on runtime
PM framework for clock and power management.

Signed-off-by: Sameer Pujar <[email protected]>
Reviewed-by: Thierry Reding <[email protected]>
Reviewed-by: Jonathan Hunter <[email protected]>
---
arch/arm/mach-tegra/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
index 7f3b83e..51a8fa3 100644
--- a/arch/arm/mach-tegra/Kconfig
+++ b/arch/arm/mach-tegra/Kconfig
@@ -10,6 +10,7 @@ menuconfig ARCH_TEGRA
select HAVE_ARM_SCU if SMP
select HAVE_ARM_TWD if SMP
select PINCTRL
+ select PM
select PM_OPP
select ARCH_HAS_RESET_CONTROLLER
select RESET_CONTROLLER
--
2.7.4



2019-02-11 14:24:23

by Sameer Pujar

[permalink] [raw]
Subject: Re: [PATCH] ARM: tegra: enforce PM requirement


On 2/5/2019 4:46 PM, Sameer Pujar wrote:
> Drivers need to handle !PM case with work arounds for managing clocks
> and power explicitly, which is not really necessary when PM support on
> tegra is in good shape. In fact ARM 64-bit tegra platforms enforce PM
> support and there is no reason why this cannot be done for 32-bit.
>
> This patch selects PM unconditionally and drivers can rely on runtime
> PM framework for clock and power management.
>
> Signed-off-by: Sameer Pujar <[email protected]>
> Reviewed-by: Thierry Reding <[email protected]>
> Reviewed-by: Jonathan Hunter <[email protected]>
> ---
> arch/arm/mach-tegra/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
> index 7f3b83e..51a8fa3 100644
> --- a/arch/arm/mach-tegra/Kconfig
> +++ b/arch/arm/mach-tegra/Kconfig
> @@ -10,6 +10,7 @@ menuconfig ARCH_TEGRA
> select HAVE_ARM_SCU if SMP
> select HAVE_ARM_TWD if SMP
> select PINCTRL
> + select PM
> select PM_OPP
> select ARCH_HAS_RESET_CONTROLLER
> select RESET_CONTROLLER

Request for review comments or approval.

Thanks,
Sameer.


2019-02-25 15:15:53

by Dmitry Osipenko

[permalink] [raw]
Subject: Re: [PATCH] ARM: tegra: enforce PM requirement

05.02.2019 14:16, Sameer Pujar пишет:
> Drivers need to handle !PM case with work arounds for managing clocks
> and power explicitly, which is not really necessary when PM support on
> tegra is in good shape. In fact ARM 64-bit tegra platforms enforce PM

Tegra

> support and there is no reason why this cannot be done for 32-bit.
>
> This patch selects PM unconditionally and drivers can rely on runtime
> PM framework for clock and power management.
>
> Signed-off-by: Sameer Pujar <[email protected]>
> Reviewed-by: Thierry Reding <[email protected]>
> Reviewed-by: Jonathan Hunter <[email protected]>
> ---

You probably should explain in the commit message what driver need this right now and why.