2017-11-08 15:36:03

by Govinda Tatti

[permalink] [raw]
Subject: Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute



On 11/8/2017 9:09 AM, Juergen Gross wrote:
> On 08/11/17 16:00, Govinda Tatti wrote:
>> Thanks Roger for your review comments. Please see below for my comments.
>>
>> On 11/7/2017 5:21 AM, Roger Pau Monné wrote:
>>> On Mon, Nov 06, 2017 at 12:48:42PM -0500, Govinda Tatti wrote:
>>>> +out:
>>>> +    if (!err)
>>>> +        err = count;
>>>> +
>>>> +    return err;
>>> What's the purpose of returning count here?
>> Not sure. Will check with Konrad and address this comment.
> You are telling sysfs that you have consumed all input characters.
>
Thanks Juergen

Cheers
GOVINDA

From 1583511091145646305@xxx Wed Nov 08 15:10:57 +0000 2017
X-GM-THRID: 1583346318922306893
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread