2024-02-06 01:24:01

by Hannes Reinecke

[permalink] [raw]
Subject: Re: [PATCH 2/2] fnic: move fnic_fnic_flush_tx() to a work queue

On 1/31/24 00:42, Lee Duncan wrote:
> From: Hannes Reinecke <[email protected]>
>
> Rather than call 'fnic_flush_tx()' from interrupt context we should
> be moving it onto a work queue to avoid any locking issues.
>
> Signed-off-by: Hannes Reinecke <[email protected]>
> Signed-off-by: Lee Duncan <[email protected]>
> ---
> drivers/scsi/fnic/fnic.h | 3 ++-
> drivers/scsi/fnic/fnic_fcs.c | 3 ++-
> drivers/scsi/fnic/fnic_main.c | 1 +
> drivers/scsi/fnic/fnic_scsi.c | 4 ++--
> 4 files changed, 7 insertions(+), 4 deletions(-)
>
Can you please add the 'fixes' tag to this one, too?
Just the first patch doesn't fix anything, one really would
need to apply both to get the issue fixed.

And, of course, fix the kbuild robot warning :-)

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
[email protected] +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald,
Werner Knoblich