From: Kieran Bingham <[email protected]>
The D3 supports two LVDS channels. Extend the binding to support them.
Signed-off-by: Kieran Bingham <[email protected]>
---
Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
index 79860f58a7ad..0dcf488b70df 100644
--- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
+++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
@@ -14,6 +14,7 @@ Required properties:
- compatible : Shall contain one of
- "renesas,lvds-r8a7795" for R8A7795 (R-Car H3) compatible LVDS encoders
- "renesas,lvds-r8a7796" for R8A7796 (R-Car M3-W) compatible LVDS encoders
+ - "renesas,lvds-r8a77995" for R8A77995 (R-Car D3) compatible LVDS encoders
- reg: Base address and length for the memory-mapped registers
- clocks: A phandle + clock-specifier pair for the functional clock
--
2.7.4
On 15/02/18 08:38, Kieran Bingham wrote:
> From: Kieran Bingham <[email protected]>
>
> The D3 supports two LVDS channels. Extend the binding to support them.
>
> Signed-off-by: Kieran Bingham <[email protected]>
> ---
> Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> index 79860f58a7ad..0dcf488b70df 100644
> --- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> @@ -14,6 +14,7 @@ Required properties:
> - compatible : Shall contain one of
> - "renesas,lvds-r8a7795" for R8A7795 (R-Car H3) compatible LVDS encoders
> - "renesas,lvds-r8a7796" for R8A7796 (R-Car M3-W) compatible LVDS encoders
> + - "renesas,lvds-r8a77995" for R8A77995 (R-Car D3) compatible LVDS encoders
Hi Laurent,
Are we unable to have a generic lvds-gen3 here?
(Although to perhaps answer my own question I see that the D3/E3 have extra
registers)
Also "lets pretend" that I intentionally separated out the LVDS updates to the
rcar_lvds_of_table :)
--
Kieran
>
> - reg: Base address and length for the memory-mapped registers
> - clocks: A phandle + clock-specifier pair for the functional clock
>
Hi Kieran,
Thank you for the patch.
On Thursday, 15 February 2018 10:38:18 EET Kieran Bingham wrote:
> From: Kieran Bingham <[email protected]>
>
> The D3 supports two LVDS channels. Extend the binding to support them.
>
> Signed-off-by: Kieran Bingham <[email protected]>
> ---
> Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt index
> 79860f58a7ad..0dcf488b70df 100644
> --- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> @@ -14,6 +14,7 @@ Required properties:
> - compatible : Shall contain one of
> - "renesas,lvds-r8a7795" for R8A7795 (R-Car H3) compatible LVDS encoders
> - "renesas,lvds-r8a7796" for R8A7796 (R-Car M3-W) compatible LVDS
> encoders
> + - "renesas,lvds-r8a77995" for R8A77995 (R-Car D3) compatible
> LVDS encoders
This should be "renesas,r8a77995-lvds". I've already fixed the series you've
based this patch on.
Apart from this,
Reviewed-by: Laurent Pinchart <[email protected]>
and taken in my tree with the compatible string fixed.
>
> - reg: Base address and length for the memory-mapped registers
> - clocks: A phandle + clock-specifier pair for the functional clock
--
Regards,
Laurent Pinchart
Hi Kieran,
On Thursday, 15 February 2018 10:45:33 EET Kieran Bingham wrote:
> On 15/02/18 08:38, Kieran Bingham wrote:
> > From: Kieran Bingham <[email protected]>
> >
> > The D3 supports two LVDS channels. Extend the binding to support them.
> >
> > Signed-off-by: Kieran Bingham <[email protected]>
> > ---
> >
> > Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> > b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt index
> > 79860f58a7ad..0dcf488b70df 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt
> >
> > @@ -14,6 +14,7 @@ Required properties:
> > - compatible : Shall contain one of
> > - "renesas,lvds-r8a7795" for R8A7795 (R-Car H3) compatible LVDS
> > encoders
> > - "renesas,lvds-r8a7796" for R8A7796 (R-Car M3-W) compatible LVDS
> > encoders
> > + - "renesas,lvds-r8a77995" for R8A77995 (R-Car D3) compatible LVDS
> > encoders
>
> Hi Laurent,
>
> Are we unable to have a generic lvds-gen3 here?
>
> (Although to perhaps answer my own question I see that the D3/E3 have extra
> registers)
>
> Also "lets pretend" that I intentionally separated out the LVDS updates to
> the rcar_lvds_of_table :)
We could for H3 and M3-W, but as you've noticed D3/E3 differ, and so does V3M.
> > - reg: Base address and length for the memory-mapped registers
> > - clocks: A phandle + clock-specifier pair for the functional clock
--
Regards,
Laurent Pinchart