Now that the driver core can properly handle constant struct bus_type,
move the dma_subsys variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.
Cc: Greg Kroah-Hartman <[email protected]>
Suggested-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Ricardo B. Marliere <[email protected]>
---
arch/sh/drivers/dma/dma-sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sh/drivers/dma/dma-sysfs.c b/arch/sh/drivers/dma/dma-sysfs.c
index 431bc18f0a41..9f666280d80c 100644
--- a/arch/sh/drivers/dma/dma-sysfs.c
+++ b/arch/sh/drivers/dma/dma-sysfs.c
@@ -15,7 +15,7 @@
#include <linux/string.h>
#include <asm/dma.h>
-static struct bus_type dma_subsys = {
+static const struct bus_type dma_subsys = {
.name = "dma",
.dev_name = "dma",
};
---
base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
change-id: 20240204-bus_cleanup-sh-6d3c136da6bb
Best regards,
--
Ricardo B. Marliere <[email protected]>
On Sun, Feb 4, 2024 at 4:14 PM Ricardo B. Marliere <[email protected]> wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the dma_subsys variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Ricardo,
On Sun, 2024-02-04 at 12:15 -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the dma_subsys variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>
> ---
> arch/sh/drivers/dma/dma-sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sh/drivers/dma/dma-sysfs.c b/arch/sh/drivers/dma/dma-sysfs.c
> index 431bc18f0a41..9f666280d80c 100644
> --- a/arch/sh/drivers/dma/dma-sysfs.c
> +++ b/arch/sh/drivers/dma/dma-sysfs.c
> @@ -15,7 +15,7 @@
> #include <linux/string.h>
> #include <asm/dma.h>
>
> -static struct bus_type dma_subsys = {
> +static const struct bus_type dma_subsys = {
> .name = "dma",
> .dev_name = "dma",
> };
>
> ---
> base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
> change-id: 20240204-bus_cleanup-sh-6d3c136da6bb
>
> Best regards,
Reviewed-by: John Paul Adrian Glaubitz <[email protected]>
Thanks for your patch. I will merge it into my linux-sh this weekend
after returning from FOSDEM, either this evening or tomorrow.
Thanks,
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
On 5 Feb 06:17, John Paul Adrian Glaubitz wrote:
> Hi Ricardo,
>
> On Sun, 2024-02-04 at 12:15 -0300, Ricardo B. Marliere wrote:
> > Now that the driver core can properly handle constant struct bus_type,
> > move the dma_subsys variable to be a constant structure as well,
> > placing it into read-only memory which can not be modified at runtime.
> >
> > Cc: Greg Kroah-Hartman <[email protected]>
> > Suggested-by: Greg Kroah-Hartman <[email protected]>
> > Signed-off-by: Ricardo B. Marliere <[email protected]>
> > ---
> > arch/sh/drivers/dma/dma-sysfs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/sh/drivers/dma/dma-sysfs.c b/arch/sh/drivers/dma/dma-sysfs.c
> > index 431bc18f0a41..9f666280d80c 100644
> > --- a/arch/sh/drivers/dma/dma-sysfs.c
> > +++ b/arch/sh/drivers/dma/dma-sysfs.c
> > @@ -15,7 +15,7 @@
> > #include <linux/string.h>
> > #include <asm/dma.h>
> >
> > -static struct bus_type dma_subsys = {
> > +static const struct bus_type dma_subsys = {
> > .name = "dma",
> > .dev_name = "dma",
> > };
> >
> > ---
> > base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
> > change-id: 20240204-bus_cleanup-sh-6d3c136da6bb
> >
> > Best regards,
>
> Reviewed-by: John Paul Adrian Glaubitz <[email protected]>
>
> Thanks for your patch. I will merge it into my linux-sh this weekend
> after returning from FOSDEM, either this evening or tomorrow.
Hi John,
thanks for reviewing. I was wondering if your tree should be listed
under SUPERH in the MAINTAINERS file? I didn't find it there and had to
do some searching.
All the best,
- Ricardo.
>
> Thanks,
> Adrian
>
> --
> .''`. John Paul Adrian Glaubitz
> : :' : Debian Developer
> `. `' Physicist
> `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Hi Ricardo,
On Mon, 2024-02-05 at 09:09 -0300, Ricardo B. Marliere wrote:
> thanks for reviewing. I was wondering if your tree should be listed
> under SUPERH in the MAINTAINERS file? I didn't find it there and had to
> do some searching.
You're absolutely right. I got my tree set up after I was added to the
MAINTAINERS file, so I eventually forgot to add the URL to my tree.
I will send a patch this week to correct that. Thanks for the heads-up!
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
On Sun, Feb 04, 2024 at 12:15:09PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the dma_subsys variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>
Reviewed-by: Greg Kroah-Hartman <[email protected]>