2017-09-25 07:51:05

by Arvind Yadav

Subject: [PATCH] ipmi: pr_err() strings should end with newlines

pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/char/ipmi/ipmi_dmi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_dmi.c b/drivers/char/ipmi/ipmi_dmi.c
index 2a84401..66dafcd 100644
--- a/drivers/char/ipmi/ipmi_dmi.c
+++ b/drivers/char/ipmi/ipmi_dmi.c
@@ -71,13 +71,13 @@ static void __init dmi_add_platform_ipmi(unsigned long base_addr,
size = 2;
break;
default:
- pr_err("ipmi:dmi: Invalid IPMI type: %d", type);
+ pr_err("ipmi:dmi: Invalid IPMI type: %d\n", type);
return;
}

pdev = platform_device_alloc(name, ipmi_dmi_nr);
if (!pdev) {
- pr_err("ipmi:dmi: Error allocation IPMI platform device");
+ pr_err("ipmi:dmi: Error allocation IPMI platform device\n");
return;
}
pdev->driver_override = override;
@@ -239,7 +239,7 @@ static void __init dmi_decode_ipmi(const struct dmi_header *dm)
offset = 16;
break;
default:
- pr_err("ipmi:dmi: Invalid offset: 0");
+ pr_err("ipmi:dmi: Invalid offset: 0\n");
return;
}
}
--
1.9.1

2017-09-27 20:35:22

by Corey Minyard

Subject: Re: [PATCH] ipmi: pr_err() strings should end with newlines

On 09/25/2017 02:49 AM, Arvind Yadav wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.

Thanks, it's queued for the next release.

-corey

> Signed-off-by: Arvind Yadav <[email protected]>
> ---
> drivers/char/ipmi/ipmi_dmi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_dmi.c b/drivers/char/ipmi/ipmi_dmi.c
> index 2a84401..66dafcd 100644
> --- a/drivers/char/ipmi/ipmi_dmi.c
> +++ b/drivers/char/ipmi/ipmi_dmi.c
> @@ -71,13 +71,13 @@ static void __init dmi_add_platform_ipmi(unsigned long base_addr,
> size = 2;
> break;
> default:
> - pr_err("ipmi:dmi: Invalid IPMI type: %d", type);
> + pr_err("ipmi:dmi: Invalid IPMI type: %d\n", type);
> return;
> }
>
> pdev = platform_device_alloc(name, ipmi_dmi_nr);
> if (!pdev) {
> - pr_err("ipmi:dmi: Error allocation IPMI platform device");
> + pr_err("ipmi:dmi: Error allocation IPMI platform device\n");
> return;
> }
> pdev->driver_override = override;
> @@ -239,7 +239,7 @@ static void __init dmi_decode_ipmi(const struct dmi_header *dm)
> offset = 16;
> break;
> default:
> - pr_err("ipmi:dmi: Invalid offset: 0");
> + pr_err("ipmi:dmi: Invalid offset: 0\n");
> return;
> }
> }