2015-04-23 09:28:55

by Firo Yang

Subject: [PATCH] hpfs: Remove unessary cast

Avoid a pointless kmem_cache_alloc() return value cast in
fs/hpfs/super.c::hpfs_alloc_inode()

Signed-off-by: Firo Yang <[email protected]>
---
fs/hpfs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c
index 7cd00d3..ccace08 100644
--- a/fs/hpfs/super.c
+++ b/fs/hpfs/super.c
@@ -201,7 +201,7 @@ static struct kmem_cache * hpfs_inode_cachep;
static struct inode *hpfs_alloc_inode(struct super_block *sb)
{
struct hpfs_inode_info *ei;
- ei = (struct hpfs_inode_info *)kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
+ ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
if (!ei)
return NULL;
ei->vfs_inode.i_version = 1;
--
2.1.0

2015-05-02 08:36:08

by Mikulas Patocka

Subject: [PATCH] hpfs: Remove unessary cast

Avoid a pointless kmem_cache_alloc() return value cast in
fs/hpfs/super.c::hpfs_alloc_inode()

Signed-off-by: Firo Yang <[email protected]>
Acked-by: Mikulas Patocka <[email protected]>

---
fs/hpfs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
>
diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c
index 7cd00d3..ccace08 100644
--- a/fs/hpfs/super.c
+++ b/fs/hpfs/super.c
@@ -201,7 +201,7 @@ static struct kmem_cache * hpfs_inode_cachep;
static struct inode *hpfs_alloc_inode(struct super_block *sb)
{
struct hpfs_inode_info *ei;
- ei = (struct hpfs_inode_info *)kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
+ ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
if (!ei)
return NULL;
ei->vfs_inode.i_version = 1;

2015-05-02 16:30:37

by Linus Torvalds

Subject: Re: [PATCH] hpfs: Remove unessary cast

Mikulas, when forwarding patches from others, you also need to add that

"From: Firo Yang <[email protected]>"

at the top (and it can be nice if you also add the date-line).
Otherwise authorship gets lost.

Sign-off lines _normally_ show the whole authorship chain too, but no,
it's not enough to just have the sign-off line there.

Linus

On Sat, May 2, 2015 at 1:10 AM, Mikulas Patocka <[email protected]> wrote:
> Avoid a pointless kmem_cache_alloc() return value cast in
> fs/hpfs/super.c::hpfs_alloc_inode()
>
> Signed-off-by: Firo Yang <[email protected]>
> Acked-by: Mikulas Patocka <[email protected]>
>
>
> ---
> fs/hpfs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
> diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c
> index 7cd00d3..ccace08 100644
> --- a/fs/hpfs/super.c
> +++ b/fs/hpfs/super.c
> @@ -201,7 +201,7 @@ static struct kmem_cache * hpfs_inode_cachep;
> static struct inode *hpfs_alloc_inode(struct super_block *sb)
> {
> struct hpfs_inode_info *ei;
> - ei = (struct hpfs_inode_info *)kmem_cache_alloc(hpfs_inode_cachep,
> GFP_NOFS);
> + ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
> if (!ei)
> return NULL;
> ei->vfs_inode.i_version = 1;

2015-05-02 17:13:42

by Mikulas Patocka

Subject: Re: [PATCH] hpfs: Remove unessary cast

On Sat, 2 May 2015, Linus Torvalds wrote:

> Mikulas, when forwarding patches from others, you also need to add that
>
> "From: Firo Yang <[email protected]>"
>
> at the top (and it can be nice if you also add the date-line).
> Otherwise authorship gets lost.
>
> Sign-off lines _normally_ show the whole authorship chain too, but no,
> it's not enough to just have the sign-off line there.
>
> Linus

OK, so I sent it the second time, I hope that your script processes it
better.

Mikulas