2016-03-01 17:39:50

by Moritz Fischer

Subject: [PATCH] fpga-manager: Replaced macro with static inline function

Signed-off-by: Moritz Fischer <[email protected]>
---
include/linux/fpga/fpga-mgr.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h
index 0940bf4..8064f1b 100644
--- a/include/linux/fpga/fpga-mgr.h
+++ b/include/linux/fpga/fpga-mgr.h
@@ -107,7 +107,10 @@ struct fpga_manager {
void *priv;
};

-#define to_fpga_manager(d) container_of(d, struct fpga_manager, dev)
+static inline struct fpga_manager *to_fpga_manager(struct device *d)
+{
+ return container_of(d, struct fpga_manager, dev);
+}

int fpga_mgr_buf_load(struct fpga_manager *mgr, u32 flags,
const char *buf, size_t count);
--
2.4.3

2016-03-01 18:24:53

by Greg Kroah-Hartman

Subject: Re: [PATCH] fpga-manager: Replaced macro with static inline function

On Tue, Mar 01, 2016 at 09:39:33AM -0800, Moritz Fischer wrote:
> Signed-off-by: Moritz Fischer <[email protected]>
> ---
> include/linux/fpga/fpga-mgr.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)


We can't take patches without a changelog comment explaining why this
change is needed :(

2016-03-01 18:50:18

by atull

Subject: Re: [PATCH] fpga-manager: Replaced macro with static inline function

On Tue, 1 Mar 2016, Moritz Fischer wrote:

> Signed-off-by: Moritz Fischer <[email protected]>
> ---
> include/linux/fpga/fpga-mgr.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h
> index 0940bf4..8064f1b 100644
> --- a/include/linux/fpga/fpga-mgr.h
> +++ b/include/linux/fpga/fpga-mgr.h
> @@ -107,7 +107,10 @@ struct fpga_manager {
> void *priv;
> };
>
> -#define to_fpga_manager(d) container_of(d, struct fpga_manager, dev)
> +static inline struct fpga_manager *to_fpga_manager(struct device *d)
> +{
> + return container_of(d, struct fpga_manager, dev);
> +}

Hi Moritz,

I really appreciate your work on this stuff. But I don't think we need to
do this.

Alan


>
> int fpga_mgr_buf_load(struct fpga_manager *mgr, u32 flags,
> const char *buf, size_t count);
> --
> 2.4.3
>
>