2018-04-10 05:53:29

by Julia Lawall

Subject: [PATCH] drm: xlnx: pl_disp: fix odd_ptr_err.cocci warnings

From: Fengguang Wu <[email protected]>

PTR_ERR should normally access the value just tested by IS_ERR

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

Fixes: 742243a44a73 ("drm: xlnx: pl_disp: Use xlnx pipeline calls")
CC: Hyun Kwon <[email protected]>
Signed-off-by: Fengguang Wu <[email protected]>
Signed-off-by: Julia Lawall <[email protected]>
---

tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v4.14
head: fe04d2ee0dfea6b5fdbb04f4f6dbcaa13bfd2fda
commit: 742243a44a738b165f8da5cbdb6662139e85a5c5 [651/842] drm: xlnx:
pl_disp: Use xlnx pipeline calls


xlnx_pl_disp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/gpu/drm/xlnx/xlnx_pl_disp.c
+++ b/drivers/gpu/drm/xlnx/xlnx_pl_disp.c
@@ -482,7 +482,7 @@ static int xlnx_pl_disp_probe(struct pla

xlnx_pl_disp->master = xlnx_drm_pipeline_init(pdev);
if (IS_ERR(xlnx_pl_disp->master)) {
- ret = PTR_ERR(xlnx_pl_disp->dev);
+ ret = PTR_ERR(xlnx_pl_disp->master);
dev_err(dev, "failed to initialize the drm pipeline\n");
goto err_component;
}

2018-04-24 23:44:11

by Laurent Pinchart

Subject: Re: [PATCH] drm: xlnx: pl_disp: fix odd_ptr_err.cocci warnings

Hi Julia,

Thank you for the patch.

On Tuesday, 10 April 2018 08:49:40 EEST Julia Lawall wrote:
> From: Fengguang Wu <[email protected]>
>
> PTR_ERR should normally access the value just tested by IS_ERR
>
> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
>
> Fixes: 742243a44a73 ("drm: xlnx: pl_disp: Use xlnx pipeline calls")
> CC: Hyun Kwon <[email protected]>
> Signed-off-by: Fengguang Wu <[email protected]>
> Signed-off-by: Julia Lawall <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

Hyun, do you plan to take care of this patch ? I suppose you can squash it
into the offending commit when upstreaming the driver.

> ---
>
> tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v4.14
> head: fe04d2ee0dfea6b5fdbb04f4f6dbcaa13bfd2fda
> commit: 742243a44a738b165f8da5cbdb6662139e85a5c5 [651/842] drm: xlnx:
> pl_disp: Use xlnx pipeline calls
>
>
> xlnx_pl_disp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/gpu/drm/xlnx/xlnx_pl_disp.c
> +++ b/drivers/gpu/drm/xlnx/xlnx_pl_disp.c
> @@ -482,7 +482,7 @@ static int xlnx_pl_disp_probe(struct pla
>
> xlnx_pl_disp->master = xlnx_drm_pipeline_init(pdev);
> if (IS_ERR(xlnx_pl_disp->master)) {
> - ret = PTR_ERR(xlnx_pl_disp->dev);
> + ret = PTR_ERR(xlnx_pl_disp->master);
> dev_err(dev, "failed to initialize the drm pipeline\n");
> goto err_component;
> }

--
Regards,

Laurent Pinchart