2019-07-25 18:04:52

by Vince Weaver

Subject: [patch] perf.data documentation has wrong units for memory size

The perf.data-file-format documentation incorrectly says the
HEADER_TOTAL_MEM results are in bytes. The results are in kilobytes
(perf reads the value from /proc/meminfo)

Signed-off-by: Vince Weaver <[email protected]>

diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt
index 5f54feb19977..d030c87ed9f5 100644
--- a/tools/perf/Documentation/perf.data-file-format.txt
+++ b/tools/perf/Documentation/perf.data-file-format.txt
@@ -126,7 +126,7 @@ vendor,family,model,stepping. For example: GenuineIntel,6,69,1

HEADER_TOTAL_MEM = 10,

-An uint64_t with the total memory in bytes.
+An uint64_t with the total memory in kilobytes.

HEADER_CMDLINE = 11,

2019-07-27 17:17:12

by Jiri Olsa

Subject: Re: [patch] perf.data documentation has wrong units for memory size

On Thu, Jul 25, 2019 at 11:57:43AM -0400, Vince Weaver wrote:
>
> The perf.data-file-format documentation incorrectly says the
> HEADER_TOTAL_MEM results are in bytes. The results are in kilobytes
> (perf reads the value from /proc/meminfo)
>
> Signed-off-by: Vince Weaver <[email protected]>

Acked-by: Jiri Olsa <[email protected]>

thanks,
jirka

>
> diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt
> index 5f54feb19977..d030c87ed9f5 100644
> --- a/tools/perf/Documentation/perf.data-file-format.txt
> +++ b/tools/perf/Documentation/perf.data-file-format.txt
> @@ -126,7 +126,7 @@ vendor,family,model,stepping. For example: GenuineIntel,6,69,1
>
> HEADER_TOTAL_MEM = 10,
>
> -An uint64_t with the total memory in bytes.
> +An uint64_t with the total memory in kilobytes.
>
> HEADER_CMDLINE = 11,
>

2019-07-30 08:00:29

by tip-bot for Vasyl Gomonovych

Subject: [tip:perf/urgent] perf tools: Fix perf.data documentation units for memory size

Commit-ID: 2e9a06dda10aea81a17c623f08534dac6735434a
Gitweb: https://git.kernel.org/tip/2e9a06dda10aea81a17c623f08534dac6735434a
Author: Vince Weaver <[email protected]>
AuthorDate: Thu, 25 Jul 2019 11:57:43 -0400
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 29 Jul 2019 09:03:43 -0300

perf tools: Fix perf.data documentation units for memory size

The perf.data-file-format documentation incorrectly says the
HEADER_TOTAL_MEM results are in bytes. The results are in kilobytes
(perf reads the value from /proc/meminfo)

Signed-off-by: Vince Weaver <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: http://lkml.kernel.org/r/alpine.DEB.2.21.1907251155500.22624@macbook-air
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/Documentation/perf.data-file-format.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt
index 5f54feb19977..d030c87ed9f5 100644
--- a/tools/perf/Documentation/perf.data-file-format.txt
+++ b/tools/perf/Documentation/perf.data-file-format.txt
@@ -126,7 +126,7 @@ vendor,family,model,stepping. For example: GenuineIntel,6,69,1

HEADER_TOTAL_MEM = 10,

-An uint64_t with the total memory in bytes.
+An uint64_t with the total memory in kilobytes.

HEADER_CMDLINE = 11,