2020-08-28 07:10:28

by Lukas Bulwahn

[permalink] [raw]
Subject: [PATCH] MAINTAINERS: orphan sections with qlogic.com group alias

Previous attempts of getting an answer from the qlogic.com group alias,
i.e., [email protected], have remained unanswered; see
links below.

Mark those sections Orphan to prepare their deletion or give an actual
person a chance to step up to maintain those drivers.

Link: https://lore.kernel.org/linux-spdx/[email protected]
Link: https://lore.kernel.org/linux-spdx/alpine.DEB.2.21.2006300644130.4919@felia
Link: https://lore.kernel.org/linux-spdx/alpine.DEB.2.21.2008270740140.31123@felia

Suggested-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Lukas Bulwahn <[email protected]>
---
applies cleanly on current master and next-20200828

James, Martin, please pick this minor non-urgent patch.

Anil, Sudarsana, if these drivers are still maintained by qlogic, please
provide actual names of people that maintain these drivers.

MAINTAINERS | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3b186ade3597..415058b48a2e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3507,15 +3507,13 @@ F: drivers/net/ethernet/broadcom/bnx2.*
F: drivers/net/ethernet/broadcom/bnx2_*

BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER
-M: [email protected]
L: [email protected]
-S: Supported
+S: Orphan
F: drivers/scsi/bnx2fc/

BROADCOM BNX2I 1/10 GIGABIT iSCSI DRIVER
-M: [email protected]
L: [email protected]
-S: Supported
+S: Orphan
F: drivers/scsi/bnx2i/

BROADCOM BNX2X 10 GIGABIT ETHERNET DRIVER
@@ -14212,9 +14210,8 @@ F: Documentation/networking/device_drivers/ethernet/qlogic/LICENSE.qla3xxx
F: drivers/net/ethernet/qlogic/qla3xxx.*

QLOGIC QLA4XXX iSCSI DRIVER
-M: [email protected]
L: [email protected]
-S: Supported
+S: Orphan
F: Documentation/scsi/LICENSE.qla4xxx
F: drivers/scsi/qla4xxx/

--
2.17.1


2020-08-28 09:20:06

by Roman Bolshakov

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: orphan sections with qlogic.com group alias

On Fri, Aug 28, 2020 at 09:08:24AM +0200, Lukas Bulwahn wrote:
> Previous attempts of getting an answer from the qlogic.com group alias,
> i.e., [email protected], have remained unanswered; see
> links below.
>
> Mark those sections Orphan to prepare their deletion or give an actual
> person a chance to step up to maintain those drivers.
>
> Link: https://lore.kernel.org/linux-spdx/[email protected]
> Link: https://lore.kernel.org/linux-spdx/alpine.DEB.2.21.2006300644130.4919@felia
> Link: https://lore.kernel.org/linux-spdx/alpine.DEB.2.21.2008270740140.31123@felia
>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> applies cleanly on current master and next-20200828
>
> James, Martin, please pick this minor non-urgent patch.
>
> Anil, Sudarsana, if these drivers are still maintained by qlogic, please
> provide actual names of people that maintain these drivers.
>
> MAINTAINERS | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3b186ade3597..415058b48a2e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3507,15 +3507,13 @@ F: drivers/net/ethernet/broadcom/bnx2.*
> F: drivers/net/ethernet/broadcom/bnx2_*
>
> BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER
> -M: [email protected]
> L: [email protected]
> -S: Supported
> +S: Orphan
> F: drivers/scsi/bnx2fc/
>
> BROADCOM BNX2I 1/10 GIGABIT iSCSI DRIVER
> -M: [email protected]
> L: [email protected]
> -S: Supported
> +S: Orphan
> F: drivers/scsi/bnx2i/
>
> BROADCOM BNX2X 10 GIGABIT ETHERNET DRIVER
> @@ -14212,9 +14210,8 @@ F: Documentation/networking/device_drivers/ethernet/qlogic/LICENSE.qla3xxx
> F: drivers/net/ethernet/qlogic/qla3xxx.*
>
> QLOGIC QLA4XXX iSCSI DRIVER
> -M: [email protected]
> L: [email protected]
> -S: Supported
> +S: Orphan
> F: Documentation/scsi/LICENSE.qla4xxx
> F: drivers/scsi/qla4xxx/
>
> --
> 2.17.1
>

CC'd Arun,

I think it's worth to update the alias to:

[email protected]

2020-08-28 10:01:42

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: orphan sections with qlogic.com group alias

On Fri, Aug 28, 2020 at 12:17:58PM +0300, Roman Bolshakov wrote:
> On Fri, Aug 28, 2020 at 09:08:24AM +0200, Lukas Bulwahn wrote:
> > Previous attempts of getting an answer from the qlogic.com group alias,
> > i.e., [email protected], have remained unanswered; see
> > links below.
> >
> > Mark those sections Orphan to prepare their deletion or give an actual
> > person a chance to step up to maintain those drivers.
> >
> > Link: https://lore.kernel.org/linux-spdx/[email protected]
> > Link: https://lore.kernel.org/linux-spdx/alpine.DEB.2.21.2006300644130.4919@felia
> > Link: https://lore.kernel.org/linux-spdx/alpine.DEB.2.21.2008270740140.31123@felia
> >
> > Suggested-by: Greg Kroah-Hartman <[email protected]>
> > Signed-off-by: Lukas Bulwahn <[email protected]>
> > ---
> > applies cleanly on current master and next-20200828
> >
> > James, Martin, please pick this minor non-urgent patch.
> >
> > Anil, Sudarsana, if these drivers are still maintained by qlogic, please
> > provide actual names of people that maintain these drivers.
> >
> > MAINTAINERS | 9 +++------
> > 1 file changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 3b186ade3597..415058b48a2e 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -3507,15 +3507,13 @@ F: drivers/net/ethernet/broadcom/bnx2.*
> > F: drivers/net/ethernet/broadcom/bnx2_*
> >
> > BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER
> > -M: [email protected]
> > L: [email protected]
> > -S: Supported
> > +S: Orphan
> > F: drivers/scsi/bnx2fc/
> >
> > BROADCOM BNX2I 1/10 GIGABIT iSCSI DRIVER
> > -M: [email protected]
> > L: [email protected]
> > -S: Supported
> > +S: Orphan
> > F: drivers/scsi/bnx2i/
> >
> > BROADCOM BNX2X 10 GIGABIT ETHERNET DRIVER
> > @@ -14212,9 +14210,8 @@ F: Documentation/networking/device_drivers/ethernet/qlogic/LICENSE.qla3xxx
> > F: drivers/net/ethernet/qlogic/qla3xxx.*
> >
> > QLOGIC QLA4XXX iSCSI DRIVER
> > -M: [email protected]
> > L: [email protected]
> > -S: Supported
> > +S: Orphan
> > F: Documentation/scsi/LICENSE.qla4xxx
> > F: drivers/scsi/qla4xxx/
> >
> > --
> > 2.17.1
> >
>
> CC'd Arun,
>
> I think it's worth to update the alias to:
>
> [email protected]

Again, no, please remove aliases and use real names and email addresses,
otherwise accountability is lost over time, as we have seen constantly.

thanks,

greg k-h

2020-08-28 13:42:50

by Lukas Bulwahn

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: orphan sections with qlogic.com group alias



On Fri, 28 Aug 2020, Roman Bolshakov wrote:

> On Fri, Aug 28, 2020 at 09:08:24AM +0200, Lukas Bulwahn wrote:
> > Previous attempts of getting an answer from the qlogic.com group alias,
> > i.e., [email protected], have remained unanswered; see
> > links below.
> >
> > Mark those sections Orphan to prepare their deletion or give an actual
> > person a chance to step up to maintain those drivers.
> >
> > Link: https://lore.kernel.org/linux-spdx/[email protected]
> > Link: https://lore.kernel.org/linux-spdx/alpine.DEB.2.21.2006300644130.4919@felia
> > Link: https://lore.kernel.org/linux-spdx/alpine.DEB.2.21.2008270740140.31123@felia
> >
>
> CC'd Arun,
>
> I think it's worth to update the alias to:
>
> [email protected]
>

So, if these drivers are not orphans, you can answer Thomas Gleixner's
original email from 2019. If you can quickly ack that patch set, I am
happy to do the donkey work to get this apply nicely on the current
master (please CC me on that response).

Lukas

2020-08-28 15:04:08

by James Bottomley

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: orphan sections with qlogic.com group alias

On Fri, 2020-08-28 at 15:30 +0200, Lukas Bulwahn wrote:
>
> On Fri, 28 Aug 2020, Roman Bolshakov wrote:
>
> > On Fri, Aug 28, 2020 at 09:08:24AM +0200, Lukas Bulwahn wrote:
> > > Previous attempts of getting an answer from the qlogic.com group
> > > alias, i.e., [email protected], have remained
> > > unanswered; see links below.
> > >
> > > Mark those sections Orphan to prepare their deletion or give an
> > > actual person a chance to step up to maintain those drivers.
> > >
> > > Link: https://lore.kernel.org/linux-spdx/20190606205526.447558989
> > > @linutronix.de
> > > Link: https://lore.kernel.org/linux-spdx/alpine.DEB.2.21.20063006
> > > 44130.4919@felia
> > > Link: https://lore.kernel.org/linux-spdx/alpine.DEB.2.21.20082707
> > > 40140.31123@felia
> > >
> >
> > CC'd Arun,
> >
> > I think it's worth to update the alias to:
> >
> > [email protected]
> >
>
> So, if these drivers are not orphans, you can answer Thomas
> Gleixner's original email from 2019. If you can quickly ack that
> patch set, I am happy to do the donkey work to get this apply nicely
> on the current master (please CC me on that response).

I have to wonder what the object is here: to get the problem fixed or
to make a public spectacle?

Because if the object had been to get the issue fixed, waiting a year
before escalating to the SCSI list isn't the best way to achieve
outcomes, nor is now demanding that the drivers be orphaned for lack of
response to you ... particularly as you've seen the drivers updated
over that time if you actually follow kernel releases.

Qlogic or now Marvell tends to rely somewhat heavily on outsourcing for
driver maintenance and support. Outsourcers, fairly obviously, aren't
going to respond to legal issues like this which are outside of their
remit. What needs to happen is that someone needs to find a person
within the Qlogic org who can get this fixed ... possibly involving
explaining the actual issue along the way. Would you like us to use
our contacts to do that?

James

2020-08-28 15:30:21

by Lukas Bulwahn

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: orphan sections with qlogic.com group alias



On Fri, 28 Aug 2020, James Bottomley wrote:

> On Fri, 2020-08-28 at 15:30 +0200, Lukas Bulwahn wrote:
> >
> > On Fri, 28 Aug 2020, Roman Bolshakov wrote:
> >
> > > On Fri, Aug 28, 2020 at 09:08:24AM +0200, Lukas Bulwahn wrote:
> > > > Previous attempts of getting an answer from the qlogic.com group
> > > > alias, i.e., [email protected], have remained
> > > > unanswered; see links below.
> > > >
> > > > Mark those sections Orphan to prepare their deletion or give an
> > > > actual person a chance to step up to maintain those drivers.
> > > >
> > > > Link: https://lore.kernel.org/linux-spdx/20190606205526.447558989
> > > > @linutronix.de
> > > > Link: https://lore.kernel.org/linux-spdx/alpine.DEB.2.21.20063006
> > > > 44130.4919@felia
> > > > Link: https://lore.kernel.org/linux-spdx/alpine.DEB.2.21.20082707
> > > > 40140.31123@felia
> > > >
> > >
> > > CC'd Arun,
> > >
> > > I think it's worth to update the alias to:
> > >
> > > [email protected]
> > >
> >
> > So, if these drivers are not orphans, you can answer Thomas
> > Gleixner's original email from 2019. If you can quickly ack that
> > patch set, I am happy to do the donkey work to get this apply nicely
> > on the current master (please CC me on that response).
>
> I have to wonder what the object is here: to get the problem fixed or
> to make a public spectacle?
>

Let us get the problem fixed; no spectacle here.

> Because if the object had been to get the issue fixed, waiting a year
> before escalating to the SCSI list isn't the best way to achieve
> outcomes, nor is now demanding that the drivers be orphaned for lack of
> response to you ... particularly as you've seen the drivers updated
> over that time if you actually follow kernel releases.
>

I just followed Greg KH's advice; spdx licensing clean-up is not the top
most priority thing; so it just happened to be laying around for a year.
Feel free to ignore this patch and we solve the problem instead.

> Qlogic or now Marvell tends to rely somewhat heavily on outsourcing for
> driver maintenance and support. Outsourcers, fairly obviously, aren't
> going to respond to legal issues like this which are outside of their
> remit. What needs to happen is that someone needs to find a person
> within the Qlogic org who can get this fixed ... possibly involving
> explaining the actual issue along the way. Would you like us to use
> our contacts to do that?
>

Yes, I (and I will bet the licensing clean-up janitors) welcome if that
legal question can be resolved and the kernel can be cleaned up from
unneeded files.

Lukas

2020-08-28 15:40:12

by James Bottomley

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: orphan sections with qlogic.com group alias

On Fri, 2020-08-28 at 17:28 +0200, Lukas Bulwahn wrote:
>
> On Fri, 28 Aug 2020, James Bottomley wrote:
>
> > On Fri, 2020-08-28 at 15:30 +0200, Lukas Bulwahn wrote:
> > >
> > > On Fri, 28 Aug 2020, Roman Bolshakov wrote:
> > >
> > > > On Fri, Aug 28, 2020 at 09:08:24AM +0200, Lukas Bulwahn wrote:
> > > > > Previous attempts of getting an answer from the qlogic.com
> > > > > group alias, i.e., [email protected], have
> > > > > remained unanswered; see links below.
> > > > >
> > > > > Mark those sections Orphan to prepare their deletion or give
> > > > > an actual person a chance to step up to maintain those
> > > > > drivers.
> > > > >
> > > > > Link: https://lore.kernel.org/linux-spdx/20190606205526.44755
> > > > > 8989
> > > > > @linutronix.de
> > > > > Link: https://lore.kernel.org/linux-spdx/alpine.DEB.2.21.2006
> > > > > 3006
> > > > > 44130.4919@felia
> > > > > Link: https://lore.kernel.org/linux-spdx/alpine.DEB.2.21.2008
> > > > > 2707
> > > > > 40140.31123@felia
> > > > >
> > > >
> > > > CC'd Arun,
> > > >
> > > > I think it's worth to update the alias to:
> > > >
> > > > [email protected]
> > > >
> > >
> > > So, if these drivers are not orphans, you can answer Thomas
> > > Gleixner's original email from 2019. If you can quickly ack that
> > > patch set, I am happy to do the donkey work to get this apply
> > > nicely on the current master (please CC me on that response).
> >
> > I have to wonder what the object is here: to get the problem fixed
> > or to make a public spectacle?
> >
>
> Let us get the problem fixed; no spectacle here.
>
> > Because if the object had been to get the issue fixed, waiting a
> > year before escalating to the SCSI list isn't the best way to
> > achieve outcomes, nor is now demanding that the drivers be orphaned
> > for lack of response to you ... particularly as you've seen the
> > drivers updated over that time if you actually follow kernel
> > releases.
> >
>
> I just followed Greg KH's advice; spdx licensing clean-up is not the
> top most priority thing; so it just happened to be laying around for
> a year. Feel free to ignore this patch and we solve the problem
> instead.

OK, that's the plan then.

> > Qlogic or now Marvell tends to rely somewhat heavily on outsourcing
> > for driver maintenance and support. Outsourcers, fairly obviously,
> > aren't going to respond to legal issues like this which are outside
> > of their remit. What needs to happen is that someone needs to find
> > a person
> > within the Qlogic org who can get this fixed ... possibly involving
> > explaining the actual issue along the way. Would you like us to
> > use
> > our contacts to do that?
> >
>
> Yes, I (and I will bet the licensing clean-up janitors) welcome if
> that legal question can be resolved and the kernel can be cleaned up
> from unneeded files.

OK, because of the high turn over at the Qlogic division due to the
takeover, this will take us some time, but we'll try to find the right
people at least to explain the issue to.

James

2020-08-28 15:42:33

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: orphan sections with qlogic.com group alias


Lukas,

> So, if these drivers are not orphans, you can answer Thomas Gleixner's
> original email from 2019. If you can quickly ack that patch set, I am
> happy to do the donkey work to get this apply nicely on the current
> master (please CC me on that response).

This is the first I hear of this since the patches weren't CC:ed to
linux-scsi. And not all of these changes pertain to storage drivers but
to networking so I am also not sure that mails sent to the above Storage
alias would have ended up in the right place.

But we'll get this fixed up. Reaching out to our contacts at Marvell.

--
Martin K. Petersen Oracle Linux Engineering

2020-08-28 15:48:07

by Lukas Bulwahn

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: orphan sections with qlogic.com group alias



On Fri, 28 Aug 2020, Martin K. Petersen wrote:

>
> Lukas,
>
> > So, if these drivers are not orphans, you can answer Thomas Gleixner's
> > original email from 2019. If you can quickly ack that patch set, I am
> > happy to do the donkey work to get this apply nicely on the current
> > master (please CC me on that response).
>
> This is the first I hear of this since the patches weren't CC:ed to
> linux-scsi. And not all of these changes pertain to storage drivers but
> to networking so I am also not sure that mails sent to the above Storage
> alias would have ended up in the right place.
>
> But we'll get this fixed up. Reaching out to our contacts at Marvell.
>

Thanks, Martin, it is appreciated.

Lukas

2020-09-08 07:00:14

by Arun Easi

[permalink] [raw]
Subject: Re: [EXT] Re: [PATCH] MAINTAINERS: orphan sections with qlogic.com group alias

On Fri, 28 Aug 2020, 8:39am, Martin K. Petersen wrote:

>
> Lukas,
>
> > So, if these drivers are not orphans, you can answer Thomas Gleixner's
> > original email from 2019. If you can quickly ack that patch set, I am
> > happy to do the donkey work to get this apply nicely on the current
> > master (please CC me on that response).
>
> This is the first I hear of this since the patches weren't CC:ed to
> linux-scsi. And not all of these changes pertain to storage drivers but
> to networking so I am also not sure that mails sent to the above Storage
> alias would have ended up in the right place.
>
> But we'll get this fixed up. Reaching out to our contacts at Marvell.
>

Just to keep this thread updated, we are checking with the legal before
ack-ing the change on spdx. Nilesh has already updated Thomas G. about
this on the orignal spdx thread.

Regards,
-Arun
PS: Thanks Roman for the CC. These days our spam filters are a little
unfriendly towards the linux-* e-mails.