2016-11-20 23:40:39

by Randy Dunlap

Subject: [PATCH] openrisc: prevent VGA console, fix builds

From: Randy Dunlap <[email protected]>

OpenRISC does not support VGA console, so prevent that kconfig symbol
from being enabled for OpenRISC, thus fixing these build errors:

drivers/built-in.o: In function `vgacon_save_screen':
vgacon.c:(.text+0x20e0): undefined reference to `screen_info'
vgacon.c:(.text+0x20e8): undefined reference to `screen_info'
drivers/built-in.o: In function `vgacon_init':
vgacon.c:(.text+0x284c): undefined reference to `screen_info'
vgacon.c:(.text+0x2850): undefined reference to `screen_info'
drivers/built-in.o: In function `vgacon_startup':
vgacon.c:(.text+0x28d8): undefined reference to `screen_info'
drivers/built-in.o:vgacon.c:(.text+0x28f0): more undefined references to `screen_info' follow

Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: kbuild test robot <[email protected]>
Cc: Chen Gang <[email protected]>
Cc: Jonas Bonn <[email protected]>
---
drivers/video/console/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Not tested. Can the robot please build-test this patch? Thanks.

--- lnx-49-rc5.orig/drivers/video/console/Kconfig
+++ lnx-49-rc5/drivers/video/console/Kconfig
@@ -9,7 +9,7 @@ config VGA_CONSOLE
depends on !4xx && !8xx && !SPARC && !M68K && !PARISC && !FRV && \
!SUPERH && !BLACKFIN && !AVR32 && !MN10300 && !CRIS && \
(!ARM || ARCH_FOOTBRIDGE || ARCH_INTEGRATOR || ARCH_NETWINDER) && \
- !ARM64 && !ARC && !MICROBLAZE
+ !ARM64 && !ARC && !MICROBLAZE && !OPENRISC
default y
help
Saying Y here will allow you to use Linux in text mode through a

2016-11-30 22:51:04

by Stafford Horne

Subject: Re: [PATCH] openrisc: prevent VGA console, fix builds

On Sun, 20 Nov 2016, Randy Dunlap wrote:

> From: Randy Dunlap <[email protected]>
>
> OpenRISC does not support VGA console, so prevent that kconfig symbol
> from being enabled for OpenRISC, thus fixing these build errors:
>
> drivers/built-in.o: In function `vgacon_save_screen':
> vgacon.c:(.text+0x20e0): undefined reference to `screen_info'
> vgacon.c:(.text+0x20e8): undefined reference to `screen_info'
> drivers/built-in.o: In function `vgacon_init':
> vgacon.c:(.text+0x284c): undefined reference to `screen_info'
> vgacon.c:(.text+0x2850): undefined reference to `screen_info'
> drivers/built-in.o: In function `vgacon_startup':
> vgacon.c:(.text+0x28d8): undefined reference to `screen_info'
> drivers/built-in.o:vgacon.c:(.text+0x28f0): more undefined references to `screen_info' follow
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kbuild test robot <[email protected]>
> Cc: Chen Gang <[email protected]>
> Cc: Jonas Bonn <[email protected]>
> ---
> drivers/video/console/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Not tested. Can the robot please build-test this patch? Thanks.
>
> --- lnx-49-rc5.orig/drivers/video/console/Kconfig
> +++ lnx-49-rc5/drivers/video/console/Kconfig
> @@ -9,7 +9,7 @@ config VGA_CONSOLE
> depends on !4xx && !8xx && !SPARC && !M68K && !PARISC && !FRV && \
> !SUPERH && !BLACKFIN && !AVR32 && !MN10300 && !CRIS && \
> (!ARM || ARCH_FOOTBRIDGE || ARCH_INTEGRATOR || ARCH_NETWINDER) && \
> - !ARM64 && !ARC && !MICROBLAZE
> + !ARM64 && !ARC && !MICROBLAZE && !OPENRISC
> default y
> help
> Saying Y here will allow you to use Linux in text mode through a
>

Hello,

I have pulled this.