2019-10-08 08:19:57

by Colin King

Subject: [PATCH][next] netdevsim: fix spelling mistake "forbidded" -> "forbid"

From: Colin Ian King <[email protected]>

There is a spelling mistake in a NL_SET_ERR_MSG_MOD message. Fix it.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/netdevsim/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
index a3d7d39f231a..ff6ced5487b6 100644
--- a/drivers/net/netdevsim/dev.c
+++ b/drivers/net/netdevsim/dev.c
@@ -486,7 +486,7 @@ static int nsim_dev_reload_down(struct devlink *devlink, bool netns_change,
/* For testing purposes, user set debugfs dont_allow_reload
* value to true. So forbid it.
*/
- NL_SET_ERR_MSG_MOD(extack, "User forbidded reload for testing purposes");
+ NL_SET_ERR_MSG_MOD(extack, "User forbid the reload for testing purposes");
return -EOPNOTSUPP;
}

--
2.20.1

2019-10-08 08:33:12

by Maciej W. Rozycki

Subject: Re: [PATCH][next] netdevsim: fix spelling mistake "forbidded" -> "forbid"

On Tue, 8 Oct 2019, Colin King wrote:

> diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
> index a3d7d39f231a..ff6ced5487b6 100644
> --- a/drivers/net/netdevsim/dev.c
> +++ b/drivers/net/netdevsim/dev.c
> @@ -486,7 +486,7 @@ static int nsim_dev_reload_down(struct devlink *devlink, bool netns_change,
> /* For testing purposes, user set debugfs dont_allow_reload
> * value to true. So forbid it.
> */
> - NL_SET_ERR_MSG_MOD(extack, "User forbidded reload for testing purposes");
> + NL_SET_ERR_MSG_MOD(extack, "User forbid the reload for testing purposes");

If nitpicking about grammar, then FWIW I believe it should actually be:

NL_SET_ERR_MSG_MOD(extack, "User forbade the reload for testing purposes");

(and then:

NL_SET_ERR_MSG_MOD(extack, "User set up the reload to fail for testing purposes");

elsewhere).

Maciej

2019-10-08 19:18:08

by Jakub Kicinski

Subject: Re: [PATCH][next] netdevsim: fix spelling mistake "forbidded" -> "forbid"

On Tue, 8 Oct 2019 09:29:58 +0100 (BST), Maciej W. Rozycki wrote:
> On Tue, 8 Oct 2019, Colin King wrote:
>
> > diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
> > index a3d7d39f231a..ff6ced5487b6 100644
> > --- a/drivers/net/netdevsim/dev.c
> > +++ b/drivers/net/netdevsim/dev.c
> > @@ -486,7 +486,7 @@ static int nsim_dev_reload_down(struct devlink *devlink, bool netns_change,
> > /* For testing purposes, user set debugfs dont_allow_reload
> > * value to true. So forbid it.
> > */
> > - NL_SET_ERR_MSG_MOD(extack, "User forbidded reload for testing purposes");
> > + NL_SET_ERR_MSG_MOD(extack, "User forbid the reload for testing purposes");
>
> If nitpicking about grammar, then FWIW I believe it should actually be:
>
> NL_SET_ERR_MSG_MOD(extack, "User forbade the reload for testing purposes");
>
> (and then:
>
> NL_SET_ERR_MSG_MOD(extack, "User set up the reload to fail for testing purposes");
>
> elsewhere).

So I consulted with someone vaguely British, and they said they'd use
"forbid" here, therefore I've applied the patch to net-next.