2008-03-26 01:17:21

by Jesper Juhl

[permalink] [raw]
Subject: [PATCH] m68k floppy: kill 'register' keyword from header


When compilers became generally better at optimizing code than humans, the
register keyword became mostly useless. For the floppy driver it certainly
is since it's so slow compared to the rest of the system that optimizing
access to a single variable or two isn't going to make any real
difference
So let's just leave it to the compiler - it'll do a better job anyway.

This patch does away with a few register keywords in the m68k floppy driver.


Signed-off-by: Jesper Juhl <[email protected]>
---

floppy.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/asm-m68k/floppy.h b/include/asm-m68k/floppy.h
index 697d503..18efe25 100644
--- a/include/asm-m68k/floppy.h
+++ b/include/asm-m68k/floppy.h
@@ -182,7 +182,7 @@ static void fd_disable_dma(void)

asmlinkage irqreturn_t floppy_hardint(int irq, void *dev_id)
{
- register unsigned char st;
+ unsigned char st;

#undef TRACE_FLPY_INT
#define NO_FLOPPY_ASSEMBLER
@@ -203,8 +203,8 @@ asmlinkage irqreturn_t floppy_hardint(int irq, void *dev_id)
#endif

{
- register int lcount;
- register char *lptr;
+ int lcount;
+ char *lptr;

/* serve 1st byte fast: */