2011-02-23 22:46:46

by Jesper Juhl

Subject: [PATCH] regulator, mc13xxx: Remove pointless test for unsigned less than zero

The variable 'val' is a 'unsigned int', so it can never be less than zero.
This fact makes the "val < 0" part of the test done in BUG_ON() in
mc13xxx_regulator_get_voltage() rather pointles since it can never have
any effect.
This patch removes the pointless test.

Signed-off-by: Jesper Juhl <[email protected]>
---
mc13xxx-regulator-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c
index f53d31b..2bb5de1 100644
--- a/drivers/regulator/mc13xxx-regulator-core.c
+++ b/drivers/regulator/mc13xxx-regulator-core.c
@@ -174,7 +174,7 @@ static int mc13xxx_regulator_get_voltage(struct regulator_dev *rdev)

dev_dbg(rdev_get_dev(rdev), "%s id: %d val: %d\n", __func__, id, val);

- BUG_ON(val < 0 || val > mc13xxx_regulators[id].desc.n_voltages);
+ BUG_ON(val > mc13xxx_regulators[id].desc.n_voltages);

return mc13xxx_regulators[id].voltages[val];
}


--
Jesper Juhl <[email protected]> http://www.chaosbits.net/
Plain text mails only, please.
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html

2011-02-24 09:13:27

by Alberto Panizzo

Subject: Re: [PATCH] regulator, mc13xxx: Remove pointless test for unsigned less than zero

On Wed, 2011-02-23 at 23:45 +0100, Jesper Juhl wrote:
> The variable 'val' is a 'unsigned int', so it can never be less than zero.
> This fact makes the "val < 0" part of the test done in BUG_ON() in
> mc13xxx_regulator_get_voltage() rather pointles since it can never have
> any effect.
> This patch removes the pointless test.


Ok for me, but the next time give also the revision of the kernel
your patch is based on (Linus one, Liam one ..) that is the
linus-2.6.38-rc6

Acked-by: Alberto Panizzo <[email protected]>

>
> Signed-off-by: Jesper Juhl <[email protected]>
> ---
> mc13xxx-regulator-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c
> index f53d31b..2bb5de1 100644
> --- a/drivers/regulator/mc13xxx-regulator-core.c
> +++ b/drivers/regulator/mc13xxx-regulator-core.c
> @@ -174,7 +174,7 @@ static int mc13xxx_regulator_get_voltage(struct regulator_dev *rdev)
>
> dev_dbg(rdev_get_dev(rdev), "%s id: %d val: %d\n", __func__, id, val);
>
> - BUG_ON(val < 0 || val > mc13xxx_regulators[id].desc.n_voltages);
> + BUG_ON(val > mc13xxx_regulators[id].desc.n_voltages);
>
> return mc13xxx_regulators[id].voltages[val];
> }
>
>

--
Alberto!

Be Persistent!
- Greg Kroah-Hartman (FOSDEM 2010)

2011-02-24 09:37:22

by Mark Brown

Subject: Re: [PATCH] regulator, mc13xxx: Remove pointless test for unsigned less than zero

On Wed, Feb 23, 2011 at 11:45:55PM +0100, Jesper Juhl wrote:
> The variable 'val' is a 'unsigned int', so it can never be less than zero.
> This fact makes the "val < 0" part of the test done in BUG_ON() in
> mc13xxx_regulator_get_voltage() rather pointles since it can never have
> any effect.
> This patch removes the pointless test.
>
> Signed-off-by: Jesper Juhl <[email protected]>

Acked-by: Mark Brown <[email protected]>

2011-02-24 09:39:42

by Mark Brown

Subject: Re: [PATCH] regulator, mc13xxx: Remove pointless test for unsigned less than zero

On Thu, Feb 24, 2011 at 10:13:07AM +0100, Alberto Panizzo wrote:

> Ok for me, but the next time give also the revision of the kernel
> your patch is based on (Linus one, Liam one ..) that is the
> linus-2.6.38-rc6

There is no need to do this for normal kernel submissions, it should be
obvious where the patch is going (either Linus' tree for urgent enough
fixes or whatever's in -next for the most part).

2011-02-25 08:55:24

by Liam Girdwood

Subject: Re: [PATCH] regulator, mc13xxx: Remove pointless test for unsigned less than zero

On Wed, 2011-02-23 at 23:45 +0100, Jesper Juhl wrote:
> The variable 'val' is a 'unsigned int', so it can never be less than zero.
> This fact makes the "val < 0" part of the test done in BUG_ON() in
> mc13xxx_regulator_get_voltage() rather pointles since it can never have
> any effect.
> This patch removes the pointless test.
>
> Signed-off-by: Jesper Juhl <[email protected]>
> ---
> mc13xxx-regulator-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c
> index f53d31b..2bb5de1 100644
> --- a/drivers/regulator/mc13xxx-regulator-core.c
> +++ b/drivers/regulator/mc13xxx-regulator-core.c
> @@ -174,7 +174,7 @@ static int mc13xxx_regulator_get_voltage(struct regulator_dev *rdev)
>
> dev_dbg(rdev_get_dev(rdev), "%s id: %d val: %d\n", __func__, id, val);
>
> - BUG_ON(val < 0 || val > mc13xxx_regulators[id].desc.n_voltages);
> + BUG_ON(val > mc13xxx_regulators[id].desc.n_voltages);
>
> return mc13xxx_regulators[id].voltages[val];
> }
>

Applied.

Thanks

Liam