2021-12-15 11:29:51

by Hector Martin

Subject: [PATCH] soc: apple: apple-pmgr-pwrstate: Do not build as a module

This doesn't make any sense as a module since it is a critical device,
and it turns out of_phandle_iterator_args was not exported so the module
version doesn't build anyway.

Signed-off-by: Hector Martin <[email protected]>
---
drivers/soc/apple/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/apple/Kconfig b/drivers/soc/apple/Kconfig
index 3eb14abf8d33..9b8de31d6a8f 100644
--- a/drivers/soc/apple/Kconfig
+++ b/drivers/soc/apple/Kconfig
@@ -5,7 +5,7 @@ if ARCH_APPLE || COMPILE_TEST
menu "Apple SoC drivers"

config APPLE_PMGR_PWRSTATE
- tristate "Apple SoC PMGR power state control"
+ bool "Apple SoC PMGR power state control"
depends on PM
select REGMAP
select MFD_SYSCON
--
2.33.0

2021-12-15 11:34:54

by Sven Peter

Subject: Re: [PATCH] soc: apple: apple-pmgr-pwrstate: Do not build as a module

On Wed, Dec 15, 2021, at 12:29, Hector Martin wrote:
> This doesn't make any sense as a module since it is a critical device,
> and it turns out of_phandle_iterator_args was not exported so the module
> version doesn't build anyway.
>
> Signed-off-by: Hector Martin <[email protected]>

I think it'd be nice to add Reported-by: kernel test robot <[email protected]>
here since their service found it and maybe also a Fixes: tag.


Reviewed-by: Sven Peter <[email protected]>



Sven