2023-07-24 01:03:47

by huzhi001

Subject: [PATCH] m68knommu: Fix warnings in io_no.h: Delete one of repeated word 'readw readl writew writel' in comment. WARNING: Possible repeated word: 'readw' WARNING: Possible repeated word: 'readl' WARNING: Possible repeated word: 'writew' WARNING: Possible repeated word: 'writel'

Signed-off-by: ZhiHu <[email protected]>
---
arch/m68k/include/asm/io_no.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/m68k/include/asm/io_no.h
b/arch/m68k/include/asm/io_no.h
index 2c96e8480173..b24eb741e666 100644
--- a/arch/m68k/include/asm/io_no.h
+++ b/arch/m68k/include/asm/io_no.h
@@ -62,7 +62,7 @@ static int cf_internalio(const volatile void __iomem
*addr)
* endian on m68k/ColdFire. Bus based address ranges, like the PCI bus,
* are accessed little endian - so we need to byte swap those.
*/
-#define readw readw
+#define readw
static inline u16 readw(const volatile void __iomem *addr)
{
if (cf_internalio(addr))
@@ -70,7 +70,7 @@ static inline u16 readw(const volatile void __iomem
*addr)
return swab16(__raw_readw(addr));
}

-#define readl readl
+#define readl
static inline u32 readl(const volatile void __iomem *addr)
{
if (cf_internalio(addr))
@@ -78,7 +78,7 @@ static inline u32 readl(const volatile void __iomem
*addr)
return swab32(__raw_readl(addr));
}

-#define writew writew
+#define writew
static inline void writew(u16 value, volatile void __iomem *addr)
{
if (cf_internalio(addr))
@@ -87,7 +87,7 @@ static inline void writew(u16 value, volatile void
__iomem *addr)
__raw_writew(swab16(value), addr);
}

-#define writel writel
+#define writel
static inline void writel(u32 value, volatile void __iomem *addr)
{
if (cf_internalio(addr))

2023-07-24 06:04:52

by Michael Schmitz

Subject: Re: [PATCH] m68knommu: Fix warnings in io_no.h: Delete one of repeated word 'readw readl writew writel' in comment. WARNING: Possible repeated word: 'readw' WARNING: Possible repeated word: 'readl' WARNING: Possible repeated word: 'writew' WARNING: Possible repeated word: 'writel'

Hi,

please reconsider - "#define something something" is legitimate use, and
quite intentional.

Pattern matching can only get you so far, sorry ...

Cheers,

    Michael

Am 24.07.23 um 12:40 schrieb [email protected]:
> Signed-off-by: ZhiHu <[email protected]>
> ---
>  arch/m68k/include/asm/io_no.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/m68k/include/asm/io_no.h
> b/arch/m68k/include/asm/io_no.h
> index 2c96e8480173..b24eb741e666 100644
> --- a/arch/m68k/include/asm/io_no.h
> +++ b/arch/m68k/include/asm/io_no.h
> @@ -62,7 +62,7 @@ static int cf_internalio(const volatile void __iomem
> *addr)
>   * endian on m68k/ColdFire. Bus based address ranges, like the PCI bus,
>   * are accessed little endian - so we need to byte swap those.
>   */
> -#define readw readw
> +#define readw
>  static inline u16 readw(const volatile void __iomem *addr)
>  {
>      if (cf_internalio(addr))
> @@ -70,7 +70,7 @@ static inline u16 readw(const volatile void __iomem
> *addr)
>      return swab16(__raw_readw(addr));
>  }
>
> -#define readl readl
> +#define readl
>  static inline u32 readl(const volatile void __iomem *addr)
>  {
>      if (cf_internalio(addr))
> @@ -78,7 +78,7 @@ static inline u32 readl(const volatile void __iomem
> *addr)
>      return swab32(__raw_readl(addr));
>  }
>
> -#define writew writew
> +#define writew
>  static inline void writew(u16 value, volatile void __iomem *addr)
>  {
>      if (cf_internalio(addr))
> @@ -87,7 +87,7 @@ static inline void writew(u16 value, volatile void
> __iomem *addr)
>          __raw_writew(swab16(value), addr);
>  }
>
> -#define writel writel
> +#define writel
>  static inline void writel(u32 value, volatile void __iomem *addr)
>  {
>      if (cf_internalio(addr))