2022-12-27 16:39:29

by Krzysztof Kozlowski

Subject: [PATCH 1/2] arm64: dts: qcom: sm8350: drop unused dispcc power-domain-names

Display clock controller bindings do not allow power-domain-names:

sm8350-hdk.dtb: clock-controller@af00000: 'power-domain-names' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8350.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index 0726930c9e28..d473194c968d 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -2637,7 +2637,6 @@ dispcc: clock-controller@af00000 {
#power-domain-cells = <1>;

power-domains = <&rpmhpd SM8350_MMCX>;
- power-domain-names = "mmcx";
};

adsp: remoteproc@17300000 {
--
2.34.1

2022-12-27 16:41:05

by Krzysztof Kozlowski

Subject: [PATCH 2/2] arm64: dts: qcom: sc7180-trogdor: align DAI children names with DT schema

Bindings expect DAI children to be named "dai-link":

sc7180-trogdor-coachz-r1.dtb: lpass@62d87000: Unevaluated properties are not allowed ('hdmi@5', 'mi2s@0', 'mi2s@1' were unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index d134d172a3c5..64e85cfb36d3 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -788,18 +788,18 @@ &lpass_cpu {
#address-cells = <1>;
#size-cells = <0>;

- mi2s@0 {
+ dai-link@0 {
reg = <MI2S_PRIMARY>;
qcom,playback-sd-lines = <1>;
qcom,capture-sd-lines = <0>;
};

- secondary_mi2s: mi2s@1 {
+ secondary_mi2s: dai-link@1 {
reg = <MI2S_SECONDARY>;
qcom,playback-sd-lines = <0>;
};

- hdmi@5 {
+ dai-link@5 {
reg = <LPASS_DP_RX>;
};
};
--
2.34.1

2022-12-27 16:55:49

by Konrad Dybcio

Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc7180-trogdor: align DAI children names with DT schema

On 27.12.2022 17:31, Krzysztof Kozlowski wrote:
> Bindings expect DAI children to be named "dai-link":
>
> sc7180-trogdor-coachz-r1.dtb: lpass@62d87000: Unevaluated properties are not allowed ('hdmi@5', 'mi2s@0', 'mi2s@1' were unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index d134d172a3c5..64e85cfb36d3 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -788,18 +788,18 @@ &lpass_cpu {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - mi2s@0 {
> + dai-link@0 {
> reg = <MI2S_PRIMARY>;
> qcom,playback-sd-lines = <1>;
> qcom,capture-sd-lines = <0>;
> };
>
> - secondary_mi2s: mi2s@1 {
> + secondary_mi2s: dai-link@1 {
> reg = <MI2S_SECONDARY>;
> qcom,playback-sd-lines = <0>;
> };
>
> - hdmi@5 {
> + dai-link@5 {
> reg = <LPASS_DP_RX>;
> };
> };

2023-01-17 19:41:35

by Bjorn Andersson

Subject: Re: (subset) [PATCH 1/2] arm64: dts: qcom: sm8350: drop unused dispcc power-domain-names

On Tue, 27 Dec 2022 17:31:57 +0100, Krzysztof Kozlowski wrote:
> Display clock controller bindings do not allow power-domain-names:
>
> sm8350-hdk.dtb: clock-controller@af00000: 'power-domain-names' does not match any of the regexes: 'pinctrl-[0-9]+'
> From schema: Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
>
>

Applied, thanks!

[1/2] arm64: dts: qcom: sm8350: drop unused dispcc power-domain-names
commit: 2aa8c53eb8d711b694545b4eec7f248d50116b8c
[2/2] arm64: dts: qcom: sc7180-trogdor: align DAI children names with DT schema
commit: eef26fb45b6a8d8f68bbfce67db0dfc5fad2946f

Best regards,
--
Bjorn Andersson <[email protected]>