2023-07-31 07:03:59

by Krzysztof Kozlowski

Subject: Re: [PATCH v3 6/8] soc: qcom: socinfo: adjust the position of QDU1010

On 31/07/2023 08:13, Tengfei Fan wrote:
> Adjust the position of QDU1010, so that QDU1010 have
> same sequence with QCOM_ID_QDU1010 in bindings file.
>
> Change-Id: I86d46eca55e877aaa1fd948db99b41ae138a3129

Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.

> ---
> drivers/soc/qcom/socinfo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 4d49945b3a35..ad7699b401a8 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -405,8 +405,8 @@ static const struct soc_id soc_id[] = {
> { qcom_board_id(SA8775P) },
> { qcom_board_id(QRU1000) },
> { qcom_board_id(QDU1000) },
> - { qcom_board_id(QDU1010) },
> { qcom_board_id(IPQ5019) },

Same comment as on previous patch.

> + { qcom_board_id(QDU1010) },

Best regards,
Krzysztof

2023-07-31 09:40:31

by Tengfei Fan

Subject: Re: [PATCH v3 6/8] soc: qcom: socinfo: adjust the position of QDU1010

在 7/31/2023 3:00 PM, Krzysztof Kozlowski 写道:
> On 31/07/2023 08:13, Tengfei Fan wrote:
>> Adjust the position of QDU1010, so that QDU1010 have
>> same sequence with QCOM_ID_QDU1010 in bindings file.
>>
>> Change-Id: I86d46eca55e877aaa1fd948db99b41ae138a3129
>
> Please run scripts/checkpatch.pl and fix reported warnings. Some
> warnings can be ignored, but the code here looks like it needs a fix.
> Feel free to get in touch if the warning is not clear.
>
will check if still need this patch.
>> ---
>> drivers/soc/qcom/socinfo.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
>> index 4d49945b3a35..ad7699b401a8 100644
>> --- a/drivers/soc/qcom/socinfo.c
>> +++ b/drivers/soc/qcom/socinfo.c
>> @@ -405,8 +405,8 @@ static const struct soc_id soc_id[] = {
>> { qcom_board_id(SA8775P) },
>> { qcom_board_id(QRU1000) },
>> { qcom_board_id(QDU1000) },
>> - { qcom_board_id(QDU1010) },
>> { qcom_board_id(IPQ5019) },
>
> Same comment as on previous patch.
>
Will remove this patch, another is handling this:
https://lore.kernel.org/lkml/[email protected]/T/
>> + { qcom_board_id(QDU1010) },
>
> Best regards,
> Krzysztof
>

--
Thx and BRs,
Tengfei Fan