Some older SoCs use a deprecated MBUS binding with some clocks missing.
Currently, new SoCs must opt in to the complete binding. This should be
the default, so new SoCs do not accidentally use the deprecated version.
Signed-off-by: Samuel Holland <[email protected]>
---
.../arm/sunxi/allwinner,sun4i-a10-mbus.yaml | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
index 8eee312c2e6f..2b018feb56df 100644
--- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
@@ -81,13 +81,13 @@ required:
- dma-ranges
if:
- properties:
- compatible:
- contains:
- enum:
- - allwinner,sun8i-h3-mbus
- - allwinner,sun50i-a64-mbus
- - allwinner,sun50i-h5-mbus
+ not:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - allwinner,sun5i-a13-mbus
+ - allwinner,sun8i-r40-mbus
then:
properties:
--
2.35.1
All of the sunxi SoCs since at least the A33 have a similar structure
for the MBUS and DRAM controller, but they all have minor differences in
MBUS port assignments and DRAM controller behavior. Give each SoC its
own compatible.
Signed-off-by: Samuel Holland <[email protected]>
---
.../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
index 2b018feb56df..99566688d033 100644
--- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
@@ -29,10 +29,20 @@ properties:
compatible:
enum:
- allwinner,sun5i-a13-mbus
+ - allwinner,sun8i-a33-mbus
+ - allwinner,sun8i-a50-mbus
+ - allwinner,sun8i-a83t-mbus
- allwinner,sun8i-h3-mbus
- allwinner,sun8i-r40-mbus
+ - allwinner,sun8i-v3s-mbus
+ - allwinner,sun8i-v536-mbus
+ - allwinner,sun20i-d1-mbus
- allwinner,sun50i-a64-mbus
+ - allwinner,sun50i-a100-mbus
- allwinner,sun50i-h5-mbus
+ - allwinner,sun50i-h6-mbus
+ - allwinner,sun50i-h616-mbus
+ - allwinner,sun50i-r329-mbus
reg:
minItems: 1
--
2.35.1
Dne sobota, 02. julij 2022 ob 06:24:46 CEST je Samuel Holland napisal(a):
> Some older SoCs use a deprecated MBUS binding with some clocks missing.
> Currently, new SoCs must opt in to the complete binding. This should be
> the default, so new SoCs do not accidentally use the deprecated version.
>
> Signed-off-by: Samuel Holland <[email protected]>
Reviewed-by: Jernej Skrabec <[email protected]>
Best regards,
Jernej
Dne sobota, 02. julij 2022 ob 06:24:47 CEST je Samuel Holland napisal(a):
> All of the sunxi SoCs since at least the A33 have a similar structure
> for the MBUS and DRAM controller, but they all have minor differences in
> MBUS port assignments and DRAM controller behavior. Give each SoC its
> own compatible.
Shouldn't be compatibles introduced when they are actually used either in
driver or in DT file?
Best regards,
Jernej
>
> Signed-off-by: Samuel Holland <[email protected]>
> ---
>
> .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> index 2b018feb56df..99566688d033 100644
> ---
> a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> +++
> b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> @@ -29,10 +29,20 @@ properties:
> compatible:
> enum:
> - allwinner,sun5i-a13-mbus
> + - allwinner,sun8i-a33-mbus
> + - allwinner,sun8i-a50-mbus
> + - allwinner,sun8i-a83t-mbus
> - allwinner,sun8i-h3-mbus
> - allwinner,sun8i-r40-mbus
> + - allwinner,sun8i-v3s-mbus
> + - allwinner,sun8i-v536-mbus
> + - allwinner,sun20i-d1-mbus
> - allwinner,sun50i-a64-mbus
> + - allwinner,sun50i-a100-mbus
> - allwinner,sun50i-h5-mbus
> + - allwinner,sun50i-h6-mbus
> + - allwinner,sun50i-h616-mbus
> + - allwinner,sun50i-r329-mbus
>
> reg:
> minItems: 1
On Fri, 01 Jul 2022 23:24:47 -0500, Samuel Holland wrote:
> All of the sunxi SoCs since at least the A33 have a similar structure
> for the MBUS and DRAM controller, but they all have minor differences in
> MBUS port assignments and DRAM controller behavior. Give each SoC its
> own compatible.
>
> Signed-off-by: Samuel Holland <[email protected]>
> ---
>
> .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
Acked-by: Rob Herring <[email protected]>
On Fri, 01 Jul 2022 23:24:46 -0500, Samuel Holland wrote:
> Some older SoCs use a deprecated MBUS binding with some clocks missing.
> Currently, new SoCs must opt in to the complete binding. This should be
> the default, so new SoCs do not accidentally use the deprecated version.
>
> Signed-off-by: Samuel Holland <[email protected]>
> ---
>
> .../arm/sunxi/allwinner,sun4i-a10-mbus.yaml | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
Hi Samuel,
On 22. 7. 2. 13:24, Samuel Holland wrote:
> All of the sunxi SoCs since at least the A33 have a similar structure
> for the MBUS and DRAM controller, but they all have minor differences in
> MBUS port assignments and DRAM controller behavior. Give each SoC its
> own compatible.
>
> Signed-off-by: Samuel Holland <[email protected]>
> ---
>
> .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> index 2b018feb56df..99566688d033 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> @@ -29,10 +29,20 @@ properties:
> compatible:
> enum:
> - allwinner,sun5i-a13-mbus
> + - allwinner,sun8i-a33-mbus
> + - allwinner,sun8i-a50-mbus
> + - allwinner,sun8i-a83t-mbus
> - allwinner,sun8i-h3-mbus
> - allwinner,sun8i-r40-mbus
> + - allwinner,sun8i-v3s-mbus
> + - allwinner,sun8i-v536-mbus
> + - allwinner,sun20i-d1-mbus
> - allwinner,sun50i-a64-mbus
> + - allwinner,sun50i-a100-mbus
> - allwinner,sun50i-h5-mbus
> + - allwinner,sun50i-h6-mbus
> + - allwinner,sun50i-h616-mbus
> + - allwinner,sun50i-r329-mbus
>
> reg:
> minItems: 1
I have a question.
Are there the device drivers for the newly added compatible?
--
Best Regards,
Samsung Electronics
Chanwoo Choi
Dne sobota, 02. julij 2022 ob 06:24:46 CEST je Samuel Holland napisal(a):
> Some older SoCs use a deprecated MBUS binding with some clocks missing.
> Currently, new SoCs must opt in to the complete binding. This should be
> the default, so new SoCs do not accidentally use the deprecated version.
>
> Signed-off-by: Samuel Holland <[email protected]>
Applied both, thanks!
Best regards,
Jernej
在 2022-07-01星期五的 23:24 -0500，Samuel Holland写道：
> All of the sunxi SoCs since at least the A33 have a similar structure
> for the MBUS and DRAM controller, but they all have minor differences
> in
> MBUS port assignments and DRAM controller behavior. Give each SoC its
> own compatible.
Should this kind of assignment be described in DT instead?
>
> Signed-off-by: Samuel Holland <[email protected]>
> ---
>
> .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml | 10
> ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-
> mbus.yaml
> b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-
> mbus.yaml
> index 2b018feb56df..99566688d033 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-
> a10-mbus.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-
> a10-mbus.yaml
> @@ -29,10 +29,20 @@ properties:
> compatible:
> enum:
> - allwinner,sun5i-a13-mbus
> + - allwinner,sun8i-a33-mbus
> + - allwinner,sun8i-a50-mbus
> + - allwinner,sun8i-a83t-mbus
> - allwinner,sun8i-h3-mbus
> - allwinner,sun8i-r40-mbus
> + - allwinner,sun8i-v3s-mbus
> + - allwinner,sun8i-v536-mbus
> + - allwinner,sun20i-d1-mbus
> - allwinner,sun50i-a64-mbus
> + - allwinner,sun50i-a100-mbus
> - allwinner,sun50i-h5-mbus
> + - allwinner,sun50i-h6-mbus
> + - allwinner,sun50i-h616-mbus
> + - allwinner,sun50i-r329-mbus
>
> reg:
> minItems: 1
On 7/7/22 3:06 PM, Chanwoo Choi wrote:
> Hi Samuel,
>
> On 22. 7. 2. 13:24, Samuel Holland wrote:
>> All of the sunxi SoCs since at least the A33 have a similar structure
>> for the MBUS and DRAM controller, but they all have minor differences in
>> MBUS port assignments and DRAM controller behavior. Give each SoC its
>> own compatible.
>>
>> Signed-off-by: Samuel Holland <[email protected]>
>> ---
>>
>> .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> index 2b018feb56df..99566688d033 100644
>> --- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> +++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> @@ -29,10 +29,20 @@ properties:
>> compatible:
>> enum:
>> - allwinner,sun5i-a13-mbus
>> + - allwinner,sun8i-a33-mbus
>> + - allwinner,sun8i-a50-mbus
>> + - allwinner,sun8i-a83t-mbus
>> - allwinner,sun8i-h3-mbus
>> - allwinner,sun8i-r40-mbus
>> + - allwinner,sun8i-v3s-mbus
>> + - allwinner,sun8i-v536-mbus
>> + - allwinner,sun20i-d1-mbus
>> - allwinner,sun50i-a64-mbus
>> + - allwinner,sun50i-a100-mbus
>> - allwinner,sun50i-h5-mbus
>> + - allwinner,sun50i-h6-mbus
>> + - allwinner,sun50i-h616-mbus
>> + - allwinner,sun50i-r329-mbus
>>
>> reg:
>> minItems: 1
>
> I have a question.
> Are there the device drivers for the newly added compatible?
There are not DVFS drivers yet. However, the nodes are needed for their
dma-ranges property, which affects some other devices that do have drivers. And
at least for D1, the MBUS node is used for U-Boot's DRAM driver.
Regards,
Samuel