Adding Traces for the following remoteproc events:
rproc_subdev_event,
rproc_interrupt_event,
rproc_load_event,
rproc_start_event,
rproc_stop_event
Signed-off-by: Gokul krishna Krishnakumar <[email protected]>
---
drivers/remoteproc/Kconfig | 5 +
drivers/remoteproc/Makefile | 1 +
drivers/remoteproc/remoteproc_tracepoints.c | 13 ++
include/trace/events/remoteproc_tracepoints.h | 129 ++++++++++++++++++
4 files changed, 148 insertions(+)
create mode 100644 drivers/remoteproc/remoteproc_tracepoints.c
create mode 100644 include/trace/events/remoteproc_tracepoints.h
diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
index a850e9f486dd..2ef4f527f1c1 100644
--- a/drivers/remoteproc/Kconfig
+++ b/drivers/remoteproc/Kconfig
@@ -365,6 +365,11 @@ config XLNX_R5_REMOTEPROC
It's safe to say N if not interested in using RPU r5f cores.
+config REMOTEPROC_TRACEPOINTS
+ bool "Support for Remote Processor subsystem traces"
+ help
+ Say y to add traces to the remoteproc events.
+
endif # REMOTEPROC
endmenu
diff --git a/drivers/remoteproc/Makefile b/drivers/remoteproc/Makefile
index 91314a9b43ce..7045cde5ca76 100644
--- a/drivers/remoteproc/Makefile
+++ b/drivers/remoteproc/Makefile
@@ -10,6 +10,7 @@ remoteproc-y += remoteproc_debugfs.o
remoteproc-y += remoteproc_sysfs.o
remoteproc-y += remoteproc_virtio.o
remoteproc-y += remoteproc_elf_loader.o
+obj-$(CONFIG_REMOTEPROC_TRACEPOINTS) += remoteproc_tracepoints.o
obj-$(CONFIG_REMOTEPROC_CDEV) += remoteproc_cdev.o
obj-$(CONFIG_IMX_REMOTEPROC) += imx_rproc.o
obj-$(CONFIG_IMX_DSP_REMOTEPROC) += imx_dsp_rproc.o
diff --git a/drivers/remoteproc/remoteproc_tracepoints.c b/drivers/remoteproc/remoteproc_tracepoints.c
new file mode 100644
index 000000000000..f082441022c3
--- /dev/null
+++ b/drivers/remoteproc/remoteproc_tracepoints.c
@@ -0,0 +1,13 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+#define CREATE_TRACE_POINTS
+#include <trace/events/remoteproc_tracepoints.h>
+
+EXPORT_TRACEPOINT_SYMBOL_GPL(rproc_load_event);
+EXPORT_TRACEPOINT_SYMBOL_GPL(rproc_start_event);
+EXPORT_TRACEPOINT_SYMBOL_GPL(rproc_stop_event);
+EXPORT_TRACEPOINT_SYMBOL_GPL(rproc_interrupt_event);
+EXPORT_TRACEPOINT_SYMBOL_GPL(rproc_subdev_event);
diff --git a/include/trace/events/remoteproc_tracepoints.h b/include/trace/events/remoteproc_tracepoints.h
new file mode 100644
index 000000000000..f2de61f42eb1
--- /dev/null
+++ b/include/trace/events/remoteproc_tracepoints.h
@@ -0,0 +1,129 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+#undef TRACE_SYSTEM
+#define TRACE_SYSTEM remoteproc_tracepoints
+
+#if !defined(_TRACE_REMOTEPROC_H) || defined(TRACE_HEADER_MULTI_READ)
+#define _TRACE_REMOTEPROC_H
+#include <linux/tracepoint.h>
+#include <linux/remoteproc.h>
+
+/*
+ * Tracepoints for remoteproc and subdevice events
+ */
+TRACE_EVENT(rproc_load_event,
+
+ TP_PROTO(struct rproc *rproc, int ret),
+
+ TP_ARGS(rproc, ret),
+
+ TP_STRUCT__entry(
+ __string(name, rproc->name)
+ __string(firmware, rproc->firmware)
+ __field(int, ret)
+ ),
+
+ TP_fast_assign(
+ __assign_str(name, rproc->name);
+ __assign_str(firmware, rproc->firmware);
+ __entry->ret = ret;
+ ),
+
+ TP_printk("%s loading firmware %s returned %d",
+ __get_str(name), __get_str(firmware),
+ __entry->ret)
+);
+
+TRACE_EVENT(rproc_start_event,
+
+ TP_PROTO(struct rproc *rproc, int ret),
+
+ TP_ARGS(rproc, ret),
+
+ TP_STRUCT__entry(
+ __string(name, rproc->name)
+ __field(int, ret)
+ ),
+
+ TP_fast_assign(
+ __assign_str(name, rproc->name);
+ __entry->ret = ret;
+ ),
+
+ TP_printk("%s %d", __get_str(name), __entry->ret)
+);
+
+TRACE_EVENT(rproc_stop_event,
+
+ TP_PROTO(struct rproc *rproc, const char *crash_msg),
+
+ TP_ARGS(rproc, crash_msg),
+
+ TP_STRUCT__entry(
+ __string(name, rproc->name)
+ __string(crash_msg, crash_msg)
+ ),
+
+ TP_fast_assign(
+ __assign_str(name, rproc->name);
+ __assign_str(crash_msg, crash_msg)
+ ),
+
+ TP_printk("%s %s", __get_str(name), __get_str(crash_msg))
+);
+
+TRACE_EVENT(rproc_interrupt_event,
+
+ TP_PROTO(struct rproc *rproc, const char *event,
+ const char *msg),
+
+ TP_ARGS(rproc, event, msg),
+
+ TP_STRUCT__entry(
+ __string(name, rproc->name)
+ __string(event, event)
+ __string(msg, msg)
+ ),
+
+ TP_fast_assign(
+ __assign_str(name, rproc->name);
+ __assign_str(event, event);
+ __assign_str(msg, msg);
+ ),
+
+ TP_printk("%s %s returned %s", __get_str(name),
+ __get_str(event), __get_str(msg))
+);
+
+TRACE_EVENT(rproc_subdev_event,
+
+ TP_PROTO(const char *rproc, const char *subdev,
+ const char *event, int ret),
+
+ TP_ARGS(rproc, subdev, event, ret),
+
+ TP_STRUCT__entry(
+ __string(rproc, rproc)
+ __string(subdev, subdev)
+ __string(event, event)
+ __field(int, ret)
+ ),
+
+ TP_fast_assign(
+ __assign_str(rproc, rproc);
+ __assign_str(subdev, subdev);
+ __assign_str(event, event);
+ __entry->ret = ret;
+ ),
+
+ TP_printk("rproc:%s subdev:%s event:%s ret:%d",
+ __get_str(rproc), __get_str(subdev),
+ __get_str(event), __entry->ret)
+);
+#endif /* _TRACE_REMOTEPROC_H */
+
+/* This part must be outside protection */
+#include <trace/define_trace.h>
--
2.40.1
On 5/31/2023 2:28 PM, Gokul krishna Krishnakumar wrote:
> Adding Traces for the following remoteproc events:
> rproc_subdev_event,
> rproc_interrupt_event,
> rproc_load_event,
> rproc_start_event,
> rproc_stop_event
>
> Signed-off-by: Gokul krishna Krishnakumar <[email protected]>
> ---
> drivers/remoteproc/Kconfig | 5 +
> drivers/remoteproc/Makefile | 1 +
> drivers/remoteproc/remoteproc_tracepoints.c | 13 ++
> include/trace/events/remoteproc_tracepoints.h | 129 ++++++++++++++++++
> 4 files changed, 148 insertions(+)
> create mode 100644 drivers/remoteproc/remoteproc_tracepoints.c
> create mode 100644 include/trace/events/remoteproc_tracepoints.h
>
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index a850e9f486dd..2ef4f527f1c1 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -365,6 +365,11 @@ config XLNX_R5_REMOTEPROC
>
> It's safe to say N if not interested in using RPU r5f cores.
>
> +config REMOTEPROC_TRACEPOINTS
> + bool "Support for Remote Processor subsystem traces"
> + help
> + Say y to add traces to the remoteproc events.
More information here please. What information these traces provide? How
they can be useful to developers? More text will always be helpful.
---Trilok Soni
On 5/31/2023 2:51 PM, Trilok Soni wrote:
> On 5/31/2023 2:28 PM, Gokul krishna Krishnakumar wrote:
>> Adding Traces for the following remoteproc events:
>> rproc_subdev_event,
>> rproc_interrupt_event,
>> rproc_load_event,
>> rproc_start_event,
>> rproc_stop_event
>>
>> Signed-off-by: Gokul krishna Krishnakumar <[email protected]>
>> ---
>> drivers/remoteproc/Kconfig | 5 +
>> drivers/remoteproc/Makefile | 1 +
>> drivers/remoteproc/remoteproc_tracepoints.c | 13 ++
>> include/trace/events/remoteproc_tracepoints.h | 129 ++++++++++++++++++
>> 4 files changed, 148 insertions(+)
>> create mode 100644 drivers/remoteproc/remoteproc_tracepoints.c
>> create mode 100644 include/trace/events/remoteproc_tracepoints.h
>>
>> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
>> index a850e9f486dd..2ef4f527f1c1 100644
>> --- a/drivers/remoteproc/Kconfig
>> +++ b/drivers/remoteproc/Kconfig
>> @@ -365,6 +365,11 @@ config XLNX_R5_REMOTEPROC
>> It's safe to say N if not interested in using RPU r5f cores.
>> +config REMOTEPROC_TRACEPOINTS
>> + bool "Support for Remote Processor subsystem traces"
>> + help
>> + Say y to add traces to the remoteproc events.
>
> More information here please. What information these traces provide? How
> they can be useful to developers? More text will always be helpful.
>
Say y to add traces to remoteproc events of interest such as the
start/stop/crash events in a remote-processor and also sub-device
stop/start events and there errors.
These traces can be useful while debugging errors with subsystem restart
and draw an estimate on how long each event takes to run.
> ---Trilok Soni
How does this look.
Thanks,
Gokul