2019-09-30 14:25:49

by Dan Murphy

[permalink] [raw]
Subject: [PATCH 1/3] power_supply: Add additional health properties to the header

Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum.

Signed-off-by: Dan Murphy <[email protected]>
---
include/linux/power_supply.h | 3 +++
1 file changed, 3 insertions(+)

diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
index 28413f737e7d..bd0d3225f245 100644
--- a/include/linux/power_supply.h
+++ b/include/linux/power_supply.h
@@ -61,6 +61,9 @@ enum {
POWER_SUPPLY_HEALTH_WATCHDOG_TIMER_EXPIRE,
POWER_SUPPLY_HEALTH_SAFETY_TIMER_EXPIRE,
POWER_SUPPLY_HEALTH_OVERCURRENT,
+ POWER_SUPPLY_HEALTH_WARM,
+ POWER_SUPPLY_HEALTH_COOL,
+ POWER_SUPPLY_HEALTH_HOT,
};

enum {
--
2.22.0.214.g8dca754b1e


2019-10-20 12:25:45

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH 1/3] power_supply: Add additional health properties to the header

Hi,

On Mon, Sep 30, 2019 at 09:31:35AM -0500, Dan Murphy wrote:
> Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum.

You used OVERHEAT instead of HOT in the implementation,
which makes sense to me, so please drop HOT here. Also
this needs to be documented in the ABI documentation:

Documentation/ABI/testing/sysfs-class-power

-- Sebastian

> Signed-off-by: Dan Murphy <[email protected]>
> ---
> include/linux/power_supply.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index 28413f737e7d..bd0d3225f245 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -61,6 +61,9 @@ enum {
> POWER_SUPPLY_HEALTH_WATCHDOG_TIMER_EXPIRE,
> POWER_SUPPLY_HEALTH_SAFETY_TIMER_EXPIRE,
> POWER_SUPPLY_HEALTH_OVERCURRENT,
> + POWER_SUPPLY_HEALTH_WARM,
> + POWER_SUPPLY_HEALTH_COOL,
> + POWER_SUPPLY_HEALTH_HOT,
> };
>
> enum {
> --
> 2.22.0.214.g8dca754b1e
>

Attachments:
(No filename) (0.99 kB)
 signature.asc (849.00 B)
 Download all attachments

2019-10-21 19:38:07

by Dan Murphy

[permalink] [raw]
Subject: Re: [PATCH 1/3] power_supply: Add additional health properties to the header

Sebastian

On 10/20/19 7:25 AM, Sebastian Reichel wrote:
> Hi,
>
> On Mon, Sep 30, 2019 at 09:31:35AM -0500, Dan Murphy wrote:
>> Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum.
> You used OVERHEAT instead of HOT in the implementation,
> which makes sense to me, so please drop HOT here. Also
> this needs to be documented in the ABI documentation:

Hmm.? To me OVERHEAT and HOT can mean two different things.? I will
check the implementation but I would

prefer to use HOT.

If a battery or charger is HOT that may be expected to be within the
heat limits of the device being monitored but that it is hot.

Overheating means the device is above the expected upper thermal limit.?
Or over the heat limit.

The user may want to take action within the hot range to cool the device
or may expect the device to run hot without over heating.


> Documentation/ABI/testing/sysfs-class-power

ACK

Dan