2023-12-12 17:22:20

by Vlastimil Babka

[permalink] [raw]
Subject: [PATCH] Documentation, mm/unaccepted: document accept_memory kernel parameter

The accept_memory kernel parameter was added in commit dcdfdd40fa82
("mm: Add support for unaccepted memory") but not listed in the
kernel-parameters doc. Add it there.

Cc: Kirill A. Shutemov <[email protected]>
Signed-off-by: Vlastimil Babka <[email protected]>
---
Documentation/admin-guide/kernel-parameters.txt | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 65731b060e3f..3a4ebb46073c 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -1,3 +1,13 @@
+ accept_memory= [MM]
+ Format: { eager | lazy }
+ default: lazy
+ By default, unaccepted memory is accepted lazily to
+ avoid prolonged boot at the cost of some runtime
+ overhead until all memory is eventually accepted. In
+ most cases the overhead is negligible but for some
+ workloads or for debugging purposes accept_memory=eager
+ can be used to accept all memory at once during boot.
+
acpi= [HW,ACPI,X86,ARM64,RISCV64]
Advanced Configuration and Power Interface
Format: { force | on | off | strict | noirq | rsdt |

---
base-commit: a39b6ac3781d46ba18193c9dbb2110f31e9bffe9
change-id: 20231212-accept_memory_param-4a7adc5e5582

Best regards,
--
Vlastimil Babka <[email protected]>


2023-12-12 22:41:19

by Kirill A. Shutemov

[permalink] [raw]
Subject: Re: [PATCH] Documentation, mm/unaccepted: document accept_memory kernel parameter

On Tue, Dec 12, 2023 at 06:21:43PM +0100, Vlastimil Babka wrote:
> The accept_memory kernel parameter was added in commit dcdfdd40fa82
> ("mm: Add support for unaccepted memory") but not listed in the
> kernel-parameters doc. Add it there.
>
> Signed-off-by: Vlastimil Babka <[email protected]>

Acked-by: Kirill A. Shutemov <[email protected]>

--
Kiryl Shutsemau / Kirill A. Shutemov

2023-12-12 23:10:18

by Tim Chen

[permalink] [raw]
Subject: Re: [PATCH] Documentation, mm/unaccepted: document accept_memory kernel parameter

On Tue, 2023-12-12 at 18:21 +0100, Vlastimil Babka wrote:
> The accept_memory kernel parameter was added in commit dcdfdd40fa82
> ("mm: Add support for unaccepted memory") but not listed in the
> kernel-parameters doc. Add it there.
>
> Cc: Kirill A. Shutemov <[email protected]>
> Signed-off-by: Vlastimil Babka <[email protected]>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 65731b060e3f..3a4ebb46073c 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -1,3 +1,13 @@
> + accept_memory= [MM]
> + Format: { eager | lazy }
> + default: lazy
> + By default, unaccepted memory is accepted lazily to
> + avoid prolonged boot at the cost of some runtime

Suggest rephrasing this line. Breaking up long line makes reading easier.

avoid prolonged boot. The lazy option will add some runtime

Thanks.

Tim
> + overhead until all memory is eventually accepted. In
> + most cases the overhead is negligible but for some
> + workloads or for debugging purposes accept_memory=eager
> + can be used to accept all memory at once during boot.
> +
> acpi= [HW,ACPI,X86,ARM64,RISCV64]
> Advanced Configuration and Power Interface
> Format: { force | on | off | strict | noirq | rsdt |
>
> ---
> base-commit: a39b6ac3781d46ba18193c9dbb2110f31e9bffe9
> change-id: 20231212-accept_memory_param-4a7adc5e5582
>
> Best regards,