2019-11-03 23:26:56

by Naresh Kamboju

[permalink] [raw]
Subject: stable-rc-4.19: cpufeature.c:909:21: error: 'MIDR_HISI_TSV110' undeclared

stable rc 4.19 branch build broken for arm64 with the below error log,

Build error log,
arch/arm64/kernel/cpufeature.c: In function 'unmap_kernel_at_el0':
arch/arm64/kernel/cpufeature.c:909:21: error: 'MIDR_HISI_TSV110'
undeclared (first use in this function); did you mean
'GICR_ISACTIVER0'?
MIDR_ALL_VERSIONS(MIDR_HISI_TSV110),
^
arch/arm64/include/asm/cputype.h:141:12: note: in definition of macro
'MIDR_RANGE'
.model = m, \
^
arch/arm64/kernel/cpufeature.c:909:3: note: in expansion of macro
'MIDR_ALL_VERSIONS'
MIDR_ALL_VERSIONS(MIDR_HISI_TSV110),
^~~~~~~~~~~~~~~~~
arch/arm64/kernel/cpufeature.c:909:21: note: each undeclared
identifier is reported only once for each function it appears in
MIDR_ALL_VERSIONS(MIDR_HISI_TSV110),
^
arch/arm64/include/asm/cputype.h:141:12: note: in definition of macro
'MIDR_RANGE'
.model = m, \
^
arch/arm64/kernel/cpufeature.c:909:3: note: in expansion of macro
'MIDR_ALL_VERSIONS'
MIDR_ALL_VERSIONS(MIDR_HISI_TSV110),
^~~~~~~~~~~~~~~~~
CC arch/arm64/kvm/inject_fault.o
scripts/Makefile.build:303: recipe for target
'arch/arm64/kernel/cpufeature.o' failed
make[3]: *** [arch/arm64/kernel/cpufeature.o]

Build log link,
https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.19/DISTRO=lkft,MACHINE=hikey,label=docker-lkft/331/consoleText


Best regards
Naresh Kamboju


2019-11-04 01:14:30

by Hanjun Guo

[permalink] [raw]
Subject: Re: stable-rc-4.19: cpufeature.c:909:21: error: 'MIDR_HISI_TSV110' undeclared

Hi Sasha, Greg,

On 2019/11/4 7:22, Naresh Kamboju wrote:
> stable rc 4.19 branch build broken for arm64 with the below error log,
>
> Build error log,
> arch/arm64/kernel/cpufeature.c: In function 'unmap_kernel_at_el0':
> arch/arm64/kernel/cpufeature.c:909:21: error: 'MIDR_HISI_TSV110'
> undeclared (first use in this function); did you mean
> 'GICR_ISACTIVER0'?
> MIDR_ALL_VERSIONS(MIDR_HISI_TSV110),
> ^
> arch/arm64/include/asm/cputype.h:141:12: note: in definition of macro
> 'MIDR_RANGE'
> .model = m, \
> ^
> arch/arm64/kernel/cpufeature.c:909:3: note: in expansion of macro
> 'MIDR_ALL_VERSIONS'
> MIDR_ALL_VERSIONS(MIDR_HISI_TSV110),
> ^~~~~~~~~~~~~~~~~
> arch/arm64/kernel/cpufeature.c:909:21: note: each undeclared
> identifier is reported only once for each function it appears in
> MIDR_ALL_VERSIONS(MIDR_HISI_TSV110),
> ^
> arch/arm64/include/asm/cputype.h:141:12: note: in definition of macro
> 'MIDR_RANGE'
> .model = m, \
> ^
> arch/arm64/kernel/cpufeature.c:909:3: note: in expansion of macro
> 'MIDR_ALL_VERSIONS'
> MIDR_ALL_VERSIONS(MIDR_HISI_TSV110),

Patch "efd00c7 arm64: Add MIDR encoding for HiSilicon Taishan CPUs" needs to
be bacported as well, would you like me to do that, or just cherry-pick by yourself?

Thanks
Hanjun

2019-11-04 11:01:37

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: stable-rc-4.19: cpufeature.c:909:21: error: 'MIDR_HISI_TSV110' undeclared

On Mon, Nov 04, 2019 at 09:10:06AM +0800, Hanjun Guo wrote:
> Hi Sasha, Greg,
>
> On 2019/11/4 7:22, Naresh Kamboju wrote:
> > stable rc 4.19 branch build broken for arm64 with the below error log,
> >
> > Build error log,
> > arch/arm64/kernel/cpufeature.c: In function 'unmap_kernel_at_el0':
> > arch/arm64/kernel/cpufeature.c:909:21: error: 'MIDR_HISI_TSV110'
> > undeclared (first use in this function); did you mean
> > 'GICR_ISACTIVER0'?
> > MIDR_ALL_VERSIONS(MIDR_HISI_TSV110),
> > ^
> > arch/arm64/include/asm/cputype.h:141:12: note: in definition of macro
> > 'MIDR_RANGE'
> > .model = m, \
> > ^
> > arch/arm64/kernel/cpufeature.c:909:3: note: in expansion of macro
> > 'MIDR_ALL_VERSIONS'
> > MIDR_ALL_VERSIONS(MIDR_HISI_TSV110),
> > ^~~~~~~~~~~~~~~~~
> > arch/arm64/kernel/cpufeature.c:909:21: note: each undeclared
> > identifier is reported only once for each function it appears in
> > MIDR_ALL_VERSIONS(MIDR_HISI_TSV110),
> > ^
> > arch/arm64/include/asm/cputype.h:141:12: note: in definition of macro
> > 'MIDR_RANGE'
> > .model = m, \
> > ^
> > arch/arm64/kernel/cpufeature.c:909:3: note: in expansion of macro
> > 'MIDR_ALL_VERSIONS'
> > MIDR_ALL_VERSIONS(MIDR_HISI_TSV110),
>
> Patch "efd00c7 arm64: Add MIDR encoding for HiSilicon Taishan CPUs" needs to
> be bacported as well, would you like me to do that, or just cherry-pick by yourself?

I need the backport please, cherry-pick fails :(

thanks,

greg k-h

2019-11-04 13:13:14

by Hanjun Guo

[permalink] [raw]
Subject: Re: stable-rc-4.19: cpufeature.c:909:21: error: 'MIDR_HISI_TSV110' undeclared

On 2019/11/4 18:59, Greg Kroah-Hartman wrote:
> On Mon, Nov 04, 2019 at 09:10:06AM +0800, Hanjun Guo wrote:
>> Hi Sasha, Greg,
>>
>> On 2019/11/4 7:22, Naresh Kamboju wrote:
>>> stable rc 4.19 branch build broken for arm64 with the below error log,
>>>
>>> Build error log,
>>> arch/arm64/kernel/cpufeature.c: In function 'unmap_kernel_at_el0':
>>> arch/arm64/kernel/cpufeature.c:909:21: error: 'MIDR_HISI_TSV110'
>>> undeclared (first use in this function); did you mean
>>> 'GICR_ISACTIVER0'?
>>> MIDR_ALL_VERSIONS(MIDR_HISI_TSV110),
>>> ^
>>> arch/arm64/include/asm/cputype.h:141:12: note: in definition of macro
>>> 'MIDR_RANGE'
>>> .model = m, \
>>> ^
>>> arch/arm64/kernel/cpufeature.c:909:3: note: in expansion of macro
>>> 'MIDR_ALL_VERSIONS'
>>> MIDR_ALL_VERSIONS(MIDR_HISI_TSV110),
>>> ^~~~~~~~~~~~~~~~~
>>> arch/arm64/kernel/cpufeature.c:909:21: note: each undeclared
>>> identifier is reported only once for each function it appears in
>>> MIDR_ALL_VERSIONS(MIDR_HISI_TSV110),
>>> ^
>>> arch/arm64/include/asm/cputype.h:141:12: note: in definition of macro
>>> 'MIDR_RANGE'
>>> .model = m, \
>>> ^
>>> arch/arm64/kernel/cpufeature.c:909:3: note: in expansion of macro
>>> 'MIDR_ALL_VERSIONS'
>>> MIDR_ALL_VERSIONS(MIDR_HISI_TSV110),
>>
>> Patch "efd00c7 arm64: Add MIDR encoding for HiSilicon Taishan CPUs" needs to
>> be bacported as well, would you like me to do that, or just cherry-pick by yourself?
>
> I need the backport please, cherry-pick fails :(

I will send it out later.

Thanks
Hanjun