2016-10-21 15:52:18

by Javier Martinez Canillas

Subject: [PATCH] leds: netxbig: fix module autoload for OF registration

If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/leds//leds-netxbig.ko | grep alias
alias: platform:leds-netxbig

After this patch:

$ modinfo drivers/leds//leds-netxbig.ko | grep alias
alias: platform:leds-netxbig
alias: of:N*T*Clacie,netxbig-ledsC*
alias: of:N*T*Clacie,netxbig-leds

Signed-off-by: Javier Martinez Canillas <[email protected]>
---

drivers/leds/leds-netxbig.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/leds/leds-netxbig.c b/drivers/leds/leds-netxbig.c
index 4b88b93244be..f48b1aed9b4e 100644
--- a/drivers/leds/leds-netxbig.c
+++ b/drivers/leds/leds-netxbig.c
@@ -534,6 +534,7 @@ static const struct of_device_id of_netxbig_leds_match[] = {
{ .compatible = "lacie,netxbig-leds", },
{},
};
+MODULE_DEVICE_TABLE(of, of_netxbig_leds_match);
#else
static inline int
netxbig_leds_get_of_pdata(struct device *dev,
--
2.7.4

2016-11-29 15:00:47

by Javier Martinez Canillas

Subject: Re: [PATCH] leds: netxbig: fix module autoload for OF registration

Hello Jacek,

On 10/21/2016 12:52 PM, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
> alias: platform:leds-netxbig
>
> After this patch:
>
> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
> alias: platform:leds-netxbig
> alias: of:N*T*Clacie,netxbig-ledsC*
> alias: of:N*T*Clacie,netxbig-leds
>
> Signed-off-by: Javier Martinez Canillas <[email protected]>
> ---
>

Any comments about this patch?

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America

2016-11-29 15:34:58

by Jacek Anaszewski

Subject: Re: [PATCH] leds: netxbig: fix module autoload for OF registration

Hi Javier,

On 11/29/2016 04:00 PM, Javier Martinez Canillas wrote:
> Hello Jacek,
>
> On 10/21/2016 12:52 PM, Javier Martinez Canillas wrote:
>> If the driver is built as a module, autoload won't work because the module
>> alias information is not filled. So user-space can't match the registered
>> device with the corresponding module.
>>
>> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>>
>> Before this patch:
>>
>> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
>> alias: platform:leds-netxbig
>>
>> After this patch:
>>
>> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
>> alias: platform:leds-netxbig
>> alias: of:N*T*Clacie,netxbig-ledsC*
>> alias: of:N*T*Clacie,netxbig-leds
>>
>> Signed-off-by: Javier Martinez Canillas <[email protected]>
>> ---
>>
>
> Any comments about this patch?

I mistakenly marked it as merged. Sorry about that.
Applied to the for-next branch of linux-leds.git.

--
Best regards,
Jacek Anaszewski

2016-11-29 15:39:02

by Javier Martinez Canillas

Subject: Re: [PATCH] leds: netxbig: fix module autoload for OF registration

Hello Jacek,

On 11/29/2016 12:34 PM, Jacek Anaszewski wrote:
> Hi Javier,
>
> On 11/29/2016 04:00 PM, Javier Martinez Canillas wrote:
>> Hello Jacek,
>>
>> On 10/21/2016 12:52 PM, Javier Martinez Canillas wrote:
>>> If the driver is built as a module, autoload won't work because the module
>>> alias information is not filled. So user-space can't match the registered
>>> device with the corresponding module.
>>>
>>> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>>>
>>> Before this patch:
>>>
>>> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
>>> alias: platform:leds-netxbig
>>>
>>> After this patch:
>>>
>>> $ modinfo drivers/leds//leds-netxbig.ko | grep alias
>>> alias: platform:leds-netxbig
>>> alias: of:N*T*Clacie,netxbig-ledsC*
>>> alias: of:N*T*Clacie,netxbig-leds
>>>
>>> Signed-off-by: Javier Martinez Canillas <[email protected]>
>>> ---
>>>
>>
>> Any comments about this patch?
>
> I mistakenly marked it as merged. Sorry about that.
> Applied to the for-next branch of linux-leds.git.
>

Great, thanks for the information.

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America