2019-03-07 21:53:08

by Finn Thain

Subject: [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled

Adjust comments accordingly.

Cc: Gustavo A. R. Silva <[email protected]>
Cc: Michael Schmitz <[email protected]>
Signed-off-by: Finn Thain <[email protected]>
---
drivers/scsi/NCR5380.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
index 7fed9bb72784..fe0535affc14 100644
--- a/drivers/scsi/NCR5380.c
+++ b/drivers/scsi/NCR5380.c
@@ -1932,13 +1932,13 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance)
if (!hostdata->connected)
return;

- /* Fall through to reject message */
-
+ /* Reject message */
+ /* Fall through */
+ default:
/*
* If we get something weird that we aren't expecting,
- * reject it.
+ * log it.
*/
- default:
if (tmp == EXTENDED_MESSAGE)
scmd_printk(KERN_INFO, cmd,
"rejecting unknown extended message code %02x, length %d\n",
--
2.19.2

2019-03-19 18:20:36

by Martin K. Petersen

Subject: Re: [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled

Finn,

> Adjust comments accordingly.

Applied to 5.2/scsi-queue.

--
Martin K. Petersen Oracle Linux Engineering

2019-04-08 23:57:45

by Gustavo A. R. Silva

Subject: Re: [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled

Hi all,

Friendly ping:

Who can take this?

Thanks

On 3/7/19 3:49 PM, Finn Thain wrote:
> Adjust comments accordingly.
>
> Cc: Gustavo A. R. Silva <[email protected]>
> Cc: Michael Schmitz <[email protected]>
> Signed-off-by: Finn Thain <[email protected]>
> ---
> drivers/scsi/NCR5380.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
> index 7fed9bb72784..fe0535affc14 100644
> --- a/drivers/scsi/NCR5380.c
> +++ b/drivers/scsi/NCR5380.c
> @@ -1932,13 +1932,13 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance)
> if (!hostdata->connected)
> return;
>
> - /* Fall through to reject message */
> -
> + /* Reject message */
> + /* Fall through */
> + default:
> /*
> * If we get something weird that we aren't expecting,
> - * reject it.
> + * log it.
> */
> - default:
> if (tmp == EXTENDED_MESSAGE)
> scmd_printk(KERN_INFO, cmd,
> "rejecting unknown extended message code %02x, length %d\n",
>

2019-04-09 00:26:11

by Finn Thain

Subject: Re: [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled

On Mon, 8 Apr 2019, Gustavo A. R. Silva wrote:

> Hi all,
>
> Friendly ping:
>
> Who can take this?
>
> Thanks
>

It has been queued up by Martin and James on git.kernel.org. Apparently it
is to be pushed in the v5.2 merge window.

--

2019-04-09 22:50:07

by Gustavo A. R. Silva

Subject: Re: [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled

On 4/8/19 7:22 PM, Finn Thain wrote:
>
> It has been queued up by Martin and James on git.kernel.org. Apparently it
> is to be pushed in the v5.2 merge window.
>

Awesome.

Thanks
--
Gustavo