2017-09-21 08:46:40

by Sean Wang

Subject: [PATCH] soc: mediatek: place Kconfig for all SoC driver under menu

From: Sean Wang <[email protected]>

Add cleanup for placing all Kconfig for all MediaTek SoC drivers under
the independent menu as other SoCs vendor usually did.

Signed-off-by: Sean Wang <[email protected]>
---
drivers/soc/mediatek/Kconfig | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
index 609bb34..a2fcd7f 100644
--- a/drivers/soc/mediatek/Kconfig
+++ b/drivers/soc/mediatek/Kconfig
@@ -1,6 +1,8 @@
#
# MediaTek SoC drivers
#
+menu "MediaTek SoC drivers"
+
config MTK_INFRACFG
bool "MediaTek INFRACFG Support"
depends on ARCH_MEDIATEK || COMPILE_TEST
@@ -30,3 +32,5 @@ config MTK_SCPSYS
help
Say yes here to add support for the MediaTek SCPSYS power domain
driver.
+
+endmenu
--
2.7.4

2017-09-26 05:56:03

by Jean Delvare

Subject: Re: [PATCH] soc: mediatek: place Kconfig for all SoC driver under menu

On Thu, 21 Sep 2017 16:46:35 +0800, [email protected] wrote:
> From: Sean Wang <[email protected]>
>
> Add cleanup for placing all Kconfig for all MediaTek SoC drivers under
> the independent menu as other SoCs vendor usually did.
>
> Signed-off-by: Sean Wang <[email protected]>
> ---
> drivers/soc/mediatek/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
> index 609bb34..a2fcd7f 100644
> --- a/drivers/soc/mediatek/Kconfig
> +++ b/drivers/soc/mediatek/Kconfig
> @@ -1,6 +1,8 @@
> #
> # MediaTek SoC drivers
> #
> +menu "MediaTek SoC drivers"

Could it depend on ARCH_MEDIATEK || COMPILE_TEST? So that it isn't
presented if it is going to be empty.

> +
> config MTK_INFRACFG
> bool "MediaTek INFRACFG Support"
> depends on ARCH_MEDIATEK || COMPILE_TEST
> @@ -30,3 +32,5 @@ config MTK_SCPSYS
> help
> Say yes here to add support for the MediaTek SCPSYS power domain
> driver.
> +
> +endmenu


--
Jean Delvare
SUSE L3 Support

2017-09-26 07:25:05

by Sean Wang

Subject: Re: [PATCH] soc: mediatek: place Kconfig for all SoC driver under menu

On Tue, 2017-09-26 at 07:55 +0200, Jean Delvare wrote:
> On Thu, 21 Sep 2017 16:46:35 +0800, [email protected] wrote:
> > From: Sean Wang <[email protected]>
> >
> > Add cleanup for placing all Kconfig for all MediaTek SoC drivers under
> > the independent menu as other SoCs vendor usually did.
> >
> > Signed-off-by: Sean Wang <[email protected]>
> > ---
> > drivers/soc/mediatek/Kconfig | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
> > index 609bb34..a2fcd7f 100644
> > --- a/drivers/soc/mediatek/Kconfig
> > +++ b/drivers/soc/mediatek/Kconfig
> > @@ -1,6 +1,8 @@
> > #
> > # MediaTek SoC drivers
> > #
> > +menu "MediaTek SoC drivers"
>
> Could it depend on ARCH_MEDIATEK || COMPILE_TEST? So that it isn't
> presented if it is going to be empty.
>

Okay, I'll add a dependency for the menu. And all "depends on
ARCH_MEDIATEK" for items insides the menu can also be removed.

such as

menu "MediaTek SoC drivers"
+ depends on ARCH_MEDIATEK || COMPILE_TEST

config MTK_INFRACFG
bool "MediaTek INFRACFG Support"
- depends on ARCH_MEDIATEK || COMPILE_TEST
select REGMAP
help
Say yes here to add support for the MediaTek INFRACFG
controller. The
@@ -14,7 +14,6 @@ config MTK_INFRACFG

config MTK_PMIC_WRAP
tristate "MediaTek PMIC Wrapper Support"
- depends on ARCH_MEDIATEK
select RESET_CONTROLLER
select REGMAP
help
@@ -24,7 +23,6 @@ config MTK_PMIC_WRAP

config MTK_SCPSYS
bool "MediaTek SCPSYS Support"
- depends on ARCH_MEDIATEK || COMPILE_TEST
default ARCH_MEDIATEK

> > +
> > config MTK_INFRACFG
> > bool "MediaTek INFRACFG Support"
> > depends on ARCH_MEDIATEK || COMPILE_TEST
> > @@ -30,3 +32,5 @@ config MTK_SCPSYS
> > help
> > Say yes here to add support for the MediaTek SCPSYS power domain
> > driver.
> > +
> > +endmenu
>
>