2024-03-06 19:47:02

by Ayush Singh

Subject: [PATCH] docs: w1: Remove w1_gpio_platform_data

`linux/w1-gpio.h` was removed in a previous patch and should no longer be
needed for using w1 gpio.

- Removal Patch: https://lore.kernel.org/all/[email protected]/

Signed-off-by: Ayush Singh <[email protected]>
---
Documentation/w1/masters/w1-gpio.rst | 6 ------
1 file changed, 6 deletions(-)

diff --git a/Documentation/w1/masters/w1-gpio.rst b/Documentation/w1/masters/w1-gpio.rst
index 15236605503b..5d7eebc291bb 100644
--- a/Documentation/w1/masters/w1-gpio.rst
+++ b/Documentation/w1/masters/w1-gpio.rst
@@ -20,7 +20,6 @@ Example (mach-at91)
::

#include <linux/gpio/machine.h>
- #include <linux/w1-gpio.h>

static struct gpiod_lookup_table foo_w1_gpiod_table = {
.dev_id = "w1-gpio",
@@ -30,14 +29,9 @@ Example (mach-at91)
},
};

- static struct w1_gpio_platform_data foo_w1_gpio_pdata = {
- .ext_pullup_enable_pin = -EINVAL,
- };
-
static struct platform_device foo_w1_device = {
.name = "w1-gpio",
.id = -1,
- .dev.platform_data = &foo_w1_gpio_pdata,
};

...
--
2.44.0

2024-03-06 21:33:50

by Randy Dunlap

Subject: Re: [PATCH] docs: w1: Remove w1_gpio_platform_data

On 3/6/24 11:46, Ayush Singh wrote:
> `linux/w1-gpio.h` was removed in a previous patch and should no longer be
> needed for using w1 gpio.
>
> - Removal Patch: https://lore.kernel.org/all/[email protected]/
>
> Signed-off-by: Ayush Singh <[email protected]>

Possibly add:
Fixes: 9c0a5b3f9e55 ("w1: gpio: Don't use platform data for driver data")

Reviewed-by: Randy Dunlap <[email protected]>
Thanks.

> ---
> Documentation/w1/masters/w1-gpio.rst | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/Documentation/w1/masters/w1-gpio.rst b/Documentation/w1/masters/w1-gpio.rst
> index 15236605503b..5d7eebc291bb 100644
> --- a/Documentation/w1/masters/w1-gpio.rst
> +++ b/Documentation/w1/masters/w1-gpio.rst
> @@ -20,7 +20,6 @@ Example (mach-at91)
> ::
>
> #include <linux/gpio/machine.h>
> - #include <linux/w1-gpio.h>
>
> static struct gpiod_lookup_table foo_w1_gpiod_table = {
> .dev_id = "w1-gpio",
> @@ -30,14 +29,9 @@ Example (mach-at91)
> },
> };
>
> - static struct w1_gpio_platform_data foo_w1_gpio_pdata = {
> - .ext_pullup_enable_pin = -EINVAL,
> - };
> -
> static struct platform_device foo_w1_device = {
> .name = "w1-gpio",
> .id = -1,
> - .dev.platform_data = &foo_w1_gpio_pdata,
> };
>
> ...

--
#Randy

2024-03-07 07:43:45

by Krzysztof Kozlowski

Subject: Re: [PATCH] docs: w1: Remove w1_gpio_platform_data

On 06/03/2024 20:46, Ayush Singh wrote:
> `linux/w1-gpio.h` was removed in a previous patch and should no longer be
> needed for using w1 gpio.
>
> - Removal Patch: https://lore.kernel.org/all/[email protected]/

Do not refer to lore patches for commits which were accepted. Refer to
commits (see submitting patches).



Best regards,
Krzysztof