2022-11-30 14:32:01

by Michael Riesch

Subject: [PATCH 5/5] arm64: dts: rockchip: add pinctrls for 16-bit/18-bit rgb interface to rk356x

The rk3568-pinctrl.dtsi only defines the 24-bit RGB interface. Add separate
nodes for the 16-bit and 18-bit version, respectively. While at it, split
off the clock/sync signals from the data signals.

The exact mapping of the data pins was discussed here:
https://lore.kernel.org/linux-rockchip/[email protected]/T/

Signed-off-by: Michael Riesch <[email protected]>
---
.../boot/dts/rockchip/rk3568-pinctrl.dtsi | 94 +++++++++++++++++++
1 file changed, 94 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-pinctrl.dtsi b/arch/arm64/boot/dts/rockchip/rk3568-pinctrl.dtsi
index 8f90c66dd9e9..0a979bfb63d9 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3568-pinctrl.dtsi
@@ -3117,4 +3117,98 @@ tsadc_pin: tsadc-pin {
<0 RK_PA1 0 &pcfg_pull_none>;
};
};
+
+ lcdc {
+ /omit-if-no-ref/
+ lcdc_clock: lcdc-clock {
+ rockchip,pins =
+ /* lcdc_clk */
+ <3 RK_PA0 1 &pcfg_pull_none>,
+ /* lcdc_den */
+ <3 RK_PC3 1 &pcfg_pull_none>,
+ /* lcdc_hsync */
+ <3 RK_PC1 1 &pcfg_pull_none>,
+ /* lcdc_vsync */
+ <3 RK_PC2 1 &pcfg_pull_none>;
+ };
+
+ /omit-if-no-ref/
+ lcdc_data16: lcdc-data16 {
+ rockchip,pins =
+ /* lcdc_d3 */
+ <2 RK_PD3 1 &pcfg_pull_none>,
+ /* lcdc_d4 */
+ <2 RK_PD4 1 &pcfg_pull_none>,
+ /* lcdc_d5 */
+ <2 RK_PD5 1 &pcfg_pull_none>,
+ /* lcdc_d6 */
+ <2 RK_PD6 1 &pcfg_pull_none>,
+ /* lcdc_d7 */
+ <2 RK_PD7 1 &pcfg_pull_none>,
+ /* lcdc_d10 */
+ <3 RK_PA3 1 &pcfg_pull_none>,
+ /* lcdc_d11 */
+ <3 RK_PA4 1 &pcfg_pull_none>,
+ /* lcdc_d12 */
+ <3 RK_PA5 1 &pcfg_pull_none>,
+ /* lcdc_d13 */
+ <3 RK_PA6 1 &pcfg_pull_none>,
+ /* lcdc_d14 */
+ <3 RK_PA7 1 &pcfg_pull_none>,
+ /* lcdc_d15 */
+ <3 RK_PB0 1 &pcfg_pull_none>,
+ /* lcdc_d19 */
+ <3 RK_PB4 1 &pcfg_pull_none>,
+ /* lcdc_d20 */
+ <3 RK_PB5 1 &pcfg_pull_none>,
+ /* lcdc_d21 */
+ <3 RK_PB6 1 &pcfg_pull_none>,
+ /* lcdc_d22 */
+ <3 RK_PB7 1 &pcfg_pull_none>,
+ /* lcdc_d23 */
+ <3 RK_PC0 1 &pcfg_pull_none>;
+ };
+
+ /omit-if-no-ref/
+ lcdc_data18: lcdc-data18 {
+ rockchip,pins =
+ /* lcdc_d2 */
+ <2 RK_PD2 1 &pcfg_pull_none>,
+ /* lcdc_d3 */
+ <2 RK_PD3 1 &pcfg_pull_none>,
+ /* lcdc_d4 */
+ <2 RK_PD4 1 &pcfg_pull_none>,
+ /* lcdc_d5 */
+ <2 RK_PD5 1 &pcfg_pull_none>,
+ /* lcdc_d6 */
+ <2 RK_PD6 1 &pcfg_pull_none>,
+ /* lcdc_d7 */
+ <2 RK_PD7 1 &pcfg_pull_none>,
+ /* lcdc_d10 */
+ <3 RK_PA3 1 &pcfg_pull_none>,
+ /* lcdc_d11 */
+ <3 RK_PA4 1 &pcfg_pull_none>,
+ /* lcdc_d12 */
+ <3 RK_PA5 1 &pcfg_pull_none>,
+ /* lcdc_d13 */
+ <3 RK_PA6 1 &pcfg_pull_none>,
+ /* lcdc_d14 */
+ <3 RK_PA7 1 &pcfg_pull_none>,
+ /* lcdc_d15 */
+ <3 RK_PB0 1 &pcfg_pull_none>,
+ /* lcdc_d18 */
+ <3 RK_PB3 1 &pcfg_pull_none>,
+ /* lcdc_d19 */
+ <3 RK_PB4 1 &pcfg_pull_none>,
+ /* lcdc_d20 */
+ <3 RK_PB5 1 &pcfg_pull_none>,
+ /* lcdc_d21 */
+ <3 RK_PB6 1 &pcfg_pull_none>,
+ /* lcdc_d22 */
+ <3 RK_PB7 1 &pcfg_pull_none>,
+ /* lcdc_d23 */
+ <3 RK_PC0 1 &pcfg_pull_none>;
+ };
+ };
+
};
--
2.30.2

2023-01-19 12:21:12

by Michael Riesch

Subject: Re: [PATCH 5/5] arm64: dts: rockchip: add pinctrls for 16-bit/18-bit rgb interface to rk356x

Hi Heiko,

On 11/30/22 15:02, Michael Riesch wrote:
> The rk3568-pinctrl.dtsi only defines the 24-bit RGB interface. Add separate
> nodes for the 16-bit and 18-bit version, respectively. While at it, split
> off the clock/sync signals from the data signals.
>
> The exact mapping of the data pins was discussed here:
> https://lore.kernel.org/linux-rockchip/[email protected]/T/
>
> Signed-off-by: Michael Riesch <[email protected]>

This patch is somewhat independent of the other patches of the series.
In particular it is not affected by the comments that this series has
received so far. If there are no objections, you might consider applying it.

Thanks and best regards,
Michael

> ---
> .../boot/dts/rockchip/rk3568-pinctrl.dtsi | 94 +++++++++++++++++++
> 1 file changed, 94 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-pinctrl.dtsi b/arch/arm64/boot/dts/rockchip/rk3568-pinctrl.dtsi
> index 8f90c66dd9e9..0a979bfb63d9 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-pinctrl.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-pinctrl.dtsi
> @@ -3117,4 +3117,98 @@ tsadc_pin: tsadc-pin {
> <0 RK_PA1 0 &pcfg_pull_none>;
> };
> };
> +
> + lcdc {
> + /omit-if-no-ref/
> + lcdc_clock: lcdc-clock {
> + rockchip,pins =
> + /* lcdc_clk */
> + <3 RK_PA0 1 &pcfg_pull_none>,
> + /* lcdc_den */
> + <3 RK_PC3 1 &pcfg_pull_none>,
> + /* lcdc_hsync */
> + <3 RK_PC1 1 &pcfg_pull_none>,
> + /* lcdc_vsync */
> + <3 RK_PC2 1 &pcfg_pull_none>;
> + };
> +
> + /omit-if-no-ref/
> + lcdc_data16: lcdc-data16 {
> + rockchip,pins =
> + /* lcdc_d3 */
> + <2 RK_PD3 1 &pcfg_pull_none>,
> + /* lcdc_d4 */
> + <2 RK_PD4 1 &pcfg_pull_none>,
> + /* lcdc_d5 */
> + <2 RK_PD5 1 &pcfg_pull_none>,
> + /* lcdc_d6 */
> + <2 RK_PD6 1 &pcfg_pull_none>,
> + /* lcdc_d7 */
> + <2 RK_PD7 1 &pcfg_pull_none>,
> + /* lcdc_d10 */
> + <3 RK_PA3 1 &pcfg_pull_none>,
> + /* lcdc_d11 */
> + <3 RK_PA4 1 &pcfg_pull_none>,
> + /* lcdc_d12 */
> + <3 RK_PA5 1 &pcfg_pull_none>,
> + /* lcdc_d13 */
> + <3 RK_PA6 1 &pcfg_pull_none>,
> + /* lcdc_d14 */
> + <3 RK_PA7 1 &pcfg_pull_none>,
> + /* lcdc_d15 */
> + <3 RK_PB0 1 &pcfg_pull_none>,
> + /* lcdc_d19 */
> + <3 RK_PB4 1 &pcfg_pull_none>,
> + /* lcdc_d20 */
> + <3 RK_PB5 1 &pcfg_pull_none>,
> + /* lcdc_d21 */
> + <3 RK_PB6 1 &pcfg_pull_none>,
> + /* lcdc_d22 */
> + <3 RK_PB7 1 &pcfg_pull_none>,
> + /* lcdc_d23 */
> + <3 RK_PC0 1 &pcfg_pull_none>;
> + };
> +
> + /omit-if-no-ref/
> + lcdc_data18: lcdc-data18 {
> + rockchip,pins =
> + /* lcdc_d2 */
> + <2 RK_PD2 1 &pcfg_pull_none>,
> + /* lcdc_d3 */
> + <2 RK_PD3 1 &pcfg_pull_none>,
> + /* lcdc_d4 */
> + <2 RK_PD4 1 &pcfg_pull_none>,
> + /* lcdc_d5 */
> + <2 RK_PD5 1 &pcfg_pull_none>,
> + /* lcdc_d6 */
> + <2 RK_PD6 1 &pcfg_pull_none>,
> + /* lcdc_d7 */
> + <2 RK_PD7 1 &pcfg_pull_none>,
> + /* lcdc_d10 */
> + <3 RK_PA3 1 &pcfg_pull_none>,
> + /* lcdc_d11 */
> + <3 RK_PA4 1 &pcfg_pull_none>,
> + /* lcdc_d12 */
> + <3 RK_PA5 1 &pcfg_pull_none>,
> + /* lcdc_d13 */
> + <3 RK_PA6 1 &pcfg_pull_none>,
> + /* lcdc_d14 */
> + <3 RK_PA7 1 &pcfg_pull_none>,
> + /* lcdc_d15 */
> + <3 RK_PB0 1 &pcfg_pull_none>,
> + /* lcdc_d18 */
> + <3 RK_PB3 1 &pcfg_pull_none>,
> + /* lcdc_d19 */
> + <3 RK_PB4 1 &pcfg_pull_none>,
> + /* lcdc_d20 */
> + <3 RK_PB5 1 &pcfg_pull_none>,
> + /* lcdc_d21 */
> + <3 RK_PB6 1 &pcfg_pull_none>,
> + /* lcdc_d22 */
> + <3 RK_PB7 1 &pcfg_pull_none>,
> + /* lcdc_d23 */
> + <3 RK_PC0 1 &pcfg_pull_none>;
> + };
> + };
> +
> };