2023-09-16 03:43:10

by Jessica Zhang

[permalink] [raw]
Subject: Re: [RFC PATCH 2/8] drm/panel: nv3052c: Add SPI device IDs



On 9/11/2023 2:02 AM, John Watts wrote:
> SPI drivers needs their own list of compatible device IDs in order
> for automatic module loading to work. Add those for this driver.

Hi John,

Reviewed-by: Jessica Zhang <[email protected]>

Thanks,

Jessica Zhang

>
> Signed-off-by: John Watts <[email protected]>
> ---
> drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> index 589431523ce7..90dea21f9856 100644
> --- a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> +++ b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> @@ -465,6 +465,12 @@ static const struct nv3052c_panel_info ltk035c5444t_panel_info = {
> .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
> };
>
> +static const struct spi_device_id nv3052c_ids[] = {
> + { "ltk035c5444t", },
> + { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(spi, nv3052c_ids);
> +
> static const struct of_device_id nv3052c_of_match[] = {
> { .compatible = "leadtek,ltk035c5444t", .data = &ltk035c5444t_panel_info },
> { /* sentinel */ }
> @@ -476,6 +482,7 @@ static struct spi_driver nv3052c_driver = {
> .name = "nv3052c",
> .of_match_table = nv3052c_of_match,
> },
> + .id_table = nv3052c_ids,
> .probe = nv3052c_probe,
> .remove = nv3052c_remove,
> };
> --
> 2.42.0
>