2021-02-05 15:53:45

by Nicolas Saenz Julienne

[permalink] [raw]
Subject: [RFC/PATCH 09/11] ARM: dts: bcm2711: Enable V3D

This enables V3D for bcm2711 (used in the Raspberry Pi 4).

Signed-off-by: Nicolas Saenz Julienne <[email protected]>
---
arch/arm/boot/dts/bcm2711.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
index 537498a93a3a..dd8376f474db 100644
--- a/arch/arm/boot/dts/bcm2711.dtsi
+++ b/arch/arm/boot/dts/bcm2711.dtsi
@@ -548,6 +548,18 @@ genet_mdio: mdio@e14 {
#size-cells = <0x1>;
};
};
+
+ v3d: gpu@7ec04000 {
+ compatible = "brcm,bcm2711-v3d";
+ reg = <0x0 0x7ec00000 0x4000>,
+ <0x0 0x7ec04000 0x4000>;
+ reg-names = "hub", "core0";
+
+ power-domains = <&pm BCM2835_POWER_DOMAIN_GRAFX_V3D>;
+ resets = <&pm BCM2835_RESET_V3D>;
+ clocks = <&firmware_clocks 5>;
+ interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
+ };
};
};

--
2.30.0


2021-02-06 11:56:11

by Stefan Wahren

[permalink] [raw]
Subject: Re: [RFC/PATCH 09/11] ARM: dts: bcm2711: Enable V3D

Hi,

Am 05.02.21 um 14:52 schrieb Nicolas Saenz Julienne:
> This enables V3D for bcm2711 (used in the Raspberry Pi 4).
>
> Signed-off-by: Nicolas Saenz Julienne <[email protected]>
> ---
> arch/arm/boot/dts/bcm2711.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
> index 537498a93a3a..dd8376f474db 100644
> --- a/arch/arm/boot/dts/bcm2711.dtsi
> +++ b/arch/arm/boot/dts/bcm2711.dtsi
> @@ -548,6 +548,18 @@ genet_mdio: mdio@e14 {
> #size-cells = <0x1>;
> };
> };
> +
> + v3d: gpu@7ec04000 {
just a nit. I prefer the lowest register value here.
> + compatible = "brcm,bcm2711-v3d";
> + reg = <0x0 0x7ec00000 0x4000>,
> + <0x0 0x7ec04000 0x4000>;
> + reg-names = "hub", "core0";
> +
> + power-domains = <&pm BCM2835_POWER_DOMAIN_GRAFX_V3D>;
> + resets = <&pm BCM2835_RESET_V3D>;
> + clocks = <&firmware_clocks 5>;
> + interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
> + };
> };
> };
>