2023-02-08 15:07:00

by Marcel Ziswiler

[permalink] [raw]
Subject: [REGRESSION] rtc: imx-sc: remove .read_alarm

Hi Alexandre

Were you aware that this breaks the sysfs use case? E.g. before we were able to suspend and resume 10 seconds
later as follows:

echo +10 > /sys/class/rtc/rtc1/wakealarm; echo mem > /sys/power/state

Since the removal of .read_alarm in commit 7942121b8ca0 ("rtc: imx-sc: remove .read_alarm") this no longer
seems to work.

This seems like a regression or is this not supposed to work?

Thanks for clarifying.

Cheers

Marcel


2023-02-14 20:01:12

by Alexandre Belloni

[permalink] [raw]
Subject: Re: [REGRESSION] rtc: imx-sc: remove .read_alarm

Hello,

On 08/02/2023 15:06:28+0000, Marcel Ziswiler wrote:
> Hi Alexandre
>
> Were you aware that this breaks the sysfs use case? E.g. before we were able to suspend and resume 10 seconds
> later as follows:
>
> echo +10 > /sys/class/rtc/rtc1/wakealarm; echo mem > /sys/power/state
>
> Since the removal of .read_alarm in commit 7942121b8ca0 ("rtc: imx-sc: remove .read_alarm") this no longer
> seems to work.
>
> This seems like a regression or is this not supposed to work?

This seems like a regression and I think it was reported a while ago and
then again just after you. I believe there is something to do that is
smarter than reverting the patch, I need to check.

Regards

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com