2021-08-28 09:32:42

by Saurav Girepunje

Subject: [PATCH] staging: r8188eu :os_dep: remove condition with no effect

Remove the condition with no effect (if == else) in usb_intf.c
file.

Signed-off-by: Saurav Girepunje <[email protected]>
---
drivers/staging/r8188eu/os_dep/usb_intf.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
index bb85ab77fd26..849563b54727 100644
--- a/drivers/staging/r8188eu/os_dep/usb_intf.c
+++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
@@ -496,10 +496,8 @@ static int rtw_resume(struct usb_interface *pusb_intf)
struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
int ret = 0;

- if (pwrpriv->bInternalAutoSuspend)
- ret = rtw_resume_process(padapter);
- else
- ret = rtw_resume_process(padapter);
+ ret = rtw_resume_process(padapter);
+
return ret;
}

--
2.32.0

2021-08-28 10:20:44

by Michael Straube

Subject: Re: [PATCH] staging: r8188eu :os_dep: remove condition with no effect

On 8/28/21 11:31, Saurav Girepunje wrote:
> Remove the condition with no effect (if == else) in usb_intf.c
> file.
>
> Signed-off-by: Saurav Girepunje <[email protected]>
> ---
> drivers/staging/r8188eu/os_dep/usb_intf.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
> index bb85ab77fd26..849563b54727 100644
> --- a/drivers/staging/r8188eu/os_dep/usb_intf.c
> +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
> @@ -496,10 +496,8 @@ static int rtw_resume(struct usb_interface *pusb_intf)
> struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
> int ret = 0;
>
> - if (pwrpriv->bInternalAutoSuspend)
> - ret =
> - else
> - ret = rtw_resume_process(padapter);
> + ret = rtw_resume_process(padapter);
> +
> return ret;
> }

Thanks for your patch. Perhaps this could be further simplified to:

int ret = rtw_resume_process(padapter);

return ret;

or even:

return rtw_resume_process(padapter);

Best regards,
Michael

2021-08-28 12:47:11

by Saurav Girepunje

Subject: Re: [PATCH] staging: r8188eu :os_dep: remove condition with no effect

On 28 Aug 2021 12:19, Michael Straube wrote:
> On 8/28/21 11:31, Saurav Girepunje wrote:
> > Remove the condition with no effect (if == else) in usb_intf.c
> > file.
> >
> > Signed-off-by: Saurav Girepunje <[email protected]>
> > ---
> > drivers/staging/r8188eu/os_dep/usb_intf.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
> > index bb85ab77fd26..849563b54727 100644
> > --- a/drivers/staging/r8188eu/os_dep/usb_intf.c
> > +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
> > @@ -496,10 +496,8 @@ static int rtw_resume(struct usb_interface *pusb_intf)
> > struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
> > int ret = 0;
> >
> > - if (pwrpriv->bInternalAutoSuspend)
> > - ret = - else
> > - ret = rtw_resume_process(padapter);
> > + ret = rtw_resume_process(padapter);
> > +
> > return ret;
> > }
>
> Thanks for your patch. Perhaps this could be further simplified to:
>
> int ret = rtw_resume_process(padapter);
>
> return ret;
>
> or even:
>
> return rtw_resume_process(padapter);
>
> Best regards,
> Michael


Yes, Thanks Michael. I will make it more simple and send v2.


Regards,
Saurav