2021-06-03 12:29:49

by Colin King

Subject: [PATCH] fsi: core: Fix return of error values on failures

From: Colin Ian King <[email protected]>

Currently the cfam_read and cfam_write functions return the provided
number of bytes given in the count parameter and not the error return
code in variable rc, hence all failures of read/writes are being
silently ignored. Fix this by returning the error code in rc.

Addresses-Coverity: ("Unused value")
Fixes: d1dcd6782576 ("fsi: Add cfam char devices")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/fsi/fsi-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
index 4e60e84cd17a..59ddc9fd5bca 100644
--- a/drivers/fsi/fsi-core.c
+++ b/drivers/fsi/fsi-core.c
@@ -724,7 +724,7 @@ static ssize_t cfam_read(struct file *filep, char __user *buf, size_t count,
rc = count;
fail:
*offset = off;
- return count;
+ return rc;
}

static ssize_t cfam_write(struct file *filep, const char __user *buf,
@@ -761,7 +761,7 @@ static ssize_t cfam_write(struct file *filep, const char __user *buf,
rc = count;
fail:
*offset = off;
- return count;
+ return rc;
}

static loff_t cfam_llseek(struct file *file, loff_t offset, int whence)
--
2.31.1

2021-06-04 01:45:58

by Jeremy Kerr

Subject: Re: [PATCH] fsi: core: Fix return of error values on failures

Hi Colin,
> Currently the cfam_read and cfam_write functions return the provided
> number of bytes given in the count parameter and not the error return
> code in variable rc, hence all failures of read/writes are being
> silently ignored. Fix this by returning the error code in rc.

Looks good to me, thanks for the fix.

Reviewed-by: Jeremy Kerr <[email protected]>

Cheers,


Jeremy