2022-09-21 11:45:20

by HaoTien Hsu

Subject: [PATCH] phy: tegra: xusb: Enable usb role switch attribute

From: Wayne Chang <[email protected]>

This patch enables the usb-role-switch atrribute
to have the user-space check current device role
of otg cability ports

Signed-off-by: Wayne Chang <[email protected]>
Signed-off-by: Haotien Hsu <[email protected]>
---
drivers/phy/tegra/xusb.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index aa5237eacd29..220ab7719ade 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -656,6 +656,7 @@ static int tegra_xusb_setup_usb_role_switch(struct tegra_xusb_port *port)
struct usb_role_switch_desc role_sx_desc = {
.fwnode = dev_fwnode(&port->dev),
.set = tegra_xusb_role_sw_set,
+ .allow_userspace_control = true,
};
int err = 0;

--
2.25.1

2022-09-24 07:25:17

by Vinod Koul

Subject: Re: [PATCH] phy: tegra: xusb: Enable usb role switch attribute

On 21-09-22, 19:25, Haotien Hsu wrote:
> From: Wayne Chang <[email protected]>
>
> This patch enables the usb-role-switch atrribute
> to have the user-space check current device role
> of otg cability ports

typo cability


You can use 72 chars for changelog rather than limiting at 50chars :-(

>
> Signed-off-by: Wayne Chang <[email protected]>
> Signed-off-by: Haotien Hsu <[email protected]>
> ---
> drivers/phy/tegra/xusb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index aa5237eacd29..220ab7719ade 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -656,6 +656,7 @@ static int tegra_xusb_setup_usb_role_switch(struct tegra_xusb_port *port)
> struct usb_role_switch_desc role_sx_desc = {
> .fwnode = dev_fwnode(&port->dev),
> .set = tegra_xusb_role_sw_set,
> + .allow_userspace_control = true,
> };
> int err = 0;
>
> --
> 2.25.1

--
~Vinod

2022-09-26 05:11:47

by HaoTien Hsu

Subject: Re: [PATCH] phy: tegra: xusb: Enable usb role switch attribute

On 9/24/22 15:17, Vinod Koul wrote:
> On 21-09-22, 19:25, Haotien Hsu wrote:
>> From: Wayne Chang <[email protected]>
>>
>> This patch enables the usb-role-switch atrribute
>> to have the user-space check current device role
>> of otg cability ports
>
> typo cability
>
>
> You can use 72 chars for changelog rather than limiting at 50chars :-(
>
Sorry for the typo and bad format.
I will resend this patch.
>>
>> Signed-off-by: Wayne Chang <[email protected]>
>> Signed-off-by: Haotien Hsu <[email protected]>
>> ---
>> drivers/phy/tegra/xusb.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
>> index aa5237eacd29..220ab7719ade 100644
>> --- a/drivers/phy/tegra/xusb.c
>> +++ b/drivers/phy/tegra/xusb.c
>> @@ -656,6 +656,7 @@ static int tegra_xusb_setup_usb_role_switch(struct tegra_xusb_port *port)
>> struct usb_role_switch_desc role_sx_desc = {
>> .fwnode = dev_fwnode(&port->dev),
>> .set = tegra_xusb_role_sw_set,
>> + .allow_userspace_control = true,
>> };
>> int err = 0;
>>
>> --
>> 2.25.1
>