2023-04-21 10:46:47

by Dan Carpenter

Subject: [PATCH] soc: qcom: rmtfs: Fix error code in probe()

Return an error code if of_property_count_u32_elems() fails. Don't
return success.

Fixes: e656cd0bcf3d ("soc: qcom: rmtfs: Optionally map RMTFS to more VMs")
Signed-off-by: Dan Carpenter <[email protected]>
---
drivers/soc/qcom/rmtfs_mem.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/soc/qcom/rmtfs_mem.c b/drivers/soc/qcom/rmtfs_mem.c
index ce48a9f3b4c8..f83811f51175 100644
--- a/drivers/soc/qcom/rmtfs_mem.c
+++ b/drivers/soc/qcom/rmtfs_mem.c
@@ -233,6 +233,7 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev)
num_vmids = 0;
} else if (num_vmids < 0) {
dev_err(&pdev->dev, "failed to count qcom,vmid elements: %d\n", num_vmids);
+ ret = num_vmids;
goto remove_cdev;
} else if (num_vmids > NUM_MAX_VMIDS) {
dev_warn(&pdev->dev,
--
2.39.2

2023-04-21 11:55:42

by Konrad Dybcio

Subject: Re: [PATCH] soc: qcom: rmtfs: Fix error code in probe()

On 21.04.2023 12:44, Dan Carpenter wrote:
> Return an error code if of_property_count_u32_elems() fails. Don't
> return success.
>
> Fixes: e656cd0bcf3d ("soc: qcom: rmtfs: Optionally map RMTFS to more VMs")
> Signed-off-by: Dan Carpenter <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> drivers/soc/qcom/rmtfs_mem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/qcom/rmtfs_mem.c b/drivers/soc/qcom/rmtfs_mem.c
> index ce48a9f3b4c8..f83811f51175 100644
> --- a/drivers/soc/qcom/rmtfs_mem.c
> +++ b/drivers/soc/qcom/rmtfs_mem.c
> @@ -233,6 +233,7 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev)
> num_vmids = 0;
> } else if (num_vmids < 0) {
> dev_err(&pdev->dev, "failed to count qcom,vmid elements: %d\n", num_vmids);
> + ret = num_vmids;
> goto remove_cdev;
> } else if (num_vmids > NUM_MAX_VMIDS) {
> dev_warn(&pdev->dev,

2023-05-25 05:22:22

by Bjorn Andersson

Subject: Re: [PATCH] soc: qcom: rmtfs: Fix error code in probe()

On Fri, 21 Apr 2023 13:44:21 +0300, Dan Carpenter wrote:
> Return an error code if of_property_count_u32_elems() fails. Don't
> return success.
>
>

Applied, thanks!

[1/1] soc: qcom: rmtfs: Fix error code in probe()
commit: 7b374a2fc8665bfb8a0d93b617463cc0732f533a

Best regards,
--
Bjorn Andersson <[email protected]>