2023-03-16 05:43:35

by Yang Li

[permalink] [raw]
Subject: [PATCH -next] i2c: xiic: Use devm_platform_get_and_ioremap_resource()

According to commit 890cc39a8799 ("drivers: provide
devm_platform_get_and_ioremap_resource()"), convert
platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yang Li <[email protected]>
---
drivers/i2c/busses/i2c-xiic.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
index dbb792fc197e..0eea00d10545 100644
--- a/drivers/i2c/busses/i2c-xiic.c
+++ b/drivers/i2c/busses/i2c-xiic.c
@@ -1233,8 +1233,7 @@ static int xiic_i2c_probe(struct platform_device *pdev)
i2c->quirks = data->quirks;
}

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- i2c->base = devm_ioremap_resource(&pdev->dev, res);
+ i2c->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(i2c->base))
return PTR_ERR(i2c->base);

--
2.20.1.7.g153144c



2023-03-21 14:44:26

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH -next] i2c: xiic: Use devm_platform_get_and_ioremap_resource()



On 3/16/23 06:43, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/i2c/busses/i2c-xiic.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index dbb792fc197e..0eea00d10545 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -1233,8 +1233,7 @@ static int xiic_i2c_probe(struct platform_device *pdev)
> i2c->quirks = data->quirks;
> }
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - i2c->base = devm_ioremap_resource(&pdev->dev, res);
> + i2c->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(i2c->base))
> return PTR_ERR(i2c->base);
>
> --
> 2.20.1.7.g153144c
>

Reviewed-by: Michal Simek <[email protected]>

Thanks,
Michal

2023-03-29 19:21:44

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH -next] i2c: xiic: Use devm_platform_get_and_ioremap_resource()

On Thu, Mar 16, 2023 at 01:43:25PM +0800, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <[email protected]>

Applied to for-next, thanks!

Attachments:
(No filename) (425.00 B)
 signature.asc (849.00 B)
 Download all attachments