2020-04-07 15:13:42

by Markus Elfring

[permalink] [raw]
Subject: Re: [RFC] net/mlx5: Fix failing fw tracer allocation on s390

> On s390 FORCE_MAX_ZONEORDER is 9 instead of 11, thus a larger kzalloc()
> allocation as done for the firmware tracer will always fail.

How do you think about to add the tag “Fixes” to the final change description?

Regards,
Markus


2020-04-08 08:16:16

by Niklas Schnelle

[permalink] [raw]
Subject: Re: [RFC] net/mlx5: Fix failing fw tracer allocation on s390


On 4/7/20 5:12 PM, Markus Elfring wrote:
>> On s390 FORCE_MAX_ZONEORDER is 9 instead of 11, thus a larger kzalloc()
>> allocation as done for the firmware tracer will always fail.
>
> How do you think about to add the tag “Fixes” to the final change description?
>
> Regards,
> Markus
>
You're right that makes a lot of sense, thanks! I guess this should reference
the commit that introduced the debug trace, right?

Best regards,
Niklas

2020-04-08 21:37:23

by Saeed Mahameed

[permalink] [raw]
Subject: Re: [RFC] net/mlx5: Fix failing fw tracer allocation on s390

On Wed, 2020-04-08 at 10:06 +0200, Niklas Schnelle wrote:
> On 4/7/20 5:12 PM, Markus Elfring wrote:
> > > On s390 FORCE_MAX_ZONEORDER is 9 instead of 11, thus a larger
> > > kzalloc()
> > > allocation as done for the firmware tracer will always fail.
> >
> > How do you think about to add the tag “Fixes” to the final change
> > description?
> >
> > Regards,
> > Markus
> >
> You're right that makes a lot of sense, thanks! I guess this should
> reference
> the commit that introduced the debug trace, right?
>

probably, just git blame this line:
tracer = kzalloc(sizeof(*tracer), GFP_KERNEL);