2019-05-16 22:36:37

by Madhumitha Prabakaran

Subject: [PATCH v2] Staging: bcm2835-camera: Prefer kernel types

Fix the warning issued by checkpatch
Prefer kernel type 'u32' over 'uint32_t'.
Along with that include a blank line after a declaration
to maintain Linux kernel coding style.

Signed-off-by: Madhumitha Prabakaran <[email protected]>

---
Changes in v2:
- Modified subject line
- Included one more change in control.c
---
drivers/staging/vc04_services/bcm2835-camera/controls.c | 3 ++-
drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c
index 74410fedffad..5ad957e23895 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/controls.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c
@@ -52,7 +52,8 @@ static const s64 ev_bias_qmenu[] = {
static const s64 iso_qmenu[] = {
0, 100000, 200000, 400000, 800000,
};
-static const uint32_t iso_values[] = {
+
+static const u32 iso_values[] = {
0, 100, 200, 400, 800,
};

diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h b/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h
index d1c57edbe2b8..90793c9f9a0f 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h
+++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h
@@ -309,7 +309,7 @@ struct mmal_msg_port_parameter_set {
u32 port_handle; /* port */
u32 id; /* Parameter ID */
u32 size; /* Parameter size */
- uint32_t value[MMAL_WORKER_PORT_PARAMETER_SPACE];
+ u32 value[MMAL_WORKER_PORT_PARAMETER_SPACE];
};

struct mmal_msg_port_parameter_set_reply {
@@ -331,7 +331,7 @@ struct mmal_msg_port_parameter_get_reply {
u32 status; /* Status of mmal_port_parameter_get call */
u32 id; /* Parameter ID */
u32 size; /* Parameter size */
- uint32_t value[MMAL_WORKER_PORT_PARAMETER_SPACE];
+ u32 value[MMAL_WORKER_PORT_PARAMETER_SPACE];
};

/* event messages */
--
2.17.1

2019-05-17 09:08:12

by Stefan Wahren

Subject: Re: [PATCH v2] Staging: bcm2835-camera: Prefer kernel types

Am 16.05.2019 um 23:33 schrieb Madhumitha Prabakaran:
> Fix the warning issued by checkpatch
> Prefer kernel type 'u32' over 'uint32_t'.
> Along with that include a blank line after a declaration
> to maintain Linux kernel coding style.
>
> Signed-off-by: Madhumitha Prabakaran <[email protected]>

Acked-by: Stefan Wahren <[email protected]>