2021-09-27 12:57:45

by Masahiro Yamada

Subject: [PATCH 2/2] kconfig: rename a variable in the lexer to a clearer name

In Kconfig, like Python, you can enclose a string by double-quotes or
single-quotes. So, both "foo" and 'foo' are allowed.

The variable, "str", is used to remember whether the string started with
a double-quote or a single-quote.

Rename it to a clearer name. The type should be 'char'.

Signed-off-by: Masahiro Yamada <[email protected]>
---

scripts/kconfig/lexer.l | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/kconfig/lexer.l b/scripts/kconfig/lexer.l
index efe487859308..cc386e443683 100644
--- a/scripts/kconfig/lexer.l
+++ b/scripts/kconfig/lexer.l
@@ -84,7 +84,7 @@ static void warn_ignored_character(char chr)
n [A-Za-z0-9_-]

%%
- int str = 0;
+ char open_quote = 0;

#.* /* ignore comment */
[ \t]* /* whitespaces */
@@ -133,7 +133,7 @@ n [A-Za-z0-9_-]
":=" return T_COLON_EQUAL;
"+=" return T_PLUS_EQUAL;
\"|\' {
- str = yytext[0];
+ open_quote = yytext[0];
new_string();
BEGIN(STRING);
}
@@ -170,7 +170,7 @@ n [A-Za-z0-9_-]
append_string(yytext + 1, yyleng - 1);
}
\'|\" {
- if (str == yytext[0]) {
+ if (open_quote == yytext[0]) {
BEGIN(INITIAL);
yylval.string = text;
return T_WORD_QUOTE;
--
2.30.2

2021-09-29 17:15:42

by Boris Kolpackov

Subject: Re: [PATCH 2/2] kconfig: rename a variable in the lexer to a clearer name

Masahiro Yamada <[email protected]> writes:

> In Kconfig, like Python, you can enclose a string by double-quotes or
> single-quotes. So, both "foo" and 'foo' are allowed.
>
> The variable, "str", is used to remember whether the string started with
> a double-quote or a single-quote.
>
> Rename it to a clearer name. The type should be 'char'.

LGTM.

Reviewed-by: Boris Kolpackov <[email protected]>