2022-05-03 00:59:29

by Geert Uytterhoeven

Subject: [PATCH 1/2] serial: 8250: core: Remove unneeded <linux/pm_runtime.h>

The last calls into Runtime PM were moved to 8250_port.c a long time
ago.

Fixes: b6830f6df8914faa ("serial: 8250: Split base port operations from universal driver")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/tty/serial/8250/8250_core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index 01d30f6ed8fb5931..cfbd2de0ca6e4bcd 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -32,7 +32,6 @@
#include <linux/mutex.h>
#include <linux/slab.h>
#include <linux/uaccess.h>
-#include <linux/pm_runtime.h>
#include <linux/io.h>
#ifdef CONFIG_SPARC
#include <linux/sunserialcore.h>
--
2.25.1

2022-05-03 14:26:12

by Andy Shevchenko

Subject: Re: [PATCH 1/2] serial: 8250: core: Remove unneeded <linux/pm_runtime.h>

On Mon, May 02, 2022 at 02:37:05PM +0200, Geert Uytterhoeven wrote:
> The last calls into Runtime PM were moved to 8250_port.c a long time
> ago.

Both
Reviewed-by: Andy Shevchenko <[email protected]>

> Fixes: b6830f6df8914faa ("serial: 8250: Split base port operations from universal driver")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/tty/serial/8250/8250_core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index 01d30f6ed8fb5931..cfbd2de0ca6e4bcd 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -32,7 +32,6 @@
> #include <linux/mutex.h>
> #include <linux/slab.h>
> #include <linux/uaccess.h>
> -#include <linux/pm_runtime.h>
> #include <linux/io.h>
> #ifdef CONFIG_SPARC
> #include <linux/sunserialcore.h>
> --
> 2.25.1
>

--
With Best Regards,
Andy Shevchenko

2022-05-03 17:15:33

by Ilpo Järvinen

Subject: Re: [PATCH 1/2] serial: 8250: core: Remove unneeded <linux/pm_runtime.h>

On Mon, 2 May 2022, Geert Uytterhoeven wrote:

> The last calls into Runtime PM were moved to 8250_port.c a long time
> ago.
>
> Fixes: b6830f6df8914faa ("serial: 8250: Split base port operations from universal driver")

Does this really "fix" something or is it just a useful cleanup? To me it
looks the latter.

--
i.

> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/tty/serial/8250/8250_core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index 01d30f6ed8fb5931..cfbd2de0ca6e4bcd 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -32,7 +32,6 @@
> #include <linux/mutex.h>
> #include <linux/slab.h>
> #include <linux/uaccess.h>
> -#include <linux/pm_runtime.h>
> #include <linux/io.h>
> #ifdef CONFIG_SPARC
> #include <linux/sunserialcore.h>
>