*-objs suffix is reserved rather for (user-space) host programs while
usually *-y suffix is used for kernel drivers (although *-objs works
for that purpose for now).
Let's correct the old usages of *-objs in Makefiles.
Signed-off-by: Andy Shevchenko <[email protected]>
---
Reported by Olek. As I said him this is correct change which is
documented in Documentation/kbuild/makefiles.rst "Composite Host
Programs" (mind the meaning of the word "host"!).
lib/dim/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dim/Makefile b/lib/dim/Makefile
index c4cc4026c451..5b9bfaac7ac1 100644
--- a/lib/dim/Makefile
+++ b/lib/dim/Makefile
@@ -4,4 +4,4 @@
obj-$(CONFIG_DIMLIB) += dimlib.o
-dimlib-objs := dim.o net_dim.o rdma_dim.o
+dimlib-y := dim.o net_dim.o rdma_dim.o
--
2.43.0.rc1.1336.g36b5255a03ac
From: Andy Shevchenko <[email protected]>
Date: Wed, 8 May 2024 17:29:42 +0300
> *-objs suffix is reserved rather for (user-space) host programs while
> usually *-y suffix is used for kernel drivers (although *-objs works
> for that purpose for now).
>
> Let's correct the old usages of *-objs in Makefiles.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
Reviewed-by: Alexander Lobakin <[email protected]>
> ---
>
> Reported by Olek. As I said him this is correct change which is
> documented in Documentation/kbuild/makefiles.rst "Composite Host
> Programs" (mind the meaning of the word "host"!).
>
> lib/dim/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/dim/Makefile b/lib/dim/Makefile
> index c4cc4026c451..5b9bfaac7ac1 100644
> --- a/lib/dim/Makefile
> +++ b/lib/dim/Makefile
> @@ -4,4 +4,4 @@
>
> obj-$(CONFIG_DIMLIB) += dimlib.o
>
> -dimlib-objs := dim.o net_dim.o rdma_dim.o
> +dimlib-y := dim.o net_dim.o rdma_dim.o
Thanks,
Olek
On 5/8/24 07:29, Andy Shevchenko wrote:
> *-objs suffix is reserved rather for (user-space) host programs while
> usually *-y suffix is used for kernel drivers (although *-objs works
> for that purpose for now).
>
> Let's correct the old usages of *-objs in Makefiles.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
Acked-by: Florian Fainelli <[email protected]>
> ---
>
> Reported by Olek. As I said him this is correct change which is
> documented in Documentation/kbuild/makefiles.rst "Composite Host
> Programs" (mind the meaning of the word "host"!).
Why not credit him with an official Reported-by?
>
> lib/dim/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/dim/Makefile b/lib/dim/Makefile
> index c4cc4026c451..5b9bfaac7ac1 100644
> --- a/lib/dim/Makefile
> +++ b/lib/dim/Makefile
> @@ -4,4 +4,4 @@
>
> obj-$(CONFIG_DIMLIB) += dimlib.o
>
> -dimlib-objs := dim.o net_dim.o rdma_dim.o
> +dimlib-y := dim.o net_dim.o rdma_dim.o
--
Florian
On Wed, May 08, 2024 at 10:39:55AM -0700, Florian Fainelli wrote:
> On 5/8/24 07:29, Andy Shevchenko wrote:
> > *-objs suffix is reserved rather for (user-space) host programs while
> > usually *-y suffix is used for kernel drivers (although *-objs works
> > for that purpose for now).
> >
> > Let's correct the old usages of *-objs in Makefiles.
> >
> > Signed-off-by: Andy Shevchenko <[email protected]>
>
> Acked-by: Florian Fainelli <[email protected]>
>
> > ---
> >
> > Reported by Olek. As I said him this is correct change which is
> > documented in Documentation/kbuild/makefiles.rst "Composite Host
> > Programs" (mind the meaning of the word "host"!).
>
> Why not credit him with an official Reported-by?
No problem
Reported-by: Alexander Lobakin <[email protected]>
--
With Best Regards,
Andy Shevchenko