2017-11-22 05:46:33

by Timur Tabi

[permalink] [raw]
Subject: Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function

On 11/21/17 11:31 PM, Sinan Kaya wrote:
> Use pci_get_domain_bus_and_slot() with a domain number of 0 where we can't
> extract the domain number. Other places, use the actual domain number from
> the device.
>
> Now that all users of pci_get_bus_and_slot() switched to
> pci_get_domain_bus_and_slot(), it is now safe to remove this function.

This doesn't really eliminate pci_get_bus_and_slot(), because it doesn't
force developers to support non-zero domains. What's to stop a driver
developer from doing this?

#define pci_get_bus_and_slot(b, d) pci_get_domain_bus_and_slot(0, b, d)

thereby completely ignoring what you're trying to do?

--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

From 1584743149582609571@xxx Wed Nov 22 05:33:59 +0000 2017
X-GM-THRID: 1584743149582609571
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread