2023-11-23 16:42:10

by Paolo Abeni

[permalink] [raw]
Subject: Re: [PATCH] mptcp: fix uninit-value in mptcp_incoming_options

On Thu, 2023-11-23 at 09:23 +0800, Edward Adam Davis wrote:
> Added initialization use_ack to mptcp_parse_option().
>
> Reported-by: [email protected]
> Signed-off-by: Edward Adam Davis <[email protected]>
> ---
> net/mptcp/options.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/mptcp/options.c b/net/mptcp/options.c
> index cd15ec73073e..c53914012d01 100644
> --- a/net/mptcp/options.c
> +++ b/net/mptcp/options.c
> @@ -108,6 +108,7 @@ static void mptcp_parse_option(const struct sk_buff *skb,
> mp_opt->suboptions |= OPTION_MPTCP_DSS;
> mp_opt->use_map = 1;
> mp_opt->mpc_map = 1;
> + mp_opt->use_ack = 0;
> mp_opt->data_len = get_unaligned_be16(ptr);
> ptr += 2;
> }

LGTM, and syzbot tested it.

Acked-by: Paolo Abeni <[email protected]>

@Edward: for future similar patches, please add also the tested tag
from syzbot, will make tracking easier.

Thanks!

Paolo