2023-05-01 00:17:05

by Greg KH

[permalink] [raw]
Subject: Linux 6.3.1

I'm announcing the release of the 6.3.1 kernel.

All users of the 6.3 kernel series must upgrade.

The updated 6.3.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.3.y
and can be browsed at the normal kernel.org git web browser:
https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary

thanks,

greg k-h

------------

Makefile | 2 -
drivers/base/dd.c | 7 ++++
drivers/gpio/gpiolib-acpi.c | 13 +++++++++
drivers/gpu/drm/drm_fb_helper.c | 3 ++
drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 9 +++++-
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 5 +++
drivers/usb/serial/option.c | 6 ++++
fs/btrfs/send.c | 2 -
fs/btrfs/volumes.c | 2 -
fs/verity/enable.c | 17 ++++++++++++
include/linux/mmc/sdio_ids.h | 5 ++-
mm/mmap.c | 2 -
net/bluetooth/hci_sock.c | 9 +++++-
13 files changed, 74 insertions(+), 8 deletions(-)

Arınç ÜNAL (1):
USB: serial: option: add UNISOC vendor and TOZED LT70C product

Daniel Vetter (1):
drm/fb-helper: set x/yres_virtual in drm_fb_helper_check_var

Eric Biggers (2):
fsverity: reject FS_IOC_ENABLE_VERITY on mode 3 fds
fsverity: explicitly check for buffer overflow in build_merkle_tree()

Genjian Zhang (1):
btrfs: fix uninitialized variable warnings

Greg Kroah-Hartman (1):
Linux 6.3.1

Jisoo Jang (1):
wifi: brcmfmac: slab-out-of-bounds read in brcmf_get_assoc_ies()

Marek Vasut (1):
wifi: brcmfmac: add Cypress 43439 SDIO ids

Ruihan Li (1):
bluetooth: Perform careful capability checks in hci_sock_ioctl()

Stephen Boyd (1):
driver core: Don't require dynamic_debug for initcall_debug probe timing

Vlastimil Babka (1):
mm/mremap: fix vm_pgoff in vma_merge() case 3

Werner Sembach (1):
gpiolib: acpi: Add a ignore wakeup quirk for Clevo NL5xNU


2023-05-01 06:31:52

by Chris Clayton

[permalink] [raw]
Subject: Re: Linux 6.3.1

Sorry, should have more coffee before upgrading kernels...

This FTBFS is actually on 6.1.27. I'll concentrate hard and send a reply to the correct announcement email.

Once again. sorry for the noise.

Chris

On 01/05/2023 07:22, Chris Clayton wrote:
> Hi Greg
>
> On 01/05/2023 00:55, Greg Kroah-Hartman wrote:
>> I'm announcing the release of the 6.3.1 kernel.
>>
>> All users of the 6.3 kernel series must upgrade.
>>
>> The updated 6.3.y git tree can be found at:
>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.3.y
>> and can be browsed at the normal kernel.org git web browser:
>> https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary
>>
>> thanks,
>>
>> greg k-h
>>
>> ------------
>>
>> Makefile | 2 -
>> drivers/base/dd.c | 7 ++++
>> drivers/gpio/gpiolib-acpi.c | 13 +++++++++
>> drivers/gpu/drm/drm_fb_helper.c | 3 ++
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 9 +++++-
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 5 +++
>> drivers/usb/serial/option.c | 6 ++++
>> fs/btrfs/send.c | 2 -
>> fs/btrfs/volumes.c | 2 -
>> fs/verity/enable.c | 17 ++++++++++++
>> include/linux/mmc/sdio_ids.h | 5 ++-
>> mm/mmap.c | 2 -
>> net/bluetooth/hci_sock.c | 9 +++++-
>> 13 files changed, 74 insertions(+), 8 deletions(-)
>>
>> Arınç ÜNAL (1):
>> USB: serial: option: add UNISOC vendor and TOZED LT70C product
>>
>> Daniel Vetter (1):
>> drm/fb-helper: set x/yres_virtual in drm_fb_helper_check_var
>>
>> Eric Biggers (2):
>> fsverity: reject FS_IOC_ENABLE_VERITY on mode 3 fds
>> fsverity: explicitly check for buffer overflow in build_merkle_tree()
>>
>> Genjian Zhang (1):
>> btrfs: fix uninitialized variable warnings
>>
>> Greg Kroah-Hartman (1):
>> Linux 6.3.1
>>
>> Jisoo Jang (1):
>> wifi: brcmfmac: slab-out-of-bounds read in brcmf_get_assoc_ies()
>>
>> Marek Vasut (1):
>> wifi: brcmfmac: add Cypress 43439 SDIO ids
>>
>> Ruihan Li (1):
>> bluetooth: Perform careful capability checks in hci_sock_ioctl()
>>
>> Stephen Boyd (1):
>> driver core: Don't require dynamic_debug for initcall_debug probe timing
>>
>> Vlastimil Babka (1):
>> mm/mremap: fix vm_pgoff in vma_merge() case 3
>>
>> Werner Sembach (1):
>> gpiolib: acpi: Add a ignore wakeup quirk for Clevo NL5xNU
>>
>>
>>
>
> 6.3.1 FTBFS thusly:
>
> drivers/net/wireguard/timers.c: In function 'wg_expired_retransmit_handshake':
> <command-line>: error: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'
> [-Werror=format=]
> <command-line>: note: in expansion of macro 'KBUILD_MODNAME'
> ./include/linux/dynamic_debug.h:223:29: note: in expansion of macro 'pr_fmt'
> 223 | func(&id, ##__VA_ARGS__); \
> | ^~~~~~~~~~~
> ./include/linux/dynamic_debug.h:247:9: note: in expansion of macro '__dynamic_func_call_cls'
> 247 | __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~~~~~~~~
> ./include/linux/dynamic_debug.h:249:9: note: in expansion of macro '_dynamic_func_call_cls'
> 249 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~~~~~~~
> ./include/linux/dynamic_debug.h:268:9: note: in expansion of macro '_dynamic_func_call'
> 268 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
> | ^~~~~~~~~~~~~~~~~~
> ./include/linux/printk.h:581:9: note: in expansion of macro 'dynamic_pr_debug'
> 581 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~
> drivers/net/wireguard/timers.c:47:17: note: in expansion of macro 'pr_debug'
> 47 | pr_debug("%s: Handshake for peer %llu (%pISpfsc) did not complete after %d attempts, giving up\n",
> | ^~~~~~~~
> <command-line>: error: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'
> [-Werror=format=]
> <command-line>: note: in expansion of macro 'KBUILD_MODNAME'
> ./include/linux/dynamic_debug.h:223:29: note: in expansion of macro 'pr_fmt'
> 223 | func(&id, ##__VA_ARGS__); \
> | ^~~~~~~~~~~
> ./include/linux/dynamic_debug.h:247:9: note: in expansion of macro '__dynamic_func_call_cls'
> 247 | __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~~~~~~~~
> ./include/linux/dynamic_debug.h:249:9: note: in expansion of macro '_dynamic_func_call_cls'
> 249 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~~~~~~~
> ./include/linux/dynamic_debug.h:268:9: note: in expansion of macro '_dynamic_func_call'
> 268 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
> | ^~~~~~~~~~~~~~~~~~
> ./include/linux/printk.h:581:9: note: in expansion of macro 'dynamic_pr_debug'
> 581 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~
> drivers/net/wireguard/timers.c:65:17: note: in expansion of macro 'pr_debug'
> 65 | pr_debug("%s: Handshake for peer %llu (%pISpfsc) did not complete after %d seconds, retrying
> (try %d)\n",
> | ^~~~~~~~
> drivers/net/wireguard/timers.c: In function 'wg_expired_new_handshake':
> <command-line>: error: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'
> [-Werror=format=]
> <command-line>: note: in expansion of macro 'KBUILD_MODNAME'
> ./include/linux/dynamic_debug.h:223:29: note: in expansion of macro 'pr_fmt'
> 223 | func(&id, ##__VA_ARGS__); \
> | ^~~~~~~~~~~
> ./include/linux/dynamic_debug.h:247:9: note: in expansion of macro '__dynamic_func_call_cls'
> 247 | __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~~~~~~~~
> ./include/linux/dynamic_debug.h:249:9: note: in expansion of macro '_dynamic_func_call_cls'
> 249 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~~~~~~~
> ./include/linux/dynamic_debug.h:268:9: note: in expansion of macro '_dynamic_func_call'
> 268 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
> | ^~~~~~~~~~~~~~~~~~
> ./include/linux/printk.h:581:9: note: in expansion of macro 'dynamic_pr_debug'
> 581 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~
> drivers/net/wireguard/timers.c:95:9: note: in expansion of macro 'pr_debug'
> 95 | pr_debug("%s: Retrying handshake with peer %llu (%pISpfsc) because we stopped hearing back after %d
> seconds\n",
> | ^~~~~~~~
> drivers/net/wireguard/timers.c: In function 'wg_queued_expired_zero_key_material':
> <command-line>: error: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'
> [-Werror=format=]
> <command-line>: note: in expansion of macro 'KBUILD_MODNAME'
> ./include/linux/dynamic_debug.h:223:29: note: in expansion of macro 'pr_fmt'
> 223 | func(&id, ##__VA_ARGS__); \
> | ^~~~~~~~~~~
> ./include/linux/dynamic_debug.h:247:9: note: in expansion of macro '__dynamic_func_call_cls'
> 247 | __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~~~~~~~~
> ./include/linux/dynamic_debug.h:249:9: note: in expansion of macro '_dynamic_func_call_cls'
> 249 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~~~~~~~
> ./include/linux/dynamic_debug.h:268:9: note: in expansion of macro '_dynamic_func_call'
> 268 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
> | ^~~~~~~~~~~~~~~~~~
> ./include/linux/printk.h:581:9: note: in expansion of macro 'dynamic_pr_debug'
> 581 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~
> drivers/net/wireguard/timers.c:127:9: note: in expansion of macro 'pr_debug'
> 127 | pr_debug("%s: Zeroing out all keys for peer %llu (%pISpfsc), since we haven't received a new one in %d
> seconds\n",
> | ^~~~~~~~
>
>
> There's a patch to drivers/net/wireguard/timers.c that fixes these errors and you can find it at
> 2d4ee16d969c97996e80e4c9cb6de0acaff22c9f in Linus' tree.
>
> I don't kow if it's necessary. but guess I can say:
>
> Tested-by: Chris Clayton <[email protected]>

2023-05-01 06:40:39

by Chris Clayton

[permalink] [raw]
Subject: Re: Linux 6.3.1

Hi Greg

On 01/05/2023 00:55, Greg Kroah-Hartman wrote:
> I'm announcing the release of the 6.3.1 kernel.
>
> All users of the 6.3 kernel series must upgrade.
>
> The updated 6.3.y git tree can be found at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.3.y
> and can be browsed at the normal kernel.org git web browser:
> https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary
>
> thanks,
>
> greg k-h
>
> ------------
>
> Makefile | 2 -
> drivers/base/dd.c | 7 ++++
> drivers/gpio/gpiolib-acpi.c | 13 +++++++++
> drivers/gpu/drm/drm_fb_helper.c | 3 ++
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 9 +++++-
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 5 +++
> drivers/usb/serial/option.c | 6 ++++
> fs/btrfs/send.c | 2 -
> fs/btrfs/volumes.c | 2 -
> fs/verity/enable.c | 17 ++++++++++++
> include/linux/mmc/sdio_ids.h | 5 ++-
> mm/mmap.c | 2 -
> net/bluetooth/hci_sock.c | 9 +++++-
> 13 files changed, 74 insertions(+), 8 deletions(-)
>
> Arınç ÜNAL (1):
> USB: serial: option: add UNISOC vendor and TOZED LT70C product
>
> Daniel Vetter (1):
> drm/fb-helper: set x/yres_virtual in drm_fb_helper_check_var
>
> Eric Biggers (2):
> fsverity: reject FS_IOC_ENABLE_VERITY on mode 3 fds
> fsverity: explicitly check for buffer overflow in build_merkle_tree()
>
> Genjian Zhang (1):
> btrfs: fix uninitialized variable warnings
>
> Greg Kroah-Hartman (1):
> Linux 6.3.1
>
> Jisoo Jang (1):
> wifi: brcmfmac: slab-out-of-bounds read in brcmf_get_assoc_ies()
>
> Marek Vasut (1):
> wifi: brcmfmac: add Cypress 43439 SDIO ids
>
> Ruihan Li (1):
> bluetooth: Perform careful capability checks in hci_sock_ioctl()
>
> Stephen Boyd (1):
> driver core: Don't require dynamic_debug for initcall_debug probe timing
>
> Vlastimil Babka (1):
> mm/mremap: fix vm_pgoff in vma_merge() case 3
>
> Werner Sembach (1):
> gpiolib: acpi: Add a ignore wakeup quirk for Clevo NL5xNU
>
>
>

6.3.1 FTBFS thusly:

drivers/net/wireguard/timers.c: In function 'wg_expired_retransmit_handshake':
<command-line>: error: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'
[-Werror=format=]
<command-line>: note: in expansion of macro 'KBUILD_MODNAME'
./include/linux/dynamic_debug.h:223:29: note: in expansion of macro 'pr_fmt'
223 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
./include/linux/dynamic_debug.h:247:9: note: in expansion of macro '__dynamic_func_call_cls'
247 | __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~~
./include/linux/dynamic_debug.h:249:9: note: in expansion of macro '_dynamic_func_call_cls'
249 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~
./include/linux/dynamic_debug.h:268:9: note: in expansion of macro '_dynamic_func_call'
268 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
| ^~~~~~~~~~~~~~~~~~
./include/linux/printk.h:581:9: note: in expansion of macro 'dynamic_pr_debug'
581 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~
drivers/net/wireguard/timers.c:47:17: note: in expansion of macro 'pr_debug'
47 | pr_debug("%s: Handshake for peer %llu (%pISpfsc) did not complete after %d attempts, giving up\n",
| ^~~~~~~~
<command-line>: error: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'
[-Werror=format=]
<command-line>: note: in expansion of macro 'KBUILD_MODNAME'
./include/linux/dynamic_debug.h:223:29: note: in expansion of macro 'pr_fmt'
223 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
./include/linux/dynamic_debug.h:247:9: note: in expansion of macro '__dynamic_func_call_cls'
247 | __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~~
./include/linux/dynamic_debug.h:249:9: note: in expansion of macro '_dynamic_func_call_cls'
249 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~
./include/linux/dynamic_debug.h:268:9: note: in expansion of macro '_dynamic_func_call'
268 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
| ^~~~~~~~~~~~~~~~~~
./include/linux/printk.h:581:9: note: in expansion of macro 'dynamic_pr_debug'
581 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~
drivers/net/wireguard/timers.c:65:17: note: in expansion of macro 'pr_debug'
65 | pr_debug("%s: Handshake for peer %llu (%pISpfsc) did not complete after %d seconds, retrying
(try %d)\n",
| ^~~~~~~~
drivers/net/wireguard/timers.c: In function 'wg_expired_new_handshake':
<command-line>: error: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'
[-Werror=format=]
<command-line>: note: in expansion of macro 'KBUILD_MODNAME'
./include/linux/dynamic_debug.h:223:29: note: in expansion of macro 'pr_fmt'
223 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
./include/linux/dynamic_debug.h:247:9: note: in expansion of macro '__dynamic_func_call_cls'
247 | __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~~
./include/linux/dynamic_debug.h:249:9: note: in expansion of macro '_dynamic_func_call_cls'
249 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~
./include/linux/dynamic_debug.h:268:9: note: in expansion of macro '_dynamic_func_call'
268 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
| ^~~~~~~~~~~~~~~~~~
./include/linux/printk.h:581:9: note: in expansion of macro 'dynamic_pr_debug'
581 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~
drivers/net/wireguard/timers.c:95:9: note: in expansion of macro 'pr_debug'
95 | pr_debug("%s: Retrying handshake with peer %llu (%pISpfsc) because we stopped hearing back after %d
seconds\n",
| ^~~~~~~~
drivers/net/wireguard/timers.c: In function 'wg_queued_expired_zero_key_material':
<command-line>: error: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'
[-Werror=format=]
<command-line>: note: in expansion of macro 'KBUILD_MODNAME'
./include/linux/dynamic_debug.h:223:29: note: in expansion of macro 'pr_fmt'
223 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
./include/linux/dynamic_debug.h:247:9: note: in expansion of macro '__dynamic_func_call_cls'
247 | __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~~
./include/linux/dynamic_debug.h:249:9: note: in expansion of macro '_dynamic_func_call_cls'
249 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~
./include/linux/dynamic_debug.h:268:9: note: in expansion of macro '_dynamic_func_call'
268 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
| ^~~~~~~~~~~~~~~~~~
./include/linux/printk.h:581:9: note: in expansion of macro 'dynamic_pr_debug'
581 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~
drivers/net/wireguard/timers.c:127:9: note: in expansion of macro 'pr_debug'
127 | pr_debug("%s: Zeroing out all keys for peer %llu (%pISpfsc), since we haven't received a new one in %d
seconds\n",
| ^~~~~~~~


There's a patch to drivers/net/wireguard/timers.c that fixes these errors and you can find it at
2d4ee16d969c97996e80e4c9cb6de0acaff22c9f in Linus' tree.

I don't kow if it's necessary. but guess I can say:

Tested-by: Chris Clayton <[email protected]>

2023-05-01 13:12:23

by Ronald Warsow

[permalink] [raw]

2023-05-01 21:44:44

by Greg KH

[permalink] [raw]
Subject: Re: Linux 6.3.1

On Mon, May 01, 2023 at 07:22:56AM +0100, Chris Clayton wrote:
> 6.3.1 FTBFS thusly:

What is "FTBFS"?

> drivers/net/wireguard/timers.c: In function 'wg_expired_retransmit_handshake':
> <command-line>: error: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'
> [-Werror=format=]
> <command-line>: note: in expansion of macro 'KBUILD_MODNAME'
> ./include/linux/dynamic_debug.h:223:29: note: in expansion of macro 'pr_fmt'
> 223 | func(&id, ##__VA_ARGS__); \
> | ^~~~~~~~~~~

<snip>

> There's a patch to drivers/net/wireguard/timers.c that fixes these errors and you can find it at
> 2d4ee16d969c97996e80e4c9cb6de0acaff22c9f in Linus' tree.

Thanks for this report, we'll queue it up soon.

thanks,

greg k-h

2023-05-01 22:45:31

by Akemi Yagi

[permalink] [raw]
Subject: Re: Linux 6.3.1

On Tue, 02 May 2023 06:40:03 +0900, Greg Kroah-Hartman wrote:

> On Mon, May 01, 2023 at 07:22:56AM +0100, Chris Clayton wrote:
>> 6.3.1 FTBFS thusly:
>
> What is "FTBFS"?

"fails to build from source".

Akemi

2023-05-01 23:59:06

by Greg KH

[permalink] [raw]
Subject: Re: Linux 6.3.1

On Tue, May 02, 2023 at 06:40:03AM +0900, Greg Kroah-Hartman wrote:
> On Mon, May 01, 2023 at 07:22:56AM +0100, Chris Clayton wrote:
> > 6.3.1 FTBFS thusly:
>
> What is "FTBFS"?
>
> > drivers/net/wireguard/timers.c: In function 'wg_expired_retransmit_handshake':
> > <command-line>: error: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'
> > [-Werror=format=]
> > <command-line>: note: in expansion of macro 'KBUILD_MODNAME'
> > ./include/linux/dynamic_debug.h:223:29: note: in expansion of macro 'pr_fmt'
> > 223 | func(&id, ##__VA_ARGS__); \
> > | ^~~~~~~~~~~
>
> <snip>
>
> > There's a patch to drivers/net/wireguard/timers.c that fixes these errors and you can find it at
> > 2d4ee16d969c97996e80e4c9cb6de0acaff22c9f in Linus' tree.
>
> Thanks for this report, we'll queue it up soon.

Odd, that commit is in 6.2 already, so how are you applying this to
6.3.y?

Confused,

greg k-h

2023-05-02 05:35:19

by Chris Clayton

[permalink] [raw]
Subject: Re: Linux 6.3.1



On 02/05/2023 00:43, Greg Kroah-Hartman wrote:
> On Tue, May 02, 2023 at 06:40:03AM +0900, Greg Kroah-Hartman wrote:
>> On Mon, May 01, 2023 at 07:22:56AM +0100, Chris Clayton wrote:
>>> 6.3.1 FTBFS thusly:
>>
>> What is "FTBFS"?
>>

Fails to build from source

>>> drivers/net/wireguard/timers.c: In function 'wg_expired_retransmit_handshake':
>>> <command-line>: error: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'
>>> [-Werror=format=]
>>> <command-line>: note: in expansion of macro 'KBUILD_MODNAME'
>>> ./include/linux/dynamic_debug.h:223:29: note: in expansion of macro 'pr_fmt'
>>> 223 | func(&id, ##__VA_ARGS__); \
>>> | ^~~~~~~~~~~
>>
>> <snip>
>>
>>> There's a patch to drivers/net/wireguard/timers.c that fixes these errors and you can find it at
>>> 2d4ee16d969c97996e80e4c9cb6de0acaff22c9f in Linus' tree.
>>
>> Thanks for this report, we'll queue it up soon.
>
> Odd, that commit is in 6.2 already, so how are you applying this to
> 6.3.y?
>
> Confused,
>
> greg k-h

2023-05-02 07:42:01

by Greg KH

[permalink] [raw]
Subject: Re: Linux 6.3.1

On Tue, May 02, 2023 at 08:43:47AM +0900, Greg Kroah-Hartman wrote:
> On Tue, May 02, 2023 at 06:40:03AM +0900, Greg Kroah-Hartman wrote:
> > On Mon, May 01, 2023 at 07:22:56AM +0100, Chris Clayton wrote:
> > > 6.3.1 FTBFS thusly:
> >
> > What is "FTBFS"?
> >
> > > drivers/net/wireguard/timers.c: In function 'wg_expired_retransmit_handshake':
> > > <command-line>: error: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'
> > > [-Werror=format=]
> > > <command-line>: note: in expansion of macro 'KBUILD_MODNAME'
> > > ./include/linux/dynamic_debug.h:223:29: note: in expansion of macro 'pr_fmt'
> > > 223 | func(&id, ##__VA_ARGS__); \
> > > | ^~~~~~~~~~~
> >
> > <snip>
> >
> > > There's a patch to drivers/net/wireguard/timers.c that fixes these errors and you can find it at
> > > 2d4ee16d969c97996e80e4c9cb6de0acaff22c9f in Linus' tree.
> >
> > Thanks for this report, we'll queue it up soon.
>
> Odd, that commit is in 6.2 already, so how are you applying this to
> 6.3.y?

And this is only a gcc13 issue, right? So it's not a regression, it's
always been there, nothing new caused it in this release from what I can
tell.

Actually I don't see how this is an issue in 6.3.1 anyway, as again, the
proposed fix you gave is in 6.2, so what really is happening here?

confused,

greg k-h

2023-05-02 13:21:38

by Chris Clayton

[permalink] [raw]
Subject: Re: Linux 6.3.1

Hi Greg

On 02/05/2023 08:31, Greg Kroah-Hartman wrote:
> On Tue, May 02, 2023 at 08:43:47AM +0900, Greg Kroah-Hartman wrote:
>> On Tue, May 02, 2023 at 06:40:03AM +0900, Greg Kroah-Hartman wrote:
>>> On Mon, May 01, 2023 at 07:22:56AM +0100, Chris Clayton wrote:
>>>> 6.3.1 FTBFS thusly:
>>>
>>> What is "FTBFS"?
>>>
>>>> drivers/net/wireguard/timers.c: In function 'wg_expired_retransmit_handshake':
>>>> <command-line>: error: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'
>>>> [-Werror=format=]
>>>> <command-line>: note: in expansion of macro 'KBUILD_MODNAME'
>>>> ./include/linux/dynamic_debug.h:223:29: note: in expansion of macro 'pr_fmt'
>>>> 223 | func(&id, ##__VA_ARGS__); \
>>>> | ^~~~~~~~~~~
>>>
>>> <snip>
>>>
>>>> There's a patch to drivers/net/wireguard/timers.c that fixes these errors and you can find it at
>>>> 2d4ee16d969c97996e80e4c9cb6de0acaff22c9f in Linus' tree.
>>>
>>> Thanks for this report, we'll queue it up soon.
>>
>> Odd, that commit is in 6.2 already, so how are you applying this to
>> 6.3.y?
>
> And this is only a gcc13 issue, right? So it's not a regression, it's
> always been there, nothing new caused it in this release from what I can
> tell.
>
> Actually I don't see how this is an issue in 6.3.1 anyway, as again, the
> proposed fix you gave is in 6.2, so what really is happening here?

You seem not to have seen the email I sent shortly after my original report. In that email I apologised for the noise
because, due to a caffeine deficiency, I had reported the problem against the wrong kernel version and that it actually
occurs 6.1.27. gcc13 spits it out as a warning, but kernel build system is setbup to treat warnings as errors, so the
build fails.

Chris
>
> confused,
>
> greg k-h

2023-05-06 06:02:12

by Greg KH

[permalink] [raw]
Subject: Re: Linux 6.3.1

On Tue, May 02, 2023 at 02:12:58PM +0100, Chris Clayton wrote:
> Hi Greg
>
> On 02/05/2023 08:31, Greg Kroah-Hartman wrote:
> > On Tue, May 02, 2023 at 08:43:47AM +0900, Greg Kroah-Hartman wrote:
> >> On Tue, May 02, 2023 at 06:40:03AM +0900, Greg Kroah-Hartman wrote:
> >>> On Mon, May 01, 2023 at 07:22:56AM +0100, Chris Clayton wrote:
> >>>> 6.3.1 FTBFS thusly:
> >>>
> >>> What is "FTBFS"?
> >>>
> >>>> drivers/net/wireguard/timers.c: In function 'wg_expired_retransmit_handshake':
> >>>> <command-line>: error: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'
> >>>> [-Werror=format=]
> >>>> <command-line>: note: in expansion of macro 'KBUILD_MODNAME'
> >>>> ./include/linux/dynamic_debug.h:223:29: note: in expansion of macro 'pr_fmt'
> >>>> 223 | func(&id, ##__VA_ARGS__); \
> >>>> | ^~~~~~~~~~~
> >>>
> >>> <snip>
> >>>
> >>>> There's a patch to drivers/net/wireguard/timers.c that fixes these errors and you can find it at
> >>>> 2d4ee16d969c97996e80e4c9cb6de0acaff22c9f in Linus' tree.
> >>>
> >>> Thanks for this report, we'll queue it up soon.
> >>
> >> Odd, that commit is in 6.2 already, so how are you applying this to
> >> 6.3.y?
> >
> > And this is only a gcc13 issue, right? So it's not a regression, it's
> > always been there, nothing new caused it in this release from what I can
> > tell.
> >
> > Actually I don't see how this is an issue in 6.3.1 anyway, as again, the
> > proposed fix you gave is in 6.2, so what really is happening here?
>
> You seem not to have seen the email I sent shortly after my original report. In that email I apologised for the noise
> because, due to a caffeine deficiency, I had reported the problem against the wrong kernel version and that it actually
> occurs 6.1.27. gcc13 spits it out as a warning, but kernel build system is setbup to treat warnings as errors, so the
> build fails.

Ok, but this is not a new issue, right? 6.1.26 should have had the same
problem from what I can tell.

greg k-h

2023-05-06 06:03:09

by Greg KH

[permalink] [raw]
Subject: no sha256sum for 6.3.1 (was Re: Linux 6.3.1)

On Mon, May 01, 2023 at 03:03:45PM +0200, Ronald Warsow wrote:
> Hi Greg
>
> fetching new kernels via script:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/mricon/korg-helpers.git/tree/get-verified-tarball
>
> it seems
> https://cdn.kernel.org/pub/linux/kernel/v6.x/sha256sums.asc
>
> doesn't contain a hash for 6.3.1

Yeah, that does look odd.

Konstantin, I think you said you updated some things on the servers
right after I did the 6.3.1 release, would this have caused the
signature to not be recorded in this file?

thanks,

greg k-h

2023-05-06 10:18:24

by Chris Clayton

[permalink] [raw]
Subject: Re: Linux 6.3.1



On 06/05/2023 01:52, Greg Kroah-Hartman wrote:
> On Tue, May 02, 2023 at 02:12:58PM +0100, Chris Clayton wrote:
>> Hi Greg
>>
>> On 02/05/2023 08:31, Greg Kroah-Hartman wrote:
>>> On Tue, May 02, 2023 at 08:43:47AM +0900, Greg Kroah-Hartman wrote:
>>>> On Tue, May 02, 2023 at 06:40:03AM +0900, Greg Kroah-Hartman wrote:
>>>>> On Mon, May 01, 2023 at 07:22:56AM +0100, Chris Clayton wrote:
>>>>>> 6.3.1 FTBFS thusly:
>>>>>
>>>>> What is "FTBFS"?
>>>>>
>>>>>> drivers/net/wireguard/timers.c: In function 'wg_expired_retransmit_handshake':
>>>>>> <command-line>: error: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'
>>>>>> [-Werror=format=]
>>>>>> <command-line>: note: in expansion of macro 'KBUILD_MODNAME'
>>>>>> ./include/linux/dynamic_debug.h:223:29: note: in expansion of macro 'pr_fmt'
>>>>>> 223 | func(&id, ##__VA_ARGS__); \
>>>>>> | ^~~~~~~~~~~
>>>>>
>>>>> <snip>
>>>>>
>>>>>> There's a patch to drivers/net/wireguard/timers.c that fixes these errors and you can find it at
>>>>>> 2d4ee16d969c97996e80e4c9cb6de0acaff22c9f in Linus' tree.
>>>>>
>>>>> Thanks for this report, we'll queue it up soon.
>>>>
>>>> Odd, that commit is in 6.2 already, so how are you applying this to
>>>> 6.3.y?
>>>
>>> And this is only a gcc13 issue, right? So it's not a regression, it's
>>> always been there, nothing new caused it in this release from what I can
>>> tell.
>>>
>>> Actually I don't see how this is an issue in 6.3.1 anyway, as again, the
>>> proposed fix you gave is in 6.2, so what really is happening here?
>>
>> You seem not to have seen the email I sent shortly after my original report. In that email I apologised for the noise
>> because, due to a caffeine deficiency, I had reported the problem against the wrong kernel version and that it actually
>> occurs 6.1.27. gcc13 spits it out as a warning, but kernel build system is setbup to treat warnings as errors, so the
>> build fails.
>
> Ok, but this is not a new issue, right? 6.1.26 should have had the same
> problem from what I can tell.
>

I don't know. I haven't tried to build 6.1.26 with gcc13. The commit message for the patch in Linus' tree says that this
is a new warning in gcc13. The kernel build system configures gcc to treat warnings as errors so, with gcc13, the build
failed and I reported the failure in the initial email of this thread. Looking at that patch submission
(https://lore.kernel.org/all/[email protected]/), it appears not to have been tagged for or
copied to stable.

Once I'd realised that I had reported the problem against the wrong kernel version, I sent my apologetic email and sent
a new email reporting the problem against 6.1.27. In response to that (I assume), you've queued the patch for 6.1 stable
and for 5.15 and 5.10, so everything seems to be in order.

Chris


> greg k-h

2023-05-08 17:11:31

by Konstantin Ryabitsev

[permalink] [raw]
Subject: Re: no sha256sum for 6.3.1 (was Re: Linux 6.3.1)

On Sat, May 06, 2023 at 09:38:35AM +0900, Greg KH wrote:
> > fetching new kernels via script:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/mricon/korg-helpers.git/tree/get-verified-tarball
> >
> > it seems
> > https://cdn.kernel.org/pub/linux/kernel/v6.x/sha256sums.asc
> >
> > doesn't contain a hash for 6.3.1
>
> Yeah, that does look odd.
>
> Konstantin, I think you said you updated some things on the servers
> right after I did the 6.3.1 release, would this have caused the
> signature to not be recorded in this file?

Sorry, this got fixed last week. I forgot to mount the key storage after the
final reboot. It should be all good now.

-K

2023-05-08 17:28:23

by Ronald Warsow

[permalink] [raw]
Subject: Re: no sha256sum for 6.3.1 (was Re: Linux 6.3.1)

On 08.05.23 19:01, Konstantin Ryabitsev wrote:
> On Sat, May 06, 2023 at 09:38:35AM +0900, Greg KH wrote:
>>> fetching new kernels via script:
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/mricon/korg-helpers.git/tree/get-verified-tarball
>>>
>>> it seems
>>> https://cdn.kernel.org/pub/linux/kernel/v6.x/sha256sums.asc
>>>
>>> doesn't contain a hash for 6.3.1
>>
>> Yeah, that does look odd.
>>
>> Konstantin, I think you said you updated some things on the servers
>> right after I did the 6.3.1 release, would this have caused the
>> signature to not be recorded in this file?
>
> Sorry, this got fixed last week. I forgot to mount the key storage after the
> final reboot. It should be all good now.
>
> -K

Thanks
--
Ronald

2023-05-09 03:29:05

by Greg KH

[permalink] [raw]
Subject: Re: no sha256sum for 6.3.1 (was Re: Linux 6.3.1)

On Mon, May 08, 2023 at 01:01:07PM -0400, Konstantin Ryabitsev wrote:
> On Sat, May 06, 2023 at 09:38:35AM +0900, Greg KH wrote:
> > > fetching new kernels via script:
> > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/mricon/korg-helpers.git/tree/get-verified-tarball
> > >
> > > it seems
> > > https://cdn.kernel.org/pub/linux/kernel/v6.x/sha256sums.asc
> > >
> > > doesn't contain a hash for 6.3.1
> >
> > Yeah, that does look odd.
> >
> > Konstantin, I think you said you updated some things on the servers
> > right after I did the 6.3.1 release, would this have caused the
> > signature to not be recorded in this file?
>
> Sorry, this got fixed last week. I forgot to mount the key storage after the
> final reboot. It should be all good now.

I see it there, now, thanks!

greg k-h