2023-11-21 14:50:15

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] usb: gadget: uvc: Add framebased frame format support

On Tue, Nov 14, 2023 at 04:55:16PM +0530, Akash Kumar wrote:
> Add support for framebased frame format which can be used to support
> multiple formats like H264 or H265 other than mjpeg and YUV frames.
>
> Framebased format is set to H264 by default, which can be updated to
> other formats by updating the GUID through guid configfs attribute.
>
> Also,add UVC 1.5 extension to support H264 format and different camera
> controls, adding support for Exposure, Zoom, Pan, tilt.

When you say "also" or list different things that are done in a single
change, that's a huge hint to divide this up into smaller patches and
make it a patch series.

Please do that here.

thanks,

greg k-h


2023-11-21 14:59:02

by Dan Scally

[permalink] [raw]
Subject: Re: [PATCH] usb: gadget: uvc: Add framebased frame format support

Hello

On 21/11/2023 13:58, Greg Kroah-Hartman wrote:
> On Tue, Nov 14, 2023 at 04:55:16PM +0530, Akash Kumar wrote:
>> Add support for framebased frame format which can be used to support
>> multiple formats like H264 or H265 other than mjpeg and YUV frames.
>>
>> Framebased format is set to H264 by default, which can be updated to
>> other formats by updating the GUID through guid configfs attribute.
>>
>> Also,add UVC 1.5 extension to support H264 format and different camera
>> controls, adding support for Exposure, Zoom, Pan, tilt.
> When you say "also" or list different things that are done in a single
> change, that's a huge hint to divide this up into smaller patches and
> make it a patch series.
>
> Please do that here.


Could you also CC me on the series when you post it please?

>
> thanks,
>
> greg k-h
>