2023-09-05 16:07:08

by Liang, Kan

[permalink] [raw]
Subject: Re: [PATCH v1 0/3] perf list/debug output fixes



On 2023-08-31 3:14 a.m., Ian Rogers wrote:
> Fix a long standing parse_events_term cloning bug so that the bad
> display of terms can be fixed and the code somewhat more intuitive:
> https://lore.kernel.org/lkml/[email protected]/
>

Tested-by: Kan Liang <[email protected]>

Thanks,
Kan

> Fix a bug caused by the rename of 'cpu' to 'default_core' in perf list.
>
> Add more documentation, increase type safety and fix some related bugs
> where terms weren't initialized properly.
>
> Ian Rogers (3):
> perf list: Don't print Unit for default_core
> perf parse-events: Name the two term enums
> perf parse-events: Fix propagation of term's no_value when cloning
>
> tools/perf/builtin-list.c | 2 +-
> tools/perf/util/parse-events.c | 203 +++++++++++++++++++++++----------
> tools/perf/util/parse-events.h | 60 +++++++---
> tools/perf/util/parse-events.l | 2 +-
> tools/perf/util/parse-events.y | 27 +++--
> tools/perf/util/pmu.c | 2 +-
> 6 files changed, 207 insertions(+), 89 deletions(-)
>