2023-07-20 10:39:57

by Chengming Zhou

[permalink] [raw]
Subject: [PATCH] blk-mq: delete dead struct blk_mq_hw_ctx->queued field

From: Chengming Zhou <[email protected]>

This counter is not used anywhere, so delete it.

Signed-off-by: Chengming Zhou <[email protected]>
---
include/linux/blk-mq.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index 01e8c31db665..958ed7e89b30 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -393,8 +393,6 @@ struct blk_mq_hw_ctx {
*/
struct blk_mq_tags *sched_tags;

- /** @queued: Number of queued requests. */
- unsigned long queued;
/** @run: Number of dispatched requests. */
unsigned long run;

--
2.41.0



2023-07-20 15:52:59

by Bart Van Assche

[permalink] [raw]
Subject: Re: [PATCH] blk-mq: delete dead struct blk_mq_hw_ctx->queued field

On 7/20/23 02:55, [email protected] wrote:
> From: Chengming Zhou <[email protected]>
>
> This counter is not used anywhere, so delete it.
>
> Signed-off-by: Chengming Zhou <[email protected]>
> ---
> include/linux/blk-mq.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
> index 01e8c31db665..958ed7e89b30 100644
> --- a/include/linux/blk-mq.h
> +++ b/include/linux/blk-mq.h
> @@ -393,8 +393,6 @@ struct blk_mq_hw_ctx {
> */
> struct blk_mq_tags *sched_tags;
>
> - /** @queued: Number of queued requests. */
> - unsigned long queued;
> /** @run: Number of dispatched requests. */
> unsigned long run;

Reviewed-by: Bart Van Assche <[email protected]>

2023-07-20 20:24:42

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH] blk-mq: delete dead struct blk_mq_hw_ctx->queued field


On Thu, 20 Jul 2023 17:55:12 +0800, [email protected] wrote:
> This counter is not used anywhere, so delete it.
>
>

Applied, thanks!

[1/1] blk-mq: delete dead struct blk_mq_hw_ctx->queued field
commit: 3641c90c4e369c8d0af5483e879174400a152cf8

Best regards,
--
Jens Axboe