Add support for multiple supplies.
Signed-off-by: Naresh Solanki <[email protected]>
---
.../devicetree/bindings/regulator/regulator-output.yaml | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/regulator/regulator-output.yaml b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
index 078b37a1a71a..6d077f123729 100644
--- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
+++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
@@ -21,13 +21,13 @@ properties:
compatible:
const: regulator-output
- vout-supply:
+patternProperties:
+ ".*-supply":
description:
Phandle of the regulator supplying the output.
required:
- compatible
- - vout-supply
additionalProperties: false
@@ -37,3 +37,8 @@ examples:
compatible = "regulator-output";
vout-supply = <&output_reg>;
};
+ output1 {
+ compatible = "regulator-output";
+ sw0-supply = <&output_reg0>;
+ sw1-supply = <&output_reg2>;
+ };
base-commit: f9a1d31874c383f58bb4f89bfe79b764682cd026
--
2.41.0
On Wed, Oct 04, 2023 at 02:05:26PM +0200, Naresh Solanki wrote:
> Add support for multiple supplies.
Why?
>
> Signed-off-by: Naresh Solanki <[email protected]>
> ---
> .../devicetree/bindings/regulator/regulator-output.yaml | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/regulator-output.yaml b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> index 078b37a1a71a..6d077f123729 100644
> --- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> @@ -21,13 +21,13 @@ properties:
> compatible:
> const: regulator-output
>
> - vout-supply:
> +patternProperties:
> + ".*-supply":
> description:
> Phandle of the regulator supplying the output.
>
> required:
> - compatible
> - - vout-supply
>
> additionalProperties: false
>
> @@ -37,3 +37,8 @@ examples:
> compatible = "regulator-output";
> vout-supply = <&output_reg>;
> };
> + output1 {
> + compatible = "regulator-output";
> + sw0-supply = <&output_reg0>;
> + sw1-supply = <&output_reg2>;
> + };
>
> base-commit: f9a1d31874c383f58bb4f89bfe79b764682cd026
> --
> 2.41.0
>
Hi Rob,
On Wed, 4 Oct 2023 at 20:44, Rob Herring <[email protected]> wrote:
>
> On Wed, Oct 04, 2023 at 02:05:26PM +0200, Naresh Solanki wrote:
> > Add support for multiple supplies.
>
> Why?
1. Driver is already capable of that using platform data. Hence added
support to read DT property & initialize the same for multiple
supplies instead of being limited to one.
2. This is particularly useful in cases wherein 2 or more regulators
are coupled together, for example in a PCIe connector having 3.3V &
12V.
Regards,
Naresh
>
> >
> > Signed-off-by: Naresh Solanki <[email protected]>
> > ---
> > .../devicetree/bindings/regulator/regulator-output.yaml | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/regulator/regulator-output.yaml b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> > index 078b37a1a71a..6d077f123729 100644
> > --- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> > +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> > @@ -21,13 +21,13 @@ properties:
> > compatible:
> > const: regulator-output
> >
> > - vout-supply:
> > +patternProperties:
> > + ".*-supply":
> > description:
> > Phandle of the regulator supplying the output.
> >
> > required:
> > - compatible
> > - - vout-supply
> >
> > additionalProperties: false
> >
> > @@ -37,3 +37,8 @@ examples:
> > compatible = "regulator-output";
> > vout-supply = <&output_reg>;
> > };
> > + output1 {
> > + compatible = "regulator-output";
> > + sw0-supply = <&output_reg0>;
> > + sw1-supply = <&output_reg2>;
> > + };
> >
> > base-commit: f9a1d31874c383f58bb4f89bfe79b764682cd026
> > --
> > 2.41.0
> >
On 05/10/2023 09:46, Naresh Solanki wrote:
> Hi Rob,
>
>
> On Wed, 4 Oct 2023 at 20:44, Rob Herring <[email protected]> wrote:
>>
>> On Wed, Oct 04, 2023 at 02:05:26PM +0200, Naresh Solanki wrote:
>>> Add support for multiple supplies.
>>
>> Why?
> 1. Driver is already capable of that using platform data. Hence added
> support to read DT property & initialize the same for multiple
> supplies instead of being limited to one.
I am not sure that's a valid reason. Bindings focus on the hardware. We
do not describe here driver capabilities.
> 2. This is particularly useful in cases wherein 2 or more regulators
> are coupled together, for example in a PCIe connector having 3.3V &
> 12V.
Commit message should explain this. Each commit, when not obvious,
should say why you are doing things.
Best regards,
Krzysztof
On Thu, Oct 05, 2023 at 12:46:31AM PDT, Naresh Solanki wrote:
>Hi Rob,
>
>
>On Wed, 4 Oct 2023 at 20:44, Rob Herring <[email protected]> wrote:
>>
>> On Wed, Oct 04, 2023 at 02:05:26PM +0200, Naresh Solanki wrote:
>> > Add support for multiple supplies.
>>
>> Why?
>1. Driver is already capable of that using platform data. Hence added
>support to read DT property & initialize the same for multiple
>supplies instead of being limited to one.
>2. This is particularly useful in cases wherein 2 or more regulators
>are coupled together, for example in a PCIe connector having 3.3V &
>12V.
>
Hmm -- apologies if I pointed you in the wrong direction here on the
last revision (or should have considered this earlier), but is there a
particular need for this arrangement to be described by a single
regulator-output DT node instead of just having one node per supply? If
they're independently-controlled voltage outputs, treating them as two
separate things instead of a single ganged one seems like it might be
more appropriate anyway...
Zev