2023-05-16 20:25:43

by Arnd Bergmann

Subject: [PATCH] remoteproc: qcom: pas: mark adsp_segment_dump() static

From: Arnd Bergmann <[email protected]>

The function has no other callers and should not be globally defined.
Making it static avoids this warning:

drivers/remoteproc/qcom_q6v5_pas.c:108:6: error: no previous prototype for 'adsp_segment_dump'

Fixes: a376c10d45a8 ("remoteproc: qcom: pas: Adjust the phys addr wrt the mem region")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/remoteproc/qcom_q6v5_pas.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index e34d82b18a67..a1d69721a0e7 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -105,8 +105,9 @@ struct qcom_adsp {
struct qcom_scm_pas_metadata dtb_pas_metadata;
};

-void adsp_segment_dump(struct rproc *rproc, struct rproc_dump_segment *segment,
- void *dest, size_t offset, size_t size)
+static void adsp_segment_dump(struct rproc *rproc,
+ struct rproc_dump_segment *segment,
+ void *dest, size_t offset, size_t size)
{
struct qcom_adsp *adsp = rproc->priv;
int total_offset;
--
2.39.2

2023-05-18 08:01:10

by Mukesh Ojha

Subject: Re: [PATCH] remoteproc: qcom: pas: mark adsp_segment_dump() static

On 5/17/2023 1:53 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> The function has no other callers and should not be globally defined.
> Making it static avoids this warning:
>
> drivers/remoteproc/qcom_q6v5_pas.c:108:6: error: no previous prototype for 'adsp_segment_dump'
>
> Fixes: a376c10d45a8 ("remoteproc: qcom: pas: Adjust the phys addr wrt the mem region")
> Signed-off-by: Arnd Bergmann <[email protected]>

This seems to be posted already

https://lore.kernel.org/lkml/[email protected]/

-- Mukesh

> ---
> drivers/remoteproc/qcom_q6v5_pas.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index e34d82b18a67..a1d69721a0e7 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -105,8 +105,9 @@ struct qcom_adsp {
> struct qcom_scm_pas_metadata dtb_pas_metadata;
> };
>
> -void adsp_segment_dump(struct rproc *rproc, struct rproc_dump_segment *segment,
> - void *dest, size_t offset, size_t size)
> +static void adsp_segment_dump(struct rproc *rproc,
> + struct rproc_dump_segment *segment,
> + void *dest, size_t offset, size_t size)
> {
> struct qcom_adsp *adsp = rproc->priv;
> int total_offset;